public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/94617] Simple if condition not optimized
Date: Sun, 25 Jun 2023 22:29:49 +0000	[thread overview]
Message-ID: <bug-94617-4-CzOGB1bywd@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94617-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94617

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
For the first function (vanilla_bandpass), GCC 12+ produces now:
        movq    %rcx, %rax
        cmpl    %edx, %edi
        jg      .L2
        cmpl    %esi, %edx
        cmovl   %r8, %rax
.L2:
        ret


For the second the problem is:
  _3 = ~within_interval_11;
  # RANGE [irange] long unsigned int [0, 1] NONZERO 0x1
  _4 = (long unsigned intD.16) _3;
...
  low_ptr_13 = _4 * low.0_5;
  # RANGE [irange] long unsigned int [0, 1] NONZERO 0x1
  _6 = (long unsigned intD.16) within_interval_11;
...
  high_ptr_15 = _6 * high.1_7;
  ptr_sum_16 = low_ptr_13 + high_ptr_15;

We should recongize that ptr_sum_16 is really just within_interval_11 ?
high.1_7 : low.0_5;

Match pattern for that:
```
(for op (plus bit_ior bit_xor)
 (simplify
  (op:c (mult:c (convert @0) @1)
        (mult:c (convert (bit_not @0)) @2))
  (if (INTEGRAL_TYPE_P (TREE_TYPE (@0))
      && TYPE_PRECISION (TREE_TYPE (@0)) == 1
      && TYPE_UNSIGNED (TREE_TYPE (@0)))
  (cond @0 @1 @2))
```

  parent reply	other threads:[~2023-06-25 22:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 11:28 [Bug tree-optimization/94617] New: " soap at gentoo dot org
2020-04-16 11:57 ` [Bug tree-optimization/94617] " rguenth at gcc dot gnu.org
2020-04-16 12:02 ` soap at gentoo dot org
2020-04-16 12:10 ` rguenth at gcc dot gnu.org
2020-04-16 12:17 ` rguenth at gcc dot gnu.org
2020-04-16 12:18 ` soap at gentoo dot org
2020-04-16 12:47 ` jakub at gcc dot gnu.org
2020-04-16 13:11 ` rguenth at gcc dot gnu.org
2021-07-19  3:40 ` [Bug target/94617] " pinskia at gcc dot gnu.org
2022-11-26 20:43 ` pinskia at gcc dot gnu.org
2023-06-25 22:29 ` pinskia at gcc dot gnu.org [this message]
2023-06-25 22:45 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94617-4-CzOGB1bywd@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).