public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/94617] Simple if condition not optimized
Date: Thu, 16 Apr 2020 12:47:11 +0000	[thread overview]
Message-ID: <bug-94617-4-f9rv27LoSx@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-94617-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94617

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to David Seifert from comment #5)
> just benchmarked the code on an oldish Ivybridge. GCC with vanilla_bandpass
> is 2.1x slower than GCC with funky_bandpass, and GCC with funky_bandpass is
> 12% slower than Clang with vanilla_bandpass.

It really depends, conditional moves are really badly implemented in x86 and
sometimes they do improve speed and at other times they slow things down by
huge amounts, which mostly depends on how well the CPU can predict branches if
there are (if well, then branches are significantly faster, if they are very
badly predictable, then conditional moves are faster).

As for turning it into
(unsigned)x - a < (unsigned)b - a
reassoc has
optimize_range_tests_var_bound
which right now handles
   a >= 0 && a < b into (unsigned) a < (unsigned) b
   a >= 0 && a <= b into (unsigned) a <= (unsigned) b
Now
   a >= b && a < c into (unsigned) a - b < (unsigned) c - b
isn't equivalent to that, e.g. if b is 5 and c 4.

  parent reply	other threads:[~2020-04-16 12:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 11:28 [Bug tree-optimization/94617] New: " soap at gentoo dot org
2020-04-16 11:57 ` [Bug tree-optimization/94617] " rguenth at gcc dot gnu.org
2020-04-16 12:02 ` soap at gentoo dot org
2020-04-16 12:10 ` rguenth at gcc dot gnu.org
2020-04-16 12:17 ` rguenth at gcc dot gnu.org
2020-04-16 12:18 ` soap at gentoo dot org
2020-04-16 12:47 ` jakub at gcc dot gnu.org [this message]
2020-04-16 13:11 ` rguenth at gcc dot gnu.org
2021-07-19  3:40 ` [Bug target/94617] " pinskia at gcc dot gnu.org
2022-11-26 20:43 ` pinskia at gcc dot gnu.org
2023-06-25 22:29 ` pinskia at gcc dot gnu.org
2023-06-25 22:45 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-94617-4-f9rv27LoSx@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).