[Bug preprocessor/94657] New: [patch] libcpp uses 'AR = ar' tool even if --build/--host are passed explicitly.

[Bug preprocessor/94657] New: [patch] libcpp uses 'AR = ar' tool even if --build/--host are passed explicitly.

[slyfox at inbox dot ru]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94657

            Bug ID: 94657
           Summary: [patch] libcpp uses 'AR = ar' tool even if
                    --build/--host are passed explicitly.
           Product: gcc
           Version: 9.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: preprocessor
          Assignee: unassigned at gcc dot gnu.org
          Reporter: slyfox at inbox dot ru
  Target Milestone: ---

Created attachment 48305
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48305&action=edit
libcpp-ar.patch

Initially reported by Agostino Sarubbo as https://bugs.gentoo.org/718004.

There Gentoo builds gcc-9.3.0 as:
    --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu
and observes 'ar' being called by libcpp. It should be 'x86_64-pc-linux-gnu-ar'
instead.

libcpp/Makefile.in hardcodes 'AR = ar' (but does not hardcode RANLIB for
example:  'RANLIB = @RANLIB@'). 

A few other tools do it:

  $ git grep 'AR = ar' | cat
  gcc/ada/gcc-interface/Makefile.in:AR = ar
  intl/Makefile.in:AR = ar
  libcpp/Makefile.in:AR = ar
  libdecnumber/Makefile.in:AR = ar

but only libcpp refers 'ar' and fails build when 'ar' does not exist:

  ar cru libcpp.a charset.o directives.o directives-only.o errors.o expr.o
files.o identifiers.o init.o lex.o line-map.o macro.o mkdeps.o pch.o symtab.o
traditional.o
  /bin/bash: ar: command not found

Attached patch adds AR detection similar to other libraries.

But maybe it should be set in top-level Makefile?

[Bug preprocessor/94657] [patch] libcpp uses 'AR = ar' tool even if --build/--host are passed explicitly.

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94657

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egallager at gcc dot gnu.org

--- Comment #1 from Eric Gallager <egallager at gcc dot gnu.org> ---
please submit the patch to the gcc-patches mailing list for review

[Bug preprocessor/94657] [patch] libcpp uses 'AR = ar' tool even if --build/--host are passed explicitly.

[slyfox at inbox dot ru]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94657

--- Comment #2 from Sergei Trofimovich <slyfox at inbox dot ru> ---
Sent as https://gcc.gnu.org/pipermail/gcc-patches/2020-April/544379.html

[Bug preprocessor/94657] [patch] libcpp uses 'AR = ar' tool even if --build/--host are passed explicitly.

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94657

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2020-April/5
                   |                            |44379.html
           Keywords|                            |patch

--- Comment #3 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Sergei Trofimovich from comment #2)
> Sent as https://gcc.gnu.org/pipermail/gcc-patches/2020-April/544379.html

thanks, adding the "patch" keyword

[Bug preprocessor/94657] [patch] libcpp uses 'AR = ar' tool even if --build/--host are passed explicitly.

[slyfox at inbox dot ru]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94657

Sergei Trofimovich <slyfox at inbox dot ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Sergei Trofimovich <slyfox at inbox dot ru> ---
On #gcc Tobias pointed out that similar patch was merged a few days ago:
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=731c4ce0e93065fb70db5faa2bd6c9c6bad56738

https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546337.html