[Bug c/94669] New: libcc1/libcc1.cc; 2 * minor performance problem

[Bug c/94669] New: libcc1/libcc1.cc; 2 * minor performance problem

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94669

            Bug ID: 94669
           Summary: libcc1/libcc1.cc; 2 * minor performance problem
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

cppcheck says:

1.

trunk.git/libcc1/libcc1.cc:112:57: performance: Function parameter
'driver_filename' should be passed by const reference. [passedByValue]

Source code is

    compiler_driver_filename (libcc1 *self, std::string driver_filename)

Maybe better code

    compiler_driver_filename (libcc1 *self, const std::string &
driver_filename)

2.

trunk.git/libcc1/libcc1.cc:96:56: performance: Function parameter
'triplet_regexp' should be passed by const reference. [passedByValue]

    compiler_driver_filename (libcc1 *self, std::string driver_filename)

Duplicate.

In a similar position:

trunk.git/libcc1/libcp1.cc:114:57: performance: Function parameter
'driver_filename' should be passed by const reference. [passedByValue]

and 

trunk.git/libcc1/libcp1.cc:98:56: performance: Function parameter
'triplet_regexp' should be passed by const reference. [passedByValue]

[Bug c/94669] libcc1: 4 * minor performance problem

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94669

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.kratochvil at redhat dot com

--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
>From git blame, adding original author.

[Bug c/94669] libcc1: 4 * minor performance problem

[jan.kratochvil at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94669

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoliva at gcc dot gnu.org

--- Comment #2 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
These fixes are very simple, maybe you can check it in as obvious?

BTW the file was written by Alexandre Oliva, I wrote no single line there.

[Bug c/94669] libcc1: 4 * minor performance problem

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94669

--- Comment #3 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Jan Kratochvil from comment #2)
> These fixes are very simple, maybe you can check it in as obvious?

Sorry no, I have no checkin permission.

> BTW the file was written by Alexandre Oliva, I wrote no single line there.

git blame seems to think you wrote it. Maybe it is in error.

[Bug c/94669] libcc1: 4 * minor performance problem

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94669

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |89863
           See Also|https://gcc.gnu.org/bugzill |
                   |a/show_bug.cgi?id=89863     |
                 CC|                            |egallager at gcc dot gnu.org

--- Comment #4 from Eric Gallager <egallager at gcc dot gnu.org> ---
moving the cppcheck meta-bug from the "See Also" field to the "Blocks" field


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89863
[Bug 89863] [meta-bug] Issues in gcc that other static analyzers (cppcheck,
clang-static-analyzer, PVS-studio) find that gcc misses

[Bug c/94669] libcc1: 4 * minor performance problem

[tromey at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94669

Tom Tromey <tromey at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |tromey at gcc dot gnu.org

--- Comment #5 from Tom Tromey <tromey at gcc dot gnu.org> ---
I have a patch for these.

[Bug c/94669] libcc1: 4 * minor performance problem

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94669

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@gcc.gnu.org>:

https://gcc.gnu.org/g:96deddca2e535d09db1d244a96a1efc20e24b673

commit r12-473-g96deddca2e535d09db1d244a96a1efc20e24b673
Author: Tom Tromey <tom@tromey.com>
Date:   Tue May 4 15:26:58 2021 -0600

    libcc1: avoid extra string copies

    PR c/94669 points out that a couple of spots in libcc1 take a
    std::string where a reference would do.  This changes these spots to
    take a const char *, to reduce the number of copies.

    libcc1

            PR c/94669
            * compiler.hh (compiler_driver_filename): Take const char *.
            (compiler_triplet_regexp): Likewise.

[Bug c/94669] libcc1: 4 * minor performance problem

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94669

--- Comment #7 from David Binderman <dcb314 at hotmail dot com> ---
Could this bug be marked as fixed, then ?

[Bug c/94669] libcc1: 4 * minor performance problem

[tromey at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94669

--- Comment #8 from Tom Tromey <tromey at gcc dot gnu.org> ---
(In reply to David Binderman from comment #7)
> Could this bug be marked as fixed, then ?

Yes, but I don't really know the GCC rules about closing reports
any more, so someone else probably ought to handle it.

[Bug c/94669] libcc1: 4 * minor performance problem

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94669

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
   Target Milestone|---                         |12.0

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I don't think this needs to be backported, so it can just be closed as fixed
for GCC 12.