public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/94854] New: Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17
@ 2020-04-29 17:22 redbeard0531 at gmail dot com
2020-04-29 18:02 ` [Bug libstdc++/94854] " cvs-commit at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: redbeard0531 at gmail dot com @ 2020-04-29 17:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94854
Bug ID: 94854
Summary: Comment in basic_string.tcc incorrectly says
std::string doesn't have explicit instantiation in
C++17
Product: gcc
Version: 9.3.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: redbeard0531 at gmail dot com
Target Milestone: ---
https://github.com/gcc-mirror/gcc/blob/0c8217b16f307c3eedce8f22354714938613f701/libstdc%2B%2B-v3/include/bits/basic_string.tcc#L1612-L1617
Looks like the code changed in this commit
https://github.com/gcc-mirror/gcc/commit/1a289fa36294627c252492e4c18d7877a7c80dc1#diff-56639139bdefbe09b8f41c465ebf1ab5,
but the comment wasn't adjusted to match. While I recognize this isn't an issue
for 99.999999999% of users, hopefully if this is fixed it will save someone
else that minute or two of staring at the code trying to reconcile it with the
comment.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/94854] Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17
2020-04-29 17:22 [Bug libstdc++/94854] New: Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17 redbeard0531 at gmail dot com
@ 2020-04-29 18:02 ` cvs-commit at gcc dot gnu.org
2020-04-29 18:03 ` redi at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-04-29 18:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94854
--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:8f1591763fd50b143af0dc1770741f326a97583a
commit r10-8056-g8f1591763fd50b143af0dc1770741f326a97583a
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Apr 29 18:57:34 2020 +0100
libstdc++: Fix outdated comment about std::string instantiations (PR 94854)
PR libstdc++/94854
* include/bits/basic_string.tcc: Update comment about explicit
instantiations.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/94854] Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17
2020-04-29 17:22 [Bug libstdc++/94854] New: Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17 redbeard0531 at gmail dot com
2020-04-29 18:02 ` [Bug libstdc++/94854] " cvs-commit at gcc dot gnu.org
@ 2020-04-29 18:03 ` redi at gcc dot gnu.org
2020-04-30 6:44 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2020-04-29 18:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94854
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2020-04-29
Ever confirmed|0 |1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/94854] Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17
2020-04-29 17:22 [Bug libstdc++/94854] New: Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17 redbeard0531 at gmail dot com
2020-04-29 18:02 ` [Bug libstdc++/94854] " cvs-commit at gcc dot gnu.org
2020-04-29 18:03 ` redi at gcc dot gnu.org
@ 2020-04-30 6:44 ` rguenth at gcc dot gnu.org
2021-04-20 18:53 ` cvs-commit at gcc dot gnu.org
2021-04-20 18:55 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-04-30 6:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94854
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/94854] Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17
2020-04-29 17:22 [Bug libstdc++/94854] New: Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17 redbeard0531 at gmail dot com
` (2 preceding siblings ...)
2020-04-30 6:44 ` rguenth at gcc dot gnu.org
@ 2021-04-20 18:53 ` cvs-commit at gcc dot gnu.org
2021-04-20 18:55 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-20 18:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94854
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:8ceccbc3bbbba45ec4bb25ca833d2a6b62d2bb9c
commit r9-9383-g8ceccbc3bbbba45ec4bb25ca833d2a6b62d2bb9c
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Apr 29 18:57:34 2020 +0100
libstdc++: Fix outdated comment about std::string instantiations (PR 94854)
PR libstdc++/94854
* include/bits/basic_string.tcc: Update comment about explicit
instantiations.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/94854] Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17
2020-04-29 17:22 [Bug libstdc++/94854] New: Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17 redbeard0531 at gmail dot com
` (3 preceding siblings ...)
2021-04-20 18:53 ` cvs-commit at gcc dot gnu.org
@ 2021-04-20 18:55 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-04-20 18:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94854
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |9.4
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-20 18:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 17:22 [Bug libstdc++/94854] New: Comment in basic_string.tcc incorrectly says std::string doesn't have explicit instantiation in C++17 redbeard0531 at gmail dot com
2020-04-29 18:02 ` [Bug libstdc++/94854] " cvs-commit at gcc dot gnu.org
2020-04-29 18:03 ` redi at gcc dot gnu.org
2020-04-30 6:44 ` rguenth at gcc dot gnu.org
2021-04-20 18:53 ` cvs-commit at gcc dot gnu.org
2021-04-20 18:55 ` redi at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).