[Bug tree-optimization/94964] New: [8/9/10/11 Regression] ICE in add_phi_arg, at tree-phinodes.c:359 since r8-2993-ga7976089dba5e227

[Bug tree-optimization/94964] New: [8/9/10/11 Regression] ICE in add_phi_arg, at tree-phinodes.c:359 since r8-2993-ga7976089dba5e227

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94964

            Bug ID: 94964
           Summary: [8/9/10/11 Regression] ICE in add_phi_arg, at
                    tree-phinodes.c:359 since r8-2993-ga7976089dba5e227
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: rguenth at gcc dot gnu.org
  Target Milestone: ---

Quite old issue:

$ gcc
/home/marxin/Programming/gcc/gcc/testsuite/g++.old-deja/g++.robertl/eh990323-5.C
-fno-tree-sink -fno-guess-branch-probability -fno-tree-ch
-finline-small-functions -O1 --param=early-inlining-insns=100
-fpredictive-commoning -c
during GIMPLE pass: pcom
/home/marxin/Programming/gcc/gcc/testsuite/g++.old-deja/g++.robertl/eh990323-5.C:
In function ‘void f()’:
/home/marxin/Programming/gcc/gcc/testsuite/g++.old-deja/g++.robertl/eh990323-5.C:41:6:
internal compiler error: in add_phi_arg, at tree-phinodes.c:359
   41 | void f()
      |      ^
0x7eb110 add_phi_arg(gphi*, tree_node*, edge_def*, unsigned int)
        /home/marxin/Programming/gcc/gcc/tree-phinodes.c:359
0x1162f37 initialize_root_vars_lm
        /home/marxin/Programming/gcc/gcc/tree-predcom.c:1969
0x1162f37 execute_load_motion
        /home/marxin/Programming/gcc/gcc/tree-predcom.c:2001
0x1162f37 execute_pred_commoning
        /home/marxin/Programming/gcc/gcc/tree-predcom.c:2265
0x11654f2 tree_predictive_commoning_loop
        /home/marxin/Programming/gcc/gcc/tree-predcom.c:3308
0x11654f2 tree_predictive_commoning()
        /home/marxin/Programming/gcc/gcc/tree-predcom.c:3333
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug tree-optimization/94964] [8/9/10/11 Regression] ICE in add_phi_arg, at tree-phinodes.c:359 since r8-2993-ga7976089dba5e227

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94964

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      Known to work|                            |7.4.0
      Known to fail|                            |11.0, 8.3.0
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-05-06

[Bug tree-optimization/94964] [8/9/10/11 Regression] ICE in add_phi_arg, at tree-phinodes.c:359 since r8-2993-ga7976089dba5e227

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94964

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Target Milestone|---                         |8.5
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.  The loop does not have a preheader we can sink to so
gsi_insert_seq_on_edge_immediate will split the edge and the following
add_phi_arg breaks.

Now, the loop entry edge is an EH edge in this case, will dig what
the appropriate solution is.

[Bug tree-optimization/94964] [8/9/10/11 Regression] ICE in add_phi_arg, at tree-phinodes.c:359 since r8-2993-ga7976089dba5e227

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94964

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:6fc00b41e764219e2c88d8892d7c701c0d292a17

commit r11-139-g6fc00b41e764219e2c88d8892d7c701c0d292a17
Author: Richard Biener <rguenther@suse.de>
Date:   Wed May 6 10:23:15 2020 +0200

    middle-end/94964 - avoid EH loop entry with CP_SIMPLE_PREHEADERS

    Loop optimizers expect to be able to insert on the preheader
    edge w/o splitting it thus avoid ending up with a preheader
    that enters the loop via an EH edge (or an abnormal edge).

    2020-05-06  Richard Biener  <rguenther@suse.de>

            PR middle-end/94964
            * cfgloopmanip.c (create_preheader): Require non-complex
            preheader edge for CP_SIMPLE_PREHEADERS.

[Bug tree-optimization/94964] [8/9/10 Regression] ICE in add_phi_arg, at tree-phinodes.c:359 since r8-2993-ga7976089dba5e227

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94964

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|11.0                        |10.0
            Summary|[8/9/10/11 Regression] ICE  |[8/9/10 Regression] ICE in
                   |in add_phi_arg, at          |add_phi_arg, at
                   |tree-phinodes.c:359 since   |tree-phinodes.c:359 since
                   |r8-2993-ga7976089dba5e227   |r8-2993-ga7976089dba5e227
      Known to work|                            |11.0
           Priority|P3                          |P2

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.

[Bug tree-optimization/94964] [8/9/10 Regression] ICE in add_phi_arg, at tree-phinodes.c:359 since r8-2993-ga7976089dba5e227

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94964

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:fb2b8bf32b72a7976b2bdea1fa04c8af50786429

commit r10-8347-gfb2b8bf32b72a7976b2bdea1fa04c8af50786429
Author: Richard Biener <rguenther@suse.de>
Date:   Wed May 6 10:23:15 2020 +0200

    middle-end/94964 - avoid EH loop entry with CP_SIMPLE_PREHEADERS

    Loop optimizers expect to be able to insert on the preheader
    edge w/o splitting it thus avoid ending up with a preheader
    that enters the loop via an EH edge (or an abnormal edge).

    2020-05-06  Richard Biener  <rguenther@suse.de>

            PR middle-end/94964
            * cfgloopmanip.c (create_preheader): Require non-complex
            preheader edge for CP_SIMPLE_PREHEADERS.

[Bug tree-optimization/94964] [8/9 Regression] ICE in add_phi_arg, at tree-phinodes.c:359 since r8-2993-ga7976089dba5e227

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94964

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:95a8572ce7bdf152cc8c7d069ce24508a9ff0bfe

commit r9-8864-g95a8572ce7bdf152cc8c7d069ce24508a9ff0bfe
Author: Richard Biener <rguenther@suse.de>
Date:   Wed May 6 10:23:15 2020 +0200

    middle-end/94964 - avoid EH loop entry with CP_SIMPLE_PREHEADERS

    Loop optimizers expect to be able to insert on the preheader
    edge w/o splitting it thus avoid ending up with a preheader
    that enters the loop via an EH edge (or an abnormal edge).

    2020-05-06  Richard Biener  <rguenther@suse.de>

            PR middle-end/94964
            * cfgloopmanip.c (create_preheader): Require non-complex
            preheader edge for CP_SIMPLE_PREHEADERS.

    (cherry picked from commit 6fc00b41e764219e2c88d8892d7c701c0d292a17)

[Bug tree-optimization/94964] [8 Regression] ICE in add_phi_arg, at tree-phinodes.c:359 since r8-2993-ga7976089dba5e227

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94964

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:70ac96884811b6971b44a7ffa94d637f612e6cc4

commit r8-10660-g70ac96884811b6971b44a7ffa94d637f612e6cc4
Author: Richard Biener <rguenther@suse.de>
Date:   Wed May 6 10:23:15 2020 +0200

    middle-end/94964 - avoid EH loop entry with CP_SIMPLE_PREHEADERS

    Loop optimizers expect to be able to insert on the preheader
    edge w/o splitting it thus avoid ending up with a preheader
    that enters the loop via an EH edge (or an abnormal edge).

    2020-05-06  Richard Biener  <rguenther@suse.de>

            PR middle-end/94964
            * cfgloopmanip.c (create_preheader): Require non-complex
            preheader edge for CP_SIMPLE_PREHEADERS.

    (cherry picked from commit 6fc00b41e764219e2c88d8892d7c701c0d292a17)

[Bug tree-optimization/94964] [8 Regression] ICE in add_phi_arg, at tree-phinodes.c:359 since r8-2993-ga7976089dba5e227

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94964

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |8.4.0
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Known to work|                            |8.4.1

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.