[Bug fortran/95107] New: [10/11 Regression] ICE in hash_operand, at fold-const.c:3768

[Bug fortran/95107] New: [10/11 Regression] ICE in hash_operand, at fold-const.c:3768

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

            Bug ID: 95107
           Summary: [10/11 Regression] ICE in hash_operand, at
                    fold-const.c:3768
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20191110 and 20191117, with -fno-automatic at -O2+ :


$ cat z1.f90
program p
   type t
      real, pointer :: a => null()
   end type
   type t2
      type(t) :: b(1)
   end type
   type(t2) :: x
   associate (y => x%b)
   end associate
end


$ gfortran-9 -c z1.f90 -fno-automatic -O2
$
$ gfortran-11-20200510 -c z1.f90 -fno-automatic -O2
during IPA pass: icf
z1.f90:11:0:

   11 | end
      |
internal compiler error: in hash_operand, at fold-const.c:3768
0x8dfc2a operand_compare::hash_operand(tree_node const*, inchash::hash&,
unsigned int)
        ../../gcc/fold-const.c:3768
0x8e038c operand_compare::hash_operand(tree_node const*, inchash::hash&,
unsigned int)
        ../../gcc/fold-const.c:3858
0x8dffa2 operand_compare::hash_operand(tree_node const*, inchash::hash&,
unsigned int)
        ../../gcc/fold-const.c:3685
0x142c58f ipa_icf::sem_variable::init(ipa_icf_gimple::func_checker*)
        ../../gcc/ipa-icf.c:1909
0x14340ce ipa_icf::sem_variable::parse(varpool_node*, bitmap_obstack*,
ipa_icf_gimple::func_checker*)
        ../../gcc/ipa-icf.c:1889
0x143897d ipa_icf::sem_item_optimizer::parse_funcs_and_vars()
        ../../gcc/ipa-icf.c:2457
0xaf61ec execute_ipa_summary_passes(ipa_opt_pass_d*)
        ../../gcc/passes.c:2191
0x7fca29 ipa_passes
        ../../gcc/cgraphunit.c:2642
0x7fca29 symbol_table::compile()
        ../../gcc/cgraphunit.c:2752
0x7fe806 symbol_table::compile()
        ../../gcc/cgraphunit.c:3002
0x7fe806 symbol_table::finalize_compilation_unit()
        ../../gcc/cgraphunit.c:2999

[Bug fortran/95107] [10/11 Regression] ICE in hash_operand, at fold-const.c:3768

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
           Priority|P3                          |P2
   Target Milestone|---                         |10.2

[Bug fortran/95107] [10/11 Regression] ICE in hash_operand, at fold-const.c:3768

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-05-14
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
I see a Fortran FE ICE since at least 4.8.0:

$ gcc pr95107.f90 -O2 -c -fno-automatic
pr95107.f90:9:0:

    9 |    associate (y => x%b)
      | 
internal compiler error: tree check: expected array_type, have record_type in
gfc_conv_array_initializer, at fortran/trans-array.c:6057
0x765fb0 tree_check_failed(tree_node const*, char const*, int, char const*,
...)
        /home/marxin/Programming/gcc/gcc/tree.c:9686
0x607cf7 tree_check(tree_node*, char const*, int, char const*, tree_code)
        /home/marxin/Programming/gcc/gcc/tree.h:3296
0x607cf7 gfc_conv_array_initializer(tree_node*, gfc_expr*)
        /home/marxin/Programming/gcc/gcc/fortran/trans-array.c:6055
0x9798aa gfc_conv_initializer(gfc_expr*, gfc_typespec*, tree_node*, bool, bool,
bool)
        /home/marxin/Programming/gcc/gcc/fortran/trans-expr.c:7665
0x95fe19 gfc_get_symbol_decl(gfc_symbol*)
        /home/marxin/Programming/gcc/gcc/fortran/trans-decl.c:1895
0x962ba7 generate_local_decl
        /home/marxin/Programming/gcc/gcc/fortran/trans-decl.c:5906
0x91e282 do_traverse_symtree
        /home/marxin/Programming/gcc/gcc/fortran/symbol.c:4147
0x959274 generate_local_vars
        /home/marxin/Programming/gcc/gcc/fortran/trans-decl.c:6112
0x959274 gfc_process_block_locals(gfc_namespace*)
        /home/marxin/Programming/gcc/gcc/fortran/trans-decl.c:7123
0x9b9eca gfc_trans_block_construct(gfc_code*)
        /home/marxin/Programming/gcc/gcc/fortran/trans-stmt.c:2267
0x935d10 trans_code
        /home/marxin/Programming/gcc/gcc/fortran/trans.c:1960
0x963fcb gfc_generate_function_code(gfc_namespace*)
        /home/marxin/Programming/gcc/gcc/fortran/trans-decl.c:6835
0x8e750e translate_all_program_units
        /home/marxin/Programming/gcc/gcc/fortran/parse.c:6306
0x8e750e gfc_parse_file()
        /home/marxin/Programming/gcc/gcc/fortran/parse.c:6545
0x932faf gfc_be_parse_file
        /home/marxin/Programming/gcc/gcc/fortran/f95-lang.c:210
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[10/11 Regression] ICE in   |ICE in hash_operand, at
                   |hash_operand, at            |fold-const.c:3768
                   |fold-const.c:3768           |

--- Comment #2 from G. Steinmetz <gscfq@t-online.de> ---
> I see a Fortran FE ICE since at least 4.8.0:
Can confirm that with test versions too.

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.2                        |10.3

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10.2 is released, adjusting target milestone.

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egallager at gcc dot gnu.org

--- Comment #4 from Eric Gallager <egallager at gcc dot gnu.org> ---
I ran into an ICE at that same line in that same file, but it was when
compiling a C source file instead of a Fortran one... should I open a separate
bug?

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

--- Comment #5 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Eric Gallager from comment #4)
> I ran into an ICE at that same line in that same file, but it was when
> compiling a C source file instead of a Fortran one... should I open a
> separate bug?

actually never mind; the issue I was running into was actually bug 97125

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.3                        |10.4

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10.3 is being released, retargeting bugs to GCC 10.4.

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=92960

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This is related to PR 92960, maybe even a dup.

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

--- Comment #9 from anlauf at gcc dot gnu.org ---
The issue can be studied by playing with option -fmax-stack-var-size=n.
-fno-automatic corresponds to n=0; using n=64 and higher lets the code compile.
There's something weird going on here.

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
                 CC|                            |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #10 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2023-February/058891.html

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:c36f3da534e7f411c5bc48c5b6b660e238167480

commit r13-5732-gc36f3da534e7f411c5bc48c5b6b660e238167480
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Feb 6 20:59:51 2023 +0100

    Fortran: ASSOCIATE variables should not be TREE_STATIC [PR95107]

    gcc/fortran/ChangeLog:

            PR fortran/95107
            * trans-decl.cc (gfc_finish_var_decl): With -fno-automatic, do not
            make ASSOCIATE variables TREE_STATIC.

    gcc/testsuite/ChangeLog:

            PR fortran/95107
            * gfortran.dg/save_7.f90: New test.

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:6a5628b76380700198f64bf48f57081e6cfc39ed

commit r12-9116-g6a5628b76380700198f64bf48f57081e6cfc39ed
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Feb 6 20:59:51 2023 +0100

    Fortran: ASSOCIATE variables should not be TREE_STATIC [PR95107]

    gcc/fortran/ChangeLog:

            PR fortran/95107
            * trans-decl.cc (gfc_finish_var_decl): With -fno-automatic, do not
            make ASSOCIATE variables TREE_STATIC.

    gcc/testsuite/ChangeLog:

            PR fortran/95107
            * gfortran.dg/save_7.f90: New test.

    (cherry picked from commit c36f3da534e7f411c5bc48c5b6b660e238167480)

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:4eba6812c5652005e0e9dc62358a6fb3bda193e6

commit r11-10516-g4eba6812c5652005e0e9dc62358a6fb3bda193e6
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Feb 6 20:59:51 2023 +0100

    Fortran: ASSOCIATE variables should not be TREE_STATIC [PR95107]

    gcc/fortran/ChangeLog:

            PR fortran/95107
            * trans-decl.c (gfc_finish_var_decl): With -fno-automatic, do not
            make ASSOCIATE variables TREE_STATIC.

    gcc/testsuite/ChangeLog:

            PR fortran/95107
            * gfortran.dg/save_7.f90: New test.

    (cherry picked from commit c36f3da534e7f411c5bc48c5b6b660e238167480)

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:2db200ea8a63dd580b47002d9464afc7a7b5e90e

commit r10-11208-g2db200ea8a63dd580b47002d9464afc7a7b5e90e
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Feb 6 20:59:51 2023 +0100

    Fortran: ASSOCIATE variables should not be TREE_STATIC [PR95107]

    gcc/fortran/ChangeLog:

            PR fortran/95107
            * trans-decl.c (gfc_finish_var_decl): With -fno-automatic, do not
            make ASSOCIATE variables TREE_STATIC.

    gcc/testsuite/ChangeLog:

            PR fortran/95107
            * gfortran.dg/save_7.f90: New test.

    (cherry picked from commit c36f3da534e7f411c5bc48c5b6b660e238167480)

[Bug fortran/95107] ICE in hash_operand, at fold-const.c:3768

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95107

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #15 from anlauf at gcc dot gnu.org ---
Fixed on all open branches.  Closing.

Thanks for the report!