public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "tomas.kalibera at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/95130] GCC ignoring attribute(format(gnu_printf)) on printf in mingw Date: Wed, 26 Oct 2022 12:04:57 +0000 [thread overview] Message-ID: <bug-95130-4-Lm9ZM8mntL@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-95130-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95130 --- Comment #11 from Tomas Kalibera <tomas.kalibera at gmail dot com> --- (In reply to LIU Hao from comment #10) > (In reply to Tomas Kalibera from comment #7) > > I sent an updated version for the trunk, 12, 11 and 10 to the gcc-patches > > mailing list in May: > > > > https://gcc.gnu.org/pipermail/gcc-patches/2022-May/594960.html > > > > The patches still apply to current 10,11,12 and trunk. Please see the email > > linked above for more information. > > > Thanks for the patch. Updated locally. I will test it against trunk as soon > as I get a little time. Thanks. Re Jeff's comment from the mailing list: > I guess we're going to depend on the builtin-format always appearing > first in the chain? While it's probably true in practice, I doubt we > really want to depend on that. > > Is there any sensible way to distinguish between the builtin format and > one that comes from the source? I didn't find any elegant way to find out whether a format attribute is a built-in attribute in check_function_format(). So unless I overlooked something (which is very much possible), it would make the patch more intrusive. handle_format_attribute() has that information in flags (ATTR_FLAG_BUILT_IN). Maybe handle_format_attribute() could add the flags (or only a boolean whether it is a builtin attribute) to the attribute tree, so that check_function_format() can access it, e.g. similarly to how no_sanitize does it. Would this be better? And if so, is there a recommended place in the format attribute tree where it should be added to?
next prev parent reply other threads:[~2022-10-26 12:04 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-14 11:37 [Bug c/95130] New: " martin at martin dot st 2020-05-14 17:27 ` [Bug c/95130] " joseph at codesourcery dot com 2021-11-22 21:21 ` tomas.kalibera at gmail dot com 2021-12-15 17:27 ` tomas.kalibera at gmail dot com 2021-12-15 17:29 ` tomas.kalibera at gmail dot com 2021-12-15 17:45 ` tomas.kalibera at gmail dot com 2022-10-25 7:10 ` lh_mouse at 126 dot com 2022-10-25 16:46 ` tomas.kalibera at gmail dot com 2022-10-25 19:40 ` martin at martin dot st 2022-10-26 7:03 ` tomas.kalibera at gmail dot com 2022-10-26 10:09 ` lh_mouse at 126 dot com 2022-10-26 12:04 ` tomas.kalibera at gmail dot com [this message] 2022-10-26 15:27 ` tomas.kalibera at gmail dot com 2022-12-15 15:42 ` tomas.kalibera at gmail dot com 2023-01-29 18:20 ` alvinhochun at gmail dot com 2023-08-02 2:06 ` tanksherman27 at gmail dot com 2023-08-02 13:15 ` tomas.kalibera at gmail dot com 2023-08-03 16:33 ` tomas.kalibera at gmail dot com 2023-08-17 6:11 ` tanksherman27 at gmail dot com 2023-08-19 10:18 ` tanksherman27 at gmail dot com 2023-08-19 19:11 ` tomas.kalibera at gmail dot com 2023-08-20 2:22 ` cvs-commit at gcc dot gnu.org 2023-08-21 12:50 ` tomas.kalibera at gmail dot com 2024-04-19 2:53 ` pinskia at gcc dot gnu.org 2024-04-19 3:28 ` lh_mouse at 126 dot com 2024-04-19 7:04 ` martin at martin dot st 2024-04-19 7:12 ` lh_mouse at 126 dot com 2024-04-19 7:13 ` pinskia at gcc dot gnu.org 2024-04-19 7:27 ` lh_mouse at 126 dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-95130-4-Lm9ZM8mntL@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).