[Bug c/95133] New: [9/10/11 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[Bug c/95133] New: [9/10/11 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

            Bug ID: 95133
           Summary: [9/10/11 Regression] ICE in
                    gimple_redirect_edge_and_branch_force, at
                    tree-cfg.c:6075
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started with r8, needs option -O3 :


$ cat z1.c
extern int a[16];
void f (int *ip, int x)
{
  int *xp = a;
  for (int i=0; i<8; ++i)
  {
    base: if (x) return;
  }
  *xp++ = *ip;
  goto *(&&base + *ip);
}


$ gcc-11-20200510 -c z1.c -O2
$ gcc-11-20200510 -c z1.c -O3
during GIMPLE pass: split-paths
z1.c: In function 'f':
z1.c:2:6: internal compiler error: in gimple_redirect_edge_and_branch_force, at
tree-cfg.c:6075
    2 | void f (int *ip, int x)
      |      ^
0xd2de58 gimple_redirect_edge_and_branch_force
        ../../gcc/tree-cfg.c:6075
0x7d32a3 redirect_edge_and_branch_force(edge_def*, basic_block_def*)
        ../../gcc/cfghooks.c:490
0x7d509a duplicate_block(basic_block_def*, edge_def*, basic_block_def*,
copy_bb_data*)
        ../../gcc/cfghooks.c:1109
0xcddf05 transform_duplicate(basic_block_def*, basic_block_def*)
        ../../gcc/tracer.c:245
0x1697ae0 split_paths
        ../../gcc/gimple-ssa-split-paths.c:463
0x1697ae0 execute_split_paths
        ../../gcc/gimple-ssa-split-paths.c:503
0x1697ae0 execute
        ../../gcc/gimple-ssa-split-paths.c:540

[Bug c/95133] [9/10/11 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-05-14
                 CC|                            |jgreenhalgh at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Confirmed, started with r8-2217-g0919ce3efe2a0d6a.

[Bug c/95133] [9/10/11 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[jgreenhalgh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

--- Comment #2 from James Greenhalgh <jgreenhalgh at gcc dot gnu.org> ---
Should reproduce further back if you force it on with -ftree-vectorize .

i.e.

gcc foo.c -ftree-vectorize -O3

Breaks somewhere between:

gcc version 7.0.0 20160615
gcc version 7.0.0 20160907

[Bug tree-optimization/95133] [8/9/10/11 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10/11 Regression] ICE in |[8/9/10/11 Regression] ICE
                   |gimple_redirect_edge_and_br |in
                   |anch_force, at              |gimple_redirect_edge_and_br
                   |tree-cfg.c:6075             |anch_force, at
                   |                            |tree-cfg.c:6075
                 CC|                            |rguenth at gcc dot gnu.org

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to James Greenhalgh from comment #2)
> Should reproduce further back if you force it on with -ftree-vectorize .
> 
> i.e.
> 
> gcc foo.c -ftree-vectorize -O3
> 
> Breaks somewhere between:
> 
> gcc version 7.0.0 20160615
> gcc version 7.0.0 20160907

You are right James, it started with r7-1820-g1174b21b388ba06e.

[Bug tree-optimization/95133] [8/9/10/11 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Priority|P3                          |P2
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
   Target Milestone|---                         |8.5

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine then.

[Bug tree-optimization/95133] [8/9/10/11 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:aaf1ee48316f9b414b11c17e298198925d816595

commit r11-414-gaaf1ee48316f9b414b11c17e298198925d816595
Author: Richard Biener <rguenther@suse.de>
Date:   Fri May 15 09:38:54 2020 +0200

    tree-optimization/95133 - avoid abnormal edges in path splitting

    When path splitting tries to detect a CFG diamond make sure it
    is composed of normal (non-EH, not abnormal) edges.  Otherwise
    CFG manipulation later may fail.

    2020-05-15  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/95133
            * gimple-ssa-split-paths.c
            (find_block_to_duplicate_for_splitting_paths): Check for
            normal edges.

            * gcc.dg/pr95133.c: New testcase.

[Bug tree-optimization/95133] [8/9/10 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |11.0
            Summary|[8/9/10/11 Regression] ICE  |[8/9/10 Regression] ICE in
                   |in                          |gimple_redirect_edge_and_br
                   |gimple_redirect_edge_and_br |anch_force, at
                   |anch_force, at              |tree-cfg.c:6075
                   |tree-cfg.c:6075             |

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.

[Bug tree-optimization/95133] [8/9/10 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:1d93c1bdbb1fb59e56f115601c792fa539e8deb5

commit r10-8350-g1d93c1bdbb1fb59e56f115601c792fa539e8deb5
Author: Richard Biener <rguenther@suse.de>
Date:   Fri May 15 09:38:54 2020 +0200

    tree-optimization/95133 - avoid abnormal edges in path splitting

    When path splitting tries to detect a CFG diamond make sure it
    is composed of normal (non-EH, not abnormal) edges.  Otherwise
    CFG manipulation later may fail.

    2020-05-15  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/95133
            * gimple-ssa-split-paths.c
            (find_block_to_duplicate_for_splitting_paths): Check for
            normal edges.

            * gcc.dg/pr95133.c: New testcase.

[Bug tree-optimization/95133] [8/9 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:5024ea60b74ac61c00b2aee40878761f7cf58973

commit r9-8862-g5024ea60b74ac61c00b2aee40878761f7cf58973
Author: Richard Biener <rguenther@suse.de>
Date:   Fri May 15 09:38:54 2020 +0200

    tree-optimization/95133 - avoid abnormal edges in path splitting

    When path splitting tries to detect a CFG diamond make sure it
    is composed of normal (non-EH, not abnormal) edges.  Otherwise
    CFG manipulation later may fail.

    2020-05-15  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/95133
            * gimple-ssa-split-paths.c
            (find_block_to_duplicate_for_splitting_paths): Check for
            normal edges.

            * gcc.dg/pr95133.c: New testcase.

    (cherry picked from commit aaf1ee48316f9b414b11c17e298198925d816595)

[Bug tree-optimization/95133] [8 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:3d0da0bc398054f2c37f09b13ccf7e2e2ef63b22

commit r8-10659-g3d0da0bc398054f2c37f09b13ccf7e2e2ef63b22
Author: Richard Biener <rguenther@suse.de>
Date:   Fri May 15 09:38:54 2020 +0200

    tree-optimization/95133 - avoid abnormal edges in path splitting

    When path splitting tries to detect a CFG diamond make sure it
    is composed of normal (non-EH, not abnormal) edges.  Otherwise
    CFG manipulation later may fail.

    2020-05-15  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/95133
            * gimple-ssa-split-paths.c
            (find_block_to_duplicate_for_splitting_paths): Check for
            normal edges.

            * gcc.dg/pr95133.c: New testcase.

    (cherry picked from commit aaf1ee48316f9b414b11c17e298198925d816595)

[Bug tree-optimization/95133] [8 Regression] ICE in gimple_redirect_edge_and_branch_force, at tree-cfg.c:6075

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95133

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |8.4.1
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Known to fail|                            |8.4.0

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.