public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
@ 2020-05-21  7:33 daniel.f.starke at freenet dot de
  2020-05-21  7:36 ` [Bug target/95253] " daniel.f.starke at freenet dot de
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: daniel.f.starke at freenet dot de @ 2020-05-21  7:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

            Bug ID: 95253
           Summary: [10/11 Regression] Build failure on MSys. Wrong
                    dependency file escaping on Windows.
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: daniel.f.starke at freenet dot de
  Target Milestone: ---

Previously in gcc 9.3.0, escaping of the dependency file output still worked
well. Now I get a dependency check error from make when building mingw-w64 crt
due to wrong output escaping in gcc 10.1.0.
9.3.0 output:
 E:/msys/mingw64/include/windows.h
10.1.0 output:
 E\:/msys/mingw64/include/windows.h
Obviously, the column operator should not be escaped here.

Compiled gcc in both cases on MSys/MinGW (not MSys2) with:
Target: x86_64-w64-mingw32
Configured with: ../gcc-src/configure --enable-languages=c,c++
--enable-seh-exceptions --enable-threads=posix --disable-nls
--enable-shared=libstdc++ --enable-static --enable-fully-dynamic-string
--enable-lto --enable-plugins --enable-libgomp --with-dwarf2
--disable-win32-registry --enable-version-specific-runtime-libs
--prefix=/mingw64 --with-sysroot=/mingw64 --target=x86_64-w64-mingw32
--enable-targets=all --enable-checking=release
--with-gmp=/new-gcc/lib/gmp-6.1.2 --with-mpfr=/new-gcc/lib/mpfr-3.1.6
--with-mpc=/new-gcc/lib/mpc-1.1.0 --with-isl=/new-gcc/lib/isl-0.18
--with-host-libstdcxx='-lstdc++ -lsupc++'
Thread model: posix
Supported LTO compression algorithms: zlib

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug target/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
@ 2020-05-21  7:36 ` daniel.f.starke at freenet dot de
  2020-05-22  6:19 ` rguenth at gcc dot gnu.org
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: daniel.f.starke at freenet dot de @ 2020-05-21  7:36 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

--- Comment #1 from Daniel Starke <daniel.f.starke at freenet dot de> ---
Edit: I meant colon character, not column operator.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug target/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
  2020-05-21  7:36 ` [Bug target/95253] " daniel.f.starke at freenet dot de
@ 2020-05-22  6:19 ` rguenth at gcc dot gnu.org
  2020-05-24 20:12 ` daniel.f.starke at freenet dot de
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-05-22  6:19 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
            Version|unknown                     |10.1.0
   Target Milestone|---                         |10.2

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug target/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
  2020-05-21  7:36 ` [Bug target/95253] " daniel.f.starke at freenet dot de
  2020-05-22  6:19 ` rguenth at gcc dot gnu.org
@ 2020-05-24 20:12 ` daniel.f.starke at freenet dot de
  2020-05-27 20:10 ` [Bug preprocessor/95253] " daniel.f.starke at freenet dot de
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: daniel.f.starke at freenet dot de @ 2020-05-24 20:12 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

--- Comment #2 from Daniel Starke <daniel.f.starke at freenet dot de> ---
Minimal test case on MSys/MinGW:

echo '#include <stddef.h>' | gcc -MD -MF - -fsyntax-only -x c -

Result with gcc 9.3.0:
-:  \
 e:\msys\mingw64_9.3.0\lib\gcc\x86_64-w64-mingw32\9.3.0\include\stddef.h \
[...]

Result with gcc 10.1.0 (':' in path was quoted):
-: E\:/msys/mingw64/mingw/include/stddef.h \
[...]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (2 preceding siblings ...)
  2020-05-24 20:12 ` daniel.f.starke at freenet dot de
@ 2020-05-27 20:10 ` daniel.f.starke at freenet dot de
  2020-07-23  6:51 ` rguenth at gcc dot gnu.org
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: daniel.f.starke at freenet dot de @ 2020-05-27 20:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

Daniel Starke <daniel.f.starke at freenet dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|target                      |preprocessor

--- Comment #3 from Daniel Starke <daniel.f.starke at freenet dot de> ---
Introduced with r270943.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (3 preceding siblings ...)
  2020-05-27 20:10 ` [Bug preprocessor/95253] " daniel.f.starke at freenet dot de
@ 2020-07-23  6:51 ` rguenth at gcc dot gnu.org
  2021-01-14  8:50 ` rguenth at gcc dot gnu.org
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-07-23  6:51 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.2                        |10.3

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10.2 is released, adjusting target milestone.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (4 preceding siblings ...)
  2020-07-23  6:51 ` rguenth at gcc dot gnu.org
@ 2021-01-14  8:50 ` rguenth at gcc dot gnu.org
  2021-01-15 14:45 ` nathan at gcc dot gnu.org
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-01-14  8:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (5 preceding siblings ...)
  2021-01-14  8:50 ` rguenth at gcc dot gnu.org
@ 2021-01-15 14:45 ` nathan at gcc dot gnu.org
  2021-01-15 15:20 ` daniel.f.starke at freenet dot de
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: nathan at gcc dot gnu.org @ 2021-01-15 14:45 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

--- Comment #5 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
Created attachment 49975
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49975&action=edit
test patch

I think it's as simpleas the attached patch.  Are you able to try it?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (6 preceding siblings ...)
  2021-01-15 14:45 ` nathan at gcc dot gnu.org
@ 2021-01-15 15:20 ` daniel.f.starke at freenet dot de
  2021-01-15 16:56 ` cvs-commit at gcc dot gnu.org
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: daniel.f.starke at freenet dot de @ 2021-01-15 15:20 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

--- Comment #6 from Daniel Starke <daniel.f.starke at freenet dot de> ---
That is what I did as workaround for me, but I am not sure how this affacts
other targets.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (7 preceding siblings ...)
  2021-01-15 15:20 ` daniel.f.starke at freenet dot de
@ 2021-01-15 16:56 ` cvs-commit at gcc dot gnu.org
  2021-01-15 16:57 ` nathan at gcc dot gnu.org
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-01-15 16:56 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathan Sidwell <nathan@gcc.gnu.org>:

https://gcc.gnu.org/g:1ba71fabb78b18884e9f479f45a257bab50e8959

commit r11-6725-g1ba71fabb78b18884e9f479f45a257bab50e8959
Author: Nathan Sidwell <nathan@acm.org>
Date:   Fri Jan 15 06:47:13 2021 -0800

    preprocessor: Make quoting : [PR 95253]

    Make doesn't need ':' quoting (in a filename).

            PR preprocessor/95253
            libcpp/
            * mkdeps.c (munge): Do not escape ':'.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (8 preceding siblings ...)
  2021-01-15 16:56 ` cvs-commit at gcc dot gnu.org
@ 2021-01-15 16:57 ` nathan at gcc dot gnu.org
  2021-01-15 20:45 ` cvs-commit at gcc dot gnu.org
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: nathan at gcc dot gnu.org @ 2021-01-15 16:57 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

Nathan Sidwell <nathan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
1ba71fabb78 2021-01-15 | preprocessor: Make quoting : [PR 95253]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows.
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (9 preceding siblings ...)
  2021-01-15 16:57 ` nathan at gcc dot gnu.org
@ 2021-01-15 20:45 ` cvs-commit at gcc dot gnu.org
  2021-02-01 14:05 ` ebotcazou at gcc dot gnu.org
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-01-15 20:45 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathan Sidwell <nathan@gcc.gnu.org>:

https://gcc.gnu.org/g:e1efa6af61ab54faf0d8d091328e0c6a1141050c

commit r11-6740-ge1efa6af61ab54faf0d8d091328e0c6a1141050c
Author: Nathan Sidwell <nathan@acm.org>
Date:   Fri Jan 15 11:02:38 2021 -0800

    preprocessor: Make quoting : [PR 95253]

    I missed some testsuite fall out with my patch to fix mkdeps file
    mangling.

            PR preprocessor/95253
            gcc/testsuite/
            * g++.dg/modules/dep-1_a.C: Adjust expected output.
            * g++.dg/modules/dep-1_b.C: Likewise.
            * g++.dg/modules/dep-2.C: Likewise.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (10 preceding siblings ...)
  2021-01-15 20:45 ` cvs-commit at gcc dot gnu.org
@ 2021-02-01 14:05 ` ebotcazou at gcc dot gnu.org
  2021-02-03 15:14 ` cvs-commit at gcc dot gnu.org
  2021-02-03 15:32 ` ebotcazou at gcc dot gnu.org
  13 siblings, 0 replies; 15+ messages in thread
From: ebotcazou at gcc dot gnu.org @ 2021-02-01 14:05 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
            Summary|[10/11 Regression] Build    |[10/11 Regression] Build
                   |failure on MSys. Wrong      |failure on MSys. Wrong
                   |dependency file escaping on |dependency file escaping on
                   |Windows.                    |Windows
                 CC|                            |ebotcazou at gcc dot gnu.org
         Resolution|FIXED                       |---
   Last reconfirmed|                            |2021-02-01
             Status|RESOLVED                    |REOPENED

--- Comment #10 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
We need the fix on the 10 branch as well, this is really problematic.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (11 preceding siblings ...)
  2021-02-01 14:05 ` ebotcazou at gcc dot gnu.org
@ 2021-02-03 15:14 ` cvs-commit at gcc dot gnu.org
  2021-02-03 15:32 ` ebotcazou at gcc dot gnu.org
  13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-02-03 15:14 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Nathan Sidwell
<nathan@gcc.gnu.org>:

https://gcc.gnu.org/g:ab1aa8c0044aeff22dccae3170571a8ddeea5935

commit r10-9342-gab1aa8c0044aeff22dccae3170571a8ddeea5935
Author: Nathan Sidwell <nathan@acm.org>
Date:   Fri Jan 15 06:47:13 2021 -0800

    preprocessor: Make quoting : [PR 95253]

    Make doesn't need ':' quoting (in a filename).

            PR preprocessor/95253
            libcpp/
            * mkdeps.c (munge): Do not escape ':'.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug preprocessor/95253] [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows
  2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
                   ` (12 preceding siblings ...)
  2021-02-03 15:14 ` cvs-commit at gcc dot gnu.org
@ 2021-02-03 15:32 ` ebotcazou at gcc dot gnu.org
  13 siblings, 0 replies; 15+ messages in thread
From: ebotcazou at gcc dot gnu.org @ 2021-02-03 15:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95253

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #12 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Thanks a lot!

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2021-02-03 15:32 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21  7:33 [Bug target/95253] New: [10/11 Regression] Build failure on MSys. Wrong dependency file escaping on Windows daniel.f.starke at freenet dot de
2020-05-21  7:36 ` [Bug target/95253] " daniel.f.starke at freenet dot de
2020-05-22  6:19 ` rguenth at gcc dot gnu.org
2020-05-24 20:12 ` daniel.f.starke at freenet dot de
2020-05-27 20:10 ` [Bug preprocessor/95253] " daniel.f.starke at freenet dot de
2020-07-23  6:51 ` rguenth at gcc dot gnu.org
2021-01-14  8:50 ` rguenth at gcc dot gnu.org
2021-01-15 14:45 ` nathan at gcc dot gnu.org
2021-01-15 15:20 ` daniel.f.starke at freenet dot de
2021-01-15 16:56 ` cvs-commit at gcc dot gnu.org
2021-01-15 16:57 ` nathan at gcc dot gnu.org
2021-01-15 20:45 ` cvs-commit at gcc dot gnu.org
2021-02-01 14:05 ` ebotcazou at gcc dot gnu.org
2021-02-03 15:14 ` cvs-commit at gcc dot gnu.org
2021-02-03 15:32 ` ebotcazou at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).