[Bug jit/95325] New: Support 128-bit integers

[Bug jit/95325] New: Support 128-bit integers

[bouanto at zoho dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95325

            Bug ID: 95325
           Summary: Support 128-bit integers
           Product: gcc
           Version: 10.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: jit
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: bouanto at zoho dot com
  Target Milestone: ---

Hi.
Would it be possible to add support for 128-bit integers in libgccjit?
Thanks.

[Bug jit/95325] Support 128-bit integers

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95325

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

[Bug jit/95325] Support 128-bit integers

[bouanto at zoho dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95325

--- Comment #1 from Antoni <bouanto at zoho dot com> ---
Created attachment 50835
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50835&action=edit
Patch add support for sized integer types

That patch not only add support for 128-bit integers, but also all other sized
integers.

[Bug jit/95325] Support 128-bit integers

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95325

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-11-20
             Status|UNCONFIRMED                 |WAITING
     Ever confirmed|0                           |1

--- Comment #2 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks for working on this; sorry for the delay in reviewing your various
patches.

I think that the current status of this is that I found some issues when
reviewing it; see:
  https://gcc.gnu.org/pipermail/jit/2021q2/001303.html
Is there an updated version after that that I've missed?

[Bug jit/95325] Support 128-bit integers

[bouanto at zoho dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95325

--- Comment #3 from Antoni <bouanto at zoho dot com> ---
No.
The only patch that is ready for review is "libgccjit: add some reflection
functions in the jit C api".

[Bug jit/95325] Support 128-bit integers

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95325

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:af80ea97b61847d91da0d303e85faed437059092

commit r12-8116-gaf80ea97b61847d91da0d303e85faed437059092
Author: Antoni Boucher <bouanto@zoho.com>
Date:   Tue Apr 12 17:16:45 2022 -0400

    libgccjit: Add support for sized integer types, including 128-bit integers
[PR95325]

    gcc/jit/
            PR target/95325
            * docs/_build/texinfo/libgccjit.texi: Regenerate
            * docs/topics/compatibility.rst (LIBGCCJIT_ABI_20): New ABI tag.
            * docs/topics/types.rst: Add documentation for the new types
            GCC_JIT_TYPE_UINT8_T, GCC_JIT_TYPE_UINT16_T,
            GCC_JIT_TYPE_UINT32_T, GCC_JIT_TYPE_UINT64_T,
            GCC_JIT_TYPE_UINT128_T, GCC_JIT_TYPE_INT8_T, GCC_JIT_TYPE_INT16_T,
            GCC_JIT_TYPE_INT32_T, GCC_JIT_TYPE_INT64_T, GCC_JIT_TYPE_INT128_T
and
            new functions (gcc_jit_compatible_types, gcc_jit_type_get_size).
            * jit-builtins.cc: Add support for BT_UINT128.
            * jit-common.h: Update the value of NUM_GCC_JIT_TYPES.
            * jit-playback.cc: Add support for the sized integer types.
            * jit-recording.cc: Add support for the sized integer types.
            * jit-recording.h: Add support for comparing integer types
            and new function (is_signed).
            * libgccjit.cc (gcc_jit_compatible_types): New.
            (gcc_jit_type_get_size) New.
            * libgccjit.h: New enum variants for gcc_jit_types
            (GCC_JIT_TYPE_UINT8_T, GCC_JIT_TYPE_UINT16_T,
            GCC_JIT_TYPE_UINT32_T, GCC_JIT_TYPE_UINT64_T,
            GCC_JIT_TYPE_UINT128_T, GCC_JIT_TYPE_INT8_T,
            GCC_JIT_TYPE_INT16_T, GCC_JIT_TYPE_INT32_T,
            GCC_JIT_TYPE_INT64_T, GCC_JIT_TYPE_INT128_T) and new functions
            (gcc_jit_compatible_types, gcc_jit_type_get_size).
            * libgccjit.map (LIBGCCJIT_ABI_20): New ABI tag.

    gcc/testsuite/
            PR target/95325
            * jit.dg/test-types.c: Add tests for sized integer types.

[Bug jit/95325] Support 128-bit integers

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95325

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|WAITING                     |RESOLVED

--- Comment #5 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Marking as resolved; please reopen if there's an issue integrating the version
of the patch I committed with rustc_codegen_gcc.