[Bug target/95347] New: rs6000 mcpu=future generating stfs instead of pstfs for pc-relative references

[Bug target/95347] New: rs6000 mcpu=future generating stfs instead of pstfs for pc-relative references

[acsawdey at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95347

            Bug ID: 95347
           Summary: rs6000 mcpu=future generating stfs instead of pstfs
                    for pc-relative references
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: acsawdey at gcc dot gnu.org
  Target Milestone: ---

Problem exists in r11-639.

/home2/sawdey/work/gcc/mamboCI/build-mambo/gcc/xgcc
-B/home2/sawdey/work/gcc/mamboCI/build-mambo/gcc/
/home2/sawdey/work/gcc/mamboCI/gcc-master/gcc/testsuite/gcc.c-torture/execute/pr79354.c
-mcpu=future -mpcrel -fno-diagnostics-show-caret
-fno-diagnostics-show-line-numbers -fdiagnostics-color=never
-fdiagnostics-urls=never -O1 -w -lm -o ./pr79354.exe --save-temps

./pr79354.s: Assembler messages:
./pr79354.s:31: Error: missing operand

The relevant piece of the asm output:

        xscvuxdsp 0,32
        pstfs 0,.LANCHOR0+16@pcrel
        stfs 0,.LANCHOR0+20@pcrel
        lwa 10,0(3)
        pstw 10,.LANCHOR0+20@pcrel

The extended mnemonic "pstfs Fx,value" is equivalent to "pstfs Fx,value(0),1"
and is only valid for pstfs not stfs.

[Bug target/95347] rs6000 mcpu=future generating stfs instead of pstfs for pc-relative references

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95347

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aaron Sawdey <acsawdey@gcc.gnu.org>:

https://gcc.gnu.org/g:85bce484d37fdda9c7eadb9bdcdb1ded891462bb

commit r11-830-g85bce484d37fdda9c7eadb9bdcdb1ded891462bb
Author: Aaron Sawdey <acsawdey@linux.ibm.com>
Date:   Fri May 29 16:19:10 2020 -0500

    Correctly identify stfs if prefixed

    Because reg_to_non_prefixed() only looks at the register being used, it
    doesn't get the right answer for stfs, which leads to us not seeing
    that it has a PCREL symbol ref.  This patch works around this by
    introducing a helper function that inspects the insn to see if it is in
    fact a stfs. Then if we use NON_PREFIXED_DEFAULT, address_to_insn_form()
    can see that it has the PCREL symbol ref.

    gcc/ChangeLog:

            PR target/95347
            * config/rs6000/rs6000.c (prefixed_store_p): Add special case
            for stfs.
            (is_stfs_insn): New helper function.

[Bug target/95347] rs6000 mcpu=future generating stfs instead of pstfs for pc-relative references

[acsawdey at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95347

acsawdey at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-06-02
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #2 from acsawdey at gcc dot gnu.org ---
Turns out that lfs/plfs has the same problem. Patch for that coming shortly.

[Bug target/95347] rs6000 mcpu=future generating stfs instead of pstfs for pc-relative references

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95347

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aaron Sawdey <acsawdey@gcc.gnu.org>:

https://gcc.gnu.org/g:c0d738a0f493a85f46d7618efe20a89bf7f7ead8

commit r11-886-gc0d738a0f493a85f46d7618efe20a89bf7f7ead8
Author: Aaron Sawdey <acsawdey@linux.ibm.com>
Date:   Tue Jun 2 15:48:01 2020 -0500

    identify lfs prefixed case PR95347

    The same problem also arises for plfs where prefixed_load_p()
    doesn't recognize it so we get just lfs in the asm output
    with an @pcrel address.

            PR target/95347
            * config/rs6000/rs6000.c (is_stfs_insn): Rename to
            is_lfs_stfs_insn and make it recognize lfs as well.
            (prefixed_store_p): Use is_lfs_stfs_insn().
            (prefixed_load_p): Use is_lfs_stfs_insn() to recognize lfs.

[Bug target/95347] rs6000 mcpu=future generating stfs instead of pstfs for pc-relative references

[acsawdey at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95347

acsawdey at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from acsawdey at gcc dot gnu.org ---
This is fixed now.

[Bug target/95347] rs6000 mcpu=future generating stfs instead of pstfs for pc-relative references

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95347

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Aaron Sawdey
<acsawdey@gcc.gnu.org>:

https://gcc.gnu.org/g:541e8c4dac11fce933a7f9fa7d865abf8d6496f7

commit r10-8324-g541e8c4dac11fce933a7f9fa7d865abf8d6496f7
Author: Aaron Sawdey <acsawdey@linux.ibm.com>
Date:   Wed Jun 17 15:32:53 2020 -0500

    Correctly identify stfs if prefixed

    Because reg_to_non_prefixed() only looks at the register being used, it
    doesn't get the right answer for stfs, which leads to us not seeing
    that it has a PCREL symbol ref.  This patch works around this by
    introducing a helper function that inspects the insn to see if it is in
    fact a stfs. Then if we use NON_PREFIXED_DEFAULT, address_to_insn_form()
    can see that it has the PCREL symbol ref.

            Backport from master
            2020-06-02  Aaron Sawdey  <acsawdey@linux.ibm.com>

            PR target/95347
            * config/rs6000/rs6000.c (prefixed_store_p): Add special case
            for stfs.
            (is_stfs_insn): New helper function.

[Bug target/95347] rs6000 mcpu=future generating stfs instead of pstfs for pc-relative references

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95347

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Aaron Sawdey
<acsawdey@gcc.gnu.org>:

https://gcc.gnu.org/g:6e81b0cf4ff75f65edfd2d83bfa2933f35ae66af

commit r10-8325-g6e81b0cf4ff75f65edfd2d83bfa2933f35ae66af
Author: Aaron Sawdey <acsawdey@linux.ibm.com>
Date:   Wed Jun 17 15:35:55 2020 -0500

    identify lfs prefixed case PR95347

    The same problem also arises for plfs where prefixed_load_p()
    doesn't recognize it so we get just lfs in the asm output
    with an @pcrel address.

            Backport from master
            2020-06-03  Aaron Sawdey  <acsawdey@linux.ibm.com>

            PR target/95347
            * config/rs6000/rs6000.c (is_stfs_insn): Rename to
            is_lfs_stfs_insn and make it recognize lfs as well.
            (prefixed_store_p): Use is_lfs_stfs_insn().
            (prefixed_load_p): Use is_lfs_stfs_insn() to recognize lfs.