[Bug go/95389] New: Kubernetes build fails because of mangled PkgPath

[Bug go/95389] New: Kubernetes build fails because of mangled PkgPath

[ulrich.teichert at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95389

            Bug ID: 95389
           Summary: Kubernetes build fails because of mangled PkgPath
           Product: gcc
           Version: 10.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: ulrich.teichert at gmx dot de
                CC: cmang at google dot com
  Target Milestone: ---

Hi,

while trying to build Kubernetes on sparc64 (yes, this is a currently
unsupported platform as far as Kubernetes is concerned), I stumbled over a
PkgPath issue. Kubernetes uses (among a multitude of others) a packages path
as:

vendor/k8s.io/code-generator/pkg/util

>From the path specifications of golang, I think that k8s.io is a legal package
part, as long as the dot is not used as first character in a path component.

gccgo is turning this into the PgkPath:

vendor/k8s.x2eio/code-generator/pkg/util

Which seems to be a result of a path mangling by the go frontend method
go_mangle_pkgpath in gcc/go/gofrontend/go-encode-id.cc, which encodes the dot
to the string ".x2e". This would be perfectly OK, if the PkgPath in golang
would be used unmangled, but the dot encoding slips through.

I admit that I didn't find the point where the dot unmangling should be
inserted, sorry.

[Bug go/95389] Kubernetes build fails because of mangled PkgPath

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95389

--- Comment #1 from Ian Lance Taylor <ian at airs dot com> ---
To be clear, are you seeing this in the value returned by
reflect.Type.PkgPath()?  Or is it showing up somewhere else?  Thanks.

[Bug go/95389] Kubernetes build fails because of mangled PkgPath

[ulrich.teichert at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95389

--- Comment #2 from Ulrich Teichert <ulrich.teichert at gmx dot de> ---
Yes, the string "vendor/k8s.x2eio/code-generator/pkg/util" is the content of
the PkgPath() from "vendor/k8s.io/code-generator/pkg/util".

[Bug go/95389] Kubernetes build fails because of mangled PkgPath

[ulrich.teichert at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95389

--- Comment #3 from Ulrich Teichert <ulrich.teichert at gmx dot de> ---
BTW, I can reproduce the same strange reflect.Type.PkgPath issue on AMD64/Linux
with gccgo 10.1.0

[Bug go/95389] Kubernetes build fails because of mangled PkgPath

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95389

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
            Version|10.1.0                      |11.0

--- Comment #4 from Ian Lance Taylor <ian at airs dot com> ---
This should be fixed in GCC 11 as part of the fix for
https://golang.org/issue/41862.

[Bug go/95389] Kubernetes build fails because of mangled PkgPath

[ulrich.teichert at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95389

--- Comment #5 from Ulrich Teichert <ulrich.teichert at gmx dot de> ---
Thanks for the head-up, I'll give it a spin and report back. But building gcc
on my box takes a while, so please don't hold your breath ;-)

[Bug go/95389] Kubernetes build fails because of mangled PkgPath

[ulrich.teichert at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95389

--- Comment #6 from Ulrich Teichert <ulrich.teichert at gmx dot de> ---
After running out of disk space during stage2 of the gcc build, I now have a
gcc 11.2.0 compiled for sparc64:

ristkon:~> gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/sparc64-unknown-linux-gnu/11.2.0/lto-wrapper
Target: sparc64-unknown-linux-gnu
Configured with: ../gcc-11.2.0/configure --enable-languages=c,c++,go,d
--disable-multilib
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 11.2.0 (GCC) 

So far, so good. But the kubernetes build fails with a seg fault now. Will open
another bug for that, but so far I can't verify that this here bug is fixed.

[Bug go/95389] Kubernetes build fails because of mangled PkgPath

[ulrich.teichert at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95389

--- Comment #7 from Ulrich Teichert <ulrich.teichert at gmx dot de> ---
Hi, after building under x86_64 I can confirm that the PkgPath issue is fixed.