[Bug testsuite/95416] New: Several gcc.misc-tests/outputs.exp tests FAIL

[Bug testsuite/95416] New: Several gcc.misc-tests/outputs.exp tests FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95416

            Bug ID: 95416
           Summary: Several gcc.misc-tests/outputs.exp tests FAIL
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: aoliva at gcc dot gnu.org
  Target Milestone: ---
            Target: *-*-solaris2.11

Several of the gcc.misc-tests/outputs.exp tests FAIL on Solaris (both SPARC and
x86, 32 and 64-bit):

+FAIL: outputs doc double !-c  -o -db'' -flto: extra
+FAIL: outputs lto dbsovrdd mult named: extra
+FAIL: outputs lto dbsovrdd mult namedb: extra
+FAIL: outputs lto dbsovrdd mult unnamed: extra
+FAIL: outputs lto dbsovrdd sing named: extra
+FAIL: outputs lto dbsovrdd sing namedb: extra
+FAIL: outputs lto dbsovrdd sing unnamed: extra
+FAIL: outputs lto dbswthdd mult named: extra
+FAIL: outputs lto dbswthdd mult namedb: extra
+FAIL: outputs lto dbswthdd mult unnamed: extra
+FAIL: outputs lto dbswthdd sing named: extra
+FAIL: outputs lto dbswthdd sing namedb: extra
+FAIL: outputs lto dbswthdd sing unnamed: extra
+FAIL: outputs lto mult dumpbase named: extra
+FAIL: outputs lto mult dumpbase namedb: extra
+FAIL: outputs lto mult dumpbase unnamed: extra
+FAIL: outputs lto mult dumpdir named: extra
+FAIL: outputs lto mult dumpdir namedb: extra
+FAIL: outputs lto mult dumpdir unnamed: extra
+FAIL: outputs lto mult empty dumpbase dumpdir named: extra
+FAIL: outputs lto mult empty dumpbase dumpdir unnamed: extra
+FAIL: outputs lto mult empty dumpbase named: extra
+FAIL: outputs lto mult empty dumpbase namedb: extra
+FAIL: outputs lto mult empty dumpbase unnamed: extra
+FAIL: outputs lto mult empty dumpdir empty dumpbase named: extra
+FAIL: outputs lto mult empty dumpdir empty dumpbase namedb: extra
+FAIL: outputs lto mult empty dumpdir empty dumpbase unnamed: extra
+FAIL: outputs lto mult named: extra
+FAIL: outputs lto mult nameddir: extra
+FAIL: outputs lto mult unnamed: extra
+FAIL: outputs lto sing dumpbase named: extra
+FAIL: outputs lto sing dumpbase namedb: extra
+FAIL: outputs lto sing dumpbase unnamed: extra
+FAIL: outputs lto sing dumpdir named: extra
+FAIL: outputs lto sing dumpdir namedb: extra
+FAIL: outputs lto sing dumpdir unnamed: extra
+FAIL: outputs lto sing empty dumpbase dumpdir named: extra
+FAIL: outputs lto sing empty dumpbase dumpdir namedb: extra
+FAIL: outputs lto sing empty dumpbase dumpdir unnamed: extra
+FAIL: outputs lto sing empty dumpbase named: extra
+FAIL: outputs lto sing empty dumpbase namedb: extra
+FAIL: outputs lto sing empty dumpbase unnamed: extra
+FAIL: outputs lto sing named: extra
+FAIL: outputs lto sing nameddir: extra
+FAIL: outputs lto sing unnamed: extra
+FAIL: outputs lto st mult dumpdir empty dumpbase named:
dir/outputs-1.lto_wrapper_args
+FAIL: outputs lto st mult dumpdir empty dumpbase named: dir/outputs-1.res
+FAIL: outputs lto st mult dumpdir empty dumpbase named: extra
+FAIL: outputs lto st mult dumpdir named: dir/outputs-lto_wrapper_args
+FAIL: outputs lto st mult dumpdir named: dir/outputs-res
+FAIL: outputs lto st mult dumpdir named: extra
+FAIL: outputs lto st mult empty dumpbase namedb: dir/outputs.lto_wrapper_args
+FAIL: outputs lto st mult empty dumpbase namedb: dir/outputs.res
+FAIL: outputs lto st mult empty dumpbase namedb: extra
+FAIL: outputs lto st mult empty dumpbase unnamed: a.lto_wrapper_args
+FAIL: outputs lto st mult empty dumpbase unnamed: a.res
+FAIL: outputs lto st mult empty dumpbase unnamed: extra
+FAIL: outputs lto st mult namedb: dir/outputs.lto_wrapper_args
+FAIL: outputs lto st mult namedb: dir/outputs.res
+FAIL: outputs lto st mult namedb: extra
+FAIL: outputs lto st mult unnamed: a.lto_wrapper_args
+FAIL: outputs lto st mult unnamed: a.res
+FAIL: outputs lto st mult unnamed: extra
+FAIL: outputs lto st sing dumpdir empty dumpbase named:
dir/outputs-0.lto_wrapper_args
+FAIL: outputs lto st sing dumpdir empty dumpbase named: dir/outputs-0.res
+FAIL: outputs lto st sing dumpdir empty dumpbase named: extra
+FAIL: outputs lto st sing dumpdir named: dir/outputs-lto_wrapper_args
+FAIL: outputs lto st sing dumpdir named: dir/outputs-res
+FAIL: outputs lto st sing dumpdir named: extra
+FAIL: outputs lto st sing empty dumpbase namedb: dir/outputs.lto_wrapper_args
+FAIL: outputs lto st sing empty dumpbase namedb: dir/outputs.res
+FAIL: outputs lto st sing empty dumpbase namedb: extra
+FAIL: outputs lto st sing empty dumpbase unnamed: a.lto_wrapper_args
+FAIL: outputs lto st sing empty dumpbase unnamed: a.res
+FAIL: outputs lto st sing empty dumpbase unnamed: extra
+FAIL: outputs lto st sing namedb: dir/outputs.lto_wrapper_args
+FAIL: outputs lto st sing namedb: dir/outputs.res
+FAIL: outputs lto st sing namedb: extra
+FAIL: outputs lto st sing unnamed: a.lto_wrapper_args
+FAIL: outputs lto st sing unnamed: a.res
+FAIL: outputs lto st sing unnamed: extra

Many (all?) of the "extra" failures follow a similar pattern, e.g.

FAIL: outputs lto sing unnamed: extra
a-outputs-0.c.320r.final

I suspected this depends on whether or not the lto-plugin is supported (the
Solaris ld was in use for those builds), and indeed I get the same file
when on Linux/x86_64 I try that test with -fno-use-linker-plugin.

I haven't yet investiated the rest.

[Bug testsuite/95416] Several gcc.misc-tests/outputs.exp tests FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95416

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug testsuite/95416] Several gcc.misc-tests/outputs.exp tests FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95416

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> ---
I've since run Solaris bootstraps with gld: all the failures are gone.
Conversely, in a Linux/i686 bootstrap with gld and --disable-lto-plugin, they
do occur just as on Solaris with the native ld.

[Bug testsuite/95416] Several gcc.misc-tests/outputs.exp tests FAIL

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95416

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-06-08
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |aoliva at gcc dot gnu.org

--- Comment #2 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Created attachment 48706
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48706&action=edit
patch that works around the problem

Does this help?

[Bug testsuite/95416] Several gcc.misc-tests/outputs.exp tests FAIL

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95416

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2020-June/54
                   |                            |8730.html

--- Comment #3 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Patch with a fix proper at
https://gcc.gnu.org/pipermail/gcc-patches/2020-June/548730.html

[Bug testsuite/95416] Several gcc.misc-tests/outputs.exp tests FAIL

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95416

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alexandre Oliva <aoliva@gcc.gnu.org>:

https://gcc.gnu.org/g:ef6506e23691a72e1e724977e8ee8b9f3db74015

commit r11-1642-gef6506e23691a72e1e724977e8ee8b9f3db74015
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Wed Jun 24 17:20:49 2020 -0300

    outputs.exp: conditionals for split-dwarf and lto plugin

    This patch introduces support for conditionals (and expr) expansions
    to file lists in proc outest in outputs.exp.

    The conditionals machinery is now used to guard files that are only
    created by the LTO plugin, or when not using the LTO plugin.

    It is also used to avoid special-casing .dwo files: the condition of
    when they're expected is now encoded in the list.

    Furthermore, the -g flag, that used to be specified along with
    $gsplit_dwarf, is now moved into $gsplit_dwarf, so that we don't
    compile with -g if -gsplit-dwarf is not needed.  This avoids having to
    deal with .dSYM directories.

    Further removing special cases, $aout is now dealt with in a more
    general way, using expr to perform variable/string expansion.


    for  gcc/testsuite/ChangeLog

            PR testsuite/95416
            PR testsuite/95577
            * gcc.misc-tests/outputs.exp (gsplit_dwarf): Move -g into it.
            (outest): Introduce conditionals and string/variable/expr
            expansion.  Drop special-casing of $aout and .dwo.
            (gspd): New conditional.  Guard all .dwo files with it.
            (ltop): New conditional.  Guard files created by the LTO
            plugin with it.  Guard files created by fat LTO compilation
            with its negation.  Add a few -fno-use-linker-plugin tests
            guarded by it.

[Bug testsuite/95416] Several gcc.misc-tests/outputs.exp tests FAIL

[aoliva at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95416

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Alexandre Oliva <aoliva at gcc dot gnu.org> ---
Fixed