public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/95615] [coroutines] Coroutine frame and promise is leaked if exception thrown from promise.initial_suspend() Date: Mon, 15 Feb 2021 14:00:07 +0000 [thread overview] Message-ID: <bug-95615-4-Mx8DNprASj@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-95615-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95615 --- Comment #3 from Iain Sandoe <iains at gcc dot gnu.org> --- Actually, I don't think the example goes far enough. ISTM, [on exception in the places noted] that non-trivial DTORs for frame copies of parms should be run after the GRO and promise DTOR but before the frame is freed. Do you agree? (if so I have a patch for this now) So, I think the modified example below should print: Y () Y (const Y&) operator new() Y (const Y&) promise_type() get_return_object() task() ~task() ~promise_type() ~Y () operator delete ~Y () caught X ~Y () ======= but *both* [master] GCC and clang print: Y () Y (const Y&) operator new() Y (const Y&) promise_type() task() ~Y () ~task() ~Y () ======= #if __has_include(<coroutine>) #include <coroutine> #else #include <experimental/coroutine> namespace std { using namespace std::experimental; } #endif #include <cstdio> struct X {}; int Y_live = 0; struct Y { Y () { std::puts("Y ()"); Y_live++; } Y (const Y&) { std::puts("Y (const Y&)"); Y_live++; } ~Y () { std::puts("~Y ()"); Y_live--; } }; struct task { struct promise_type { void* operator new(size_t sz) { std::puts("operator new()"); return ::operator new(sz); } void operator delete(void* p, size_t sz) { std::puts("operator delete"); return ::operator delete(p, sz); } promise_type() { std::puts("promise_type()"); // throw X{}; } ~promise_type() { std::puts("~promise_type()"); } struct awaiter { bool await_ready() { //throw X{}; return false; } void await_suspend(std::coroutine_handle<>) { //throw X{}; } void await_resume() { //throw X{}; } }; awaiter initial_suspend() { // throw X{}; return {}; } task get_return_object() { // throw X{}; return task{}; } std::suspend_never final_suspend() noexcept { return {}; } void return_void() noexcept {} void unhandled_exception() noexcept { std::puts("unhandled_exception()"); } }; task() { std::puts("task()"); } ~task() { std::puts("~task()"); } task(task&&) { std::puts("task(task&&)"); } }; task f(Y Val) { co_return; } int main() { Y Val; try { auto a = f(Val); } catch (X) { std::puts("caught X"); } } ====
next prev parent reply other threads:[~2021-02-15 14:00 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-09 18:35 [Bug c++/95615] New: " lewissbaker.opensource at gmail dot com 2020-06-09 18:56 ` [Bug c++/95615] " iains at gcc dot gnu.org 2020-07-23 6:52 ` rguenth at gcc dot gnu.org 2021-02-15 14:00 ` iains at gcc dot gnu.org [this message] 2021-02-16 8:50 ` iains at gcc dot gnu.org 2021-03-05 16:59 ` cvs-commit at gcc dot gnu.org 2021-03-22 22:04 ` cvs-commit at gcc dot gnu.org 2021-03-24 12:37 ` iains at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-95615-4-Mx8DNprASj@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).