public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/95615] [coroutines] Coroutine frame and promise is leaked if exception thrown from promise.initial_suspend() Date: Fri, 05 Mar 2021 16:59:19 +0000 [thread overview] Message-ID: <bug-95615-4-zNDmKcGiRW@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-95615-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95615 --- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>: https://gcc.gnu.org/g:fe55086547c9360b530e040a6673dae10ac77847 commit r11-7527-gfe55086547c9360b530e040a6673dae10ac77847 Author: Iain Sandoe <iain@sandoe.co.uk> Date: Mon Feb 15 15:09:27 2021 +0000 coroutines : Handle exceptions throw before the first await_resume() [PR95615]. The coroutine body is wrapped in a try-catch block which is responsible for handling any exceptions thrown by the original function body. Originally, the initial suspend expression was outside this, but an amendement to the standard places the await_resume call inside and eveything else outside. This means that any exception thrown prior to the initial suspend expression await_resume() will propagate to the ramp function. However, some portion of the coroutine state will exist at that point (how much depends on where the exception is thrown from). For example, we might have some frame parameter copies, or the promise object or the return object any of which might have a non-trivial DTOR. Also the frame itself needs to be deallocated. This patch fixes the handling of these cases. gcc/cp/ChangeLog: PR c++/95615 * coroutines.cc (struct param_info): Track parameter copies that need a DTOR. (coro_get_frame_dtor): New helper function factored from build_actor(). (build_actor_fn): Use coro_get_frame_dtor(). (morph_fn_to_coro): Track parameters that need DTORs on exception, likewise the frame promise and the return object. On exception, run the DTORs for these, destroy the frame and then rethrow the exception. gcc/testsuite/ChangeLog: PR c++/95615 * g++.dg/coroutines/torture/pr95615-01.C: New test. * g++.dg/coroutines/torture/pr95615-02.C: New test. * g++.dg/coroutines/torture/pr95615-03.C: New test. * g++.dg/coroutines/torture/pr95615-04.C: New test. * g++.dg/coroutines/torture/pr95615-05.C: New test.
next prev parent reply other threads:[~2021-03-05 16:59 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-09 18:35 [Bug c++/95615] New: " lewissbaker.opensource at gmail dot com 2020-06-09 18:56 ` [Bug c++/95615] " iains at gcc dot gnu.org 2020-07-23 6:52 ` rguenth at gcc dot gnu.org 2021-02-15 14:00 ` iains at gcc dot gnu.org 2021-02-16 8:50 ` iains at gcc dot gnu.org 2021-03-05 16:59 ` cvs-commit at gcc dot gnu.org [this message] 2021-03-22 22:04 ` cvs-commit at gcc dot gnu.org 2021-03-24 12:37 ` iains at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-95615-4-zNDmKcGiRW@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).