[Bug fortran/95689] New: ICE in check_sym_interfaces, at fortran/interface.c:2015

[Bug fortran/95689] New: ICE in check_sym_interfaces, at fortran/interface.c:2015

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

            Bug ID: 95689
           Summary: ICE in check_sym_interfaces, at
                    fortran/interface.c:2015
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Happens between name length 37 (ok) and 38 (ICE) :


$ cat z1_37.f90
module m234567890123456789012345678901234567
   type t234567890123456789012345678901234567
   end type
   interface
      module subroutine s234567890123456789012345678901234567 &
        (x234567890123456789012345678901234567)
      end
   end interface
end
submodule(m234567890123456789012345678901234567) &
   t234567890123456789012345678901234567
end


$ cat z1_38.f90
module m2345678901234567890123456789012345678
   type t2345678901234567890123456789012345678
   end type
   interface
      module subroutine s2345678901234567890123456789012345678 &
        (x2345678901234567890123456789012345678)
      end
   end interface
end
submodule(m2345678901234567890123456789012345678) &
   t2345678901234567890123456789012345678
end


$ cat z1_42.f90
module m23456789012345678901234567890123456789012
   type t23456789012345678901234567890123456789012
   end type
   interface
      module subroutine s23456789012345678901234567890123456789012 &
        (x23456789012345678901234567890123456789012)
      end
   end interface
end
submodule(m23456789012345678901234567890123456789012) &
   t23456789012345678901234567890123456789012
end


$ cat z1_63.f90
module m23456789012345678901234567890123456789012345678901234567890123
   type t23456789012345678901234567890123456789012345678901234567890123
   end type
   interface
      module subroutine
s23456789012345678901234567890123456789012345678901234567890123 &
        (x23456789012345678901234567890123456789012345678901234567890123)
      end
   end interface
end
submodule(m23456789012345678901234567890123456789012345678901234567890123) &
   t23456789012345678901234567890123456789012345678901234567890123
end


$ gfortran-11-20200614 -c z1_37.f90
$
$ gfortran-11-20200614 -c z1_38.f90
f951: internal compiler error: Segmentation fault
0xd61fdf crash_signal
        ../../gcc/toplev.c:328
0x72a1d6 do_traverse_symtree
        ../../gcc/fortran/symbol.c:4163
0x6a40e0 gfc_check_interfaces(gfc_namespace*)
        ../../gcc/fortran/interface.c:2104
0x70f5bd resolve_types
        ../../gcc/fortran/resolve.c:17191
0x70ab9c gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.c:17290
0x6f2af2 gfc_parse_file()
        ../../gcc/fortran/parse.c:6447
0x73f8cf gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:212


$ gfortran-11-20200614 -c z1_63.f90
f951: internal compiler error: Segmentation fault
0xd61fdf crash_signal
        ../../gcc/toplev.c:328
0x6a4040 check_sym_interfaces
        ../../gcc/fortran/interface.c:2015

[Bug fortran/95689] ICE in check_sym_interfaces, at fortran/interface.c:2015

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldot at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
   Last reconfirmed|                            |2020-6-15

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r8-3955-g439d2350251a050f.

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |anlauf at gcc dot gnu.org
     Ever confirmed|0                           |1
           Priority|P3                          |P4
            Summary|ICE in                      |[8/9/10/11 Regression] ICE
                   |check_sym_interfaces, at    |in check_sym_interfaces, at
                   |fortran/interface.c:2015    |fortran/interface.c:2015
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
Technically an 8/9/10/11 regression.

The following patch fixes the ICE for me:

diff --git a/gcc/fortran/interface.c b/gcc/fortran/interface.c
index f33c6632b45..b1a75a37b0e 100644
--- a/gcc/fortran/interface.c
+++ b/gcc/fortran/interface.c
@@ -1981,7 +1981,8 @@ check_interface1 (gfc_interface *p, gfc_interface *q0,
 static void
 check_sym_interfaces (gfc_symbol *sym)
 {
-  char interface_name[GFC_MAX_SYMBOL_LEN + sizeof("generic interface ''")];
+  /* Provide sufficient space to hold "generic interface 'symbol.symbol'".  */
+  char interface_name[2*GFC_MAX_SYMBOL_LEN+2 + sizeof("generic interface
''")];
   gfc_interface *p;

   if (sym->ns != gfc_current_ns)
@@ -1989,6 +1990,8 @@ check_sym_interfaces (gfc_symbol *sym)

   if (sym->generic != NULL)
     {
+      size_t len = strlen (sym->name) + sizeof("generic interface ''");
+      gcc_assert (len < sizeof (interface_name));
       sprintf (interface_name, "generic interface '%s'", sym->name);
       if (check_interface0 (sym->generic, interface_name))
        return;

Not regtested yet.  The testcase may show subsequent fallout elsewhere
(i.e. for builds with special protection against buffer overflows).

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

--- Comment #3 from anlauf at gcc dot gnu.org ---
Patch submitted for review:

https://gcc.gnu.org/pipermail/fortran/2020-June/054525.html

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |8.5

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:62c0c0ea7bfb6f8f6b8d767b05120cafb6823da6

commit r11-1567-g62c0c0ea7bfb6f8f6b8d767b05120cafb6823da6
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jun 20 16:09:45 2020 +0200

    PR fortran/95689 - ICE in check_sym_interfaces, at fortran/interface.c:2015

    With submodules, name mangling of interfaces may result in long internal
    symbols overflowing an internal buffer.  We now check that we do not
    exceed the enlarged buffer size.

    gcc/fortran/
            PR fortran/95689
            * interface.c (check_sym_interfaces): Enlarge temporary buffer,
            and add check on length on mangled name to prevent overflow.

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:ece7b4d5f0cef0811ee1a0ebbf00ba41c5cf080c

commit r10-8338-gece7b4d5f0cef0811ee1a0ebbf00ba41c5cf080c
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jun 20 16:09:45 2020 +0200

    PR fortran/95689 - ICE in check_sym_interfaces, at fortran/interface.c:2015

    With submodules, name mangling of interfaces may result in long internal
    symbols overflowing an internal buffer.  We now check that we do not
    exceed the enlarged buffer size.

    gcc/fortran/
            PR fortran/95689
            * interface.c (check_sym_interfaces): Enlarge temporary buffer,
            and add check on length on mangled name to prevent overflow.

    (cherry picked from commit 62c0c0ea7bfb6f8f6b8d767b05120cafb6823da6)

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:84323d9fa7526496d844f167f6353e0ec12279e8

commit r9-8693-g84323d9fa7526496d844f167f6353e0ec12279e8
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jun 20 16:09:45 2020 +0200

    PR fortran/95689 - ICE in check_sym_interfaces, at fortran/interface.c:2015

    With submodules, name mangling of interfaces may result in long internal
    symbols overflowing an internal buffer.  We now check that we do not
    exceed the enlarged buffer size.

    gcc/fortran/
            PR fortran/95689
            * interface.c (check_sym_interfaces): Enlarge temporary buffer,
            and add check on length on mangled name to prevent overflow.

    (cherry picked from commit 62c0c0ea7bfb6f8f6b8d767b05120cafb6823da6)

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:4cfdae8e4a96912871865d289a5a817cec68eaa0

commit r8-10325-g4cfdae8e4a96912871865d289a5a817cec68eaa0
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jun 20 16:09:45 2020 +0200

    PR fortran/95689 - ICE in check_sym_interfaces, at fortran/interface.c:2015

    With submodules, name mangling of interfaces may result in long internal
    symbols overflowing an internal buffer.  We now check that we do not
    exceed the enlarged buffer size.

    gcc/fortran/
            PR fortran/95689
            * interface.c (check_sym_interfaces): Enlarge temporary buffer,
            and add check on length on mangled name to prevent overflow.

    (cherry picked from commit 62c0c0ea7bfb6f8f6b8d767b05120cafb6823da6)

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from anlauf at gcc dot gnu.org ---
Fixed on master for gcc-11, and backported to all open branches.

Thanks for the report!

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:e1edfe597d9157b8b9b61c4677b38730a9a59936

commit r8-10327-ge1edfe597d9157b8b9b61c4677b38730a9a59936
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Wed Jun 24 22:33:11 2020 +0200

    Revert "PR fortran/95689 - ICE in check_sym_interfaces, at
fortran/interface.c:2015"

    With submodules, name mangling of interfaces may result in long internal
    symbols overflowing an internal buffer.  We now check that we do not
    exceed the enlarged buffer size.

    gcc/fortran/
            PR fortran/95689
            * interface.c (check_sym_interfaces): Enlarge temporary buffer,
            and add check on length on mangled name to prevent overflow.

    gcc/testsuite/
            PR fortran/95689
            * gfortran.dg/pr95689.f90: New test.

            (reverts the cherry-pick from commit
62c0c0ea7bfb6f8f6b8d767b05120cafb6823da6)

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:e3d976ae009b873596b47961869b7cdfc41d7e67

commit r9-8696-ge3d976ae009b873596b47961869b7cdfc41d7e67
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Wed Jun 24 22:44:11 2020 +0200

    Revert "PR fortran/95689 - ICE in check_sym_interfaces, at
fortran/interface.c:2015"

    With submodules, name mangling of interfaces may result in long internal
    symbols overflowing an internal buffer.  We now check that we do not
    exceed the enlarged buffer size.

    gcc/fortran/
            PR fortran/95689
            * interface.c (check_sym_interfaces): Enlarge temporary buffer,
            and add check on length on mangled name to prevent overflow.

    gcc/testsuite/
            PR fortran/95689
            * gfortran.dg/pr95689.f90: New test.

            (reverts the cherry-pick from commit
62c0c0ea7bfb6f8f6b8d767b05120cafb6823da6)

[Bug fortran/95689] [8/9/10/11 Regression] ICE in check_sym_interfaces, at fortran/interface.c:2015

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95689

--- Comment #11 from anlauf at gcc dot gnu.org ---
Reverted on 8- and 9-branch, since not a critical regression, and a clean
backport would need a manual backport of a series of other fixes.