public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/95967] Poor aarch64 vector constructor code when using arm_neon.h
Date: Sun, 30 May 2021 23:19:35 +0000 [thread overview]
Message-ID: <bug-95967-4-JZrLi8V4uo@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95967-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95967
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #3)
> Created attachment 50891 [details]
> Start of the patch which should fix most of it
>
> This patch which should fix the majority of the problem though I have not
> tested it on the testcase. Basically it takes the BIT_INSERT_EXPR's and
> "combines" them such that they become a CONSTRUCTOR.
> I am still deciding if this belongs in reassoc or as part of forwprop.
This patch looks like it only fixes f1 and g1.
Most likely because I did not handle CONSTRUCTOR as the initial case:
f2:
_6 = {s0_2(D), s0_2(D), s0_2(D), s0_2(D)};
__builtin_aarch64_im_lane_boundsi (16, 4, 1);
__builtin_aarch64_im_lane_boundsi (16, 4, 2);
__builtin_aarch64_im_lane_boundsi (16, 4, 3);
_10 = BIT_INSERT_EXPR <_6, s1_3(D), 32>;
_12 = BIT_INSERT_EXPR <_10, s2_4(D), 64>;
__vec_14 = BIT_INSERT_EXPR <_12, s3_5(D), 96>;
I will look into adding that in a few weeks and add a testcase for it too.
next prev parent reply other threads:[~2021-05-30 23:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 15:20 [Bug target/95967] New: " rsandifo at gcc dot gnu.org
2020-06-29 15:21 ` [Bug target/95967] " rsandifo at gcc dot gnu.org
2021-05-30 23:08 ` pinskia at gcc dot gnu.org
2021-05-30 23:10 ` pinskia at gcc dot gnu.org
2021-05-30 23:13 ` pinskia at gcc dot gnu.org
2021-05-30 23:19 ` pinskia at gcc dot gnu.org [this message]
2021-06-03 0:46 ` pinskia at gcc dot gnu.org
2021-08-12 7:37 ` tnfchris at gcc dot gnu.org
2023-05-12 6:06 ` pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-95967-4-JZrLi8V4uo@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).