[Bug fortran/96025] New: [9/10/11 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[Bug fortran/96025] New: [9/10/11 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

            Bug ID: 96025
           Summary: [9/10/11 Regression] ICE in expr_check_typed_help, at
                    fortran/expr.c:5437
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to r6, similar to pr96024 :


$ cat z1.f90
program p
   print *, f()
contains
   character(char(1)) function f()
      f = 'f'
   end
end


$ gfortran-5 -c z1.f90
z1.f90:4:13:

    character(char(1)) function f()
             1
Error: Expression at (1) must be of INTEGER type, found CHARACTER


$ gfortran-11-20200628 -c z1.f90
f951: internal compiler error: Segmentation fault
0xbd215f crash_signal
        ../../gcc/toplev.c:328
0x6592b0 expr_check_typed_help
        ../../gcc/fortran/expr.c:5437
0x65f90d gfc_traverse_expr(gfc_expr*, gfc_symbol*, bool (*)(gfc_expr*,
gfc_symbol*, int*), int)
        ../../gcc/fortran/expr.c:5212
0x65f956 gfc_traverse_expr(gfc_expr*, gfc_symbol*, bool (*)(gfc_expr*,
gfc_symbol*, int*), int)
        ../../gcc/fortran/expr.c:5262
0x65fa01 gfc_traverse_expr(gfc_expr*, gfc_symbol*, bool (*)(gfc_expr*,
gfc_symbol*, int*), int)
        ../../gcc/fortran/expr.c:5219
0x65ff5e gfc_expr_check_typed(gfc_expr*, gfc_namespace*, bool)
        ../../gcc/fortran/expr.c:5475
0x6b13af parse_spec
        ../../gcc/fortran/parse.c:3829
0x6b3f0c parse_progunit
        ../../gcc/fortran/parse.c:5852
0x6b42f1 parse_contained
        ../../gcc/fortran/parse.c:5753
0x6b4196 parse_progunit
        ../../gcc/fortran/parse.c:5924
0x6b55e9 gfc_parse_file()
        ../../gcc/fortran/parse.c:6393
0x7016ff gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:212

[Bug fortran/96025] [9/10/11 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---

Also related :


$ cat z2.f90
module m
contains
   character(char(1)) function f()
      f = 'f'
   end
end
program p
   use m
   print *, f()
end


$ gfortran-11-20200628 -c z2.f90
f951: internal compiler error: in gfc_traverse_expr, at fortran/expr.c:5269
0x65fcbf gfc_traverse_expr(gfc_expr*, gfc_symbol*, bool (*)(gfc_expr*,
gfc_symbol*, int*), int)
        ../../gcc/fortran/expr.c:5269
0x65fa01 gfc_traverse_expr(gfc_expr*, gfc_symbol*, bool (*)(gfc_expr*,
gfc_symbol*, int*), int)
        ../../gcc/fortran/expr.c:5219
0x65ff5e gfc_expr_check_typed(gfc_expr*, gfc_namespace*, bool)
        ../../gcc/fortran/expr.c:5475
0x6b13af parse_spec
        ../../gcc/fortran/parse.c:3829
0x6b3f0c parse_progunit
        ../../gcc/fortran/parse.c:5852
0x6b42f1 parse_contained
        ../../gcc/fortran/parse.c:5753
0x6b5127 parse_module
        ../../gcc/fortran/parse.c:6126
0x6b5457 gfc_parse_file()
        ../../gcc/fortran/parse.c:6429
0x7016ff gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:212

[Bug fortran/96025] [9/10/11 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2020-07-01

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
GCC11 and GCC7 give

pr96025.f90:4:13:

    4 |    character(char(1)) function f()
      |             1
Error: Expression at (1) must be of INTEGER type, found CHARACTER

but the instrumented compiler gives

==71986==ERROR: AddressSanitizer: heap-use-after-free on address 0x604000000f90
at pc 0x00010015d5e6 bp 0x7ffeefbfe490 sp 0x7ffeefbfe488
READ of size 8 at 0x604000000f90 thread T0
    #0 0x10015d5e5 in gfc_traverse_expr(gfc_expr*, gfc_symbol*, bool
(*)(gfc_expr*, gfc_symbol*, int*), int) expr.c:5217
    #1 0x1001709cb in gfc_expr_check_typed(gfc_expr*, gfc_namespace*, bool)
expr.c:5475
    #2 0x1003575e0 in check_function_result_typed() parse.c:3720
    #3 0x10036b22d in parse_spec(gfc_statement) parse.c:3827
    #4 0x100371f06 in parse_progunit(gfc_statement) parse.c:5852
    #5 0x100372910 in parse_contained(int) parse.c:5753
    #6 0x1003724c5 in parse_progunit(gfc_statement) parse.c:5924
    #7 0x10037465f in gfc_parse_file() parse.c:6393
    #8 0x10055a224 in gfc_be_parse_file() f95-lang.c:212
    #9 0x106b46254 in compile_file() toplev.c:458
    #10 0x106b552e3 in do_compile() toplev.c:2307
    #11 0x10a42f19e in toplev::main(int, char**) toplev.c:2446
    #12 0x10a933d44 in main main.c:39
    #13 0x7fff6bb23cc8 in start+0x0 (libdyld.dylib:x86_64+0x1acc8)

0x604000000f90 is located 0 bytes inside of 48-byte region
[0x604000000f90,0x604000000fc0)
freed by thread T0 here:
    #0 0x15b8378f7 in wrap_free.part.0+0x97 (libasan.6.dylib:x86_64+0x4a8f7)
    #1 0x10050d6db in gfc_free_charlen(gfc_charlen*, gfc_charlen*)
symbol.c:3990
    #2 0x10050da95 in gfc_free_namespace(gfc_namespace*) symbol.c:4041
    #3 0x1000d5a47 in gfc_match_char_spec(gfc_typespec*) decl.c:3506
    #4 0x1000f171d in gfc_match_decl_type_spec(gfc_typespec*, int) decl.c:4166
    #5 0x1000f59ce in gfc_match_prefix(gfc_typespec*) decl.c:6317
    #6 0x100364d2d in match_deferred_characteristics(gfc_typespec*)
parse.c:3666
    #7 0x10036ba1e in parse_spec(gfc_statement) parse.c:3936
    #8 0x100371f06 in parse_progunit(gfc_statement) parse.c:5852
    #9 0x100372910 in parse_contained(int) parse.c:5753
    #10 0x1003724c5 in parse_progunit(gfc_statement) parse.c:5924
    #11 0x10037465f in gfc_parse_file() parse.c:6393
    #12 0x10055a224 in gfc_be_parse_file() f95-lang.c:212
    #13 0x106b46254 in compile_file() toplev.c:458
    #14 0x106b552e3 in do_compile() toplev.c:2307
    #15 0x10a42f19e in toplev::main(int, char**) toplev.c:2446
    #16 0x10a933d44 in main main.c:39
    #17 0x7fff6bb23cc8 in start+0x0 (libdyld.dylib:x86_64+0x1acc8)

previously allocated by thread T0 here:
    #0 0x15b837fff in wrap_calloc+0xbf (libasan.6.dylib:x86_64+0x4afff)
    #1 0x109833754 in xcalloc xmalloc.c:162
    #2 0x10050b457 in gfc_new_charlen(gfc_namespace*, gfc_charlen*)
symbol.c:3954
    #3 0x10044a874 in fixup_charlen(gfc_expr*) resolve.c:6078
    #4 0x10041538e in gfc_resolve_expr(gfc_expr*) resolve.c:7108
    #5 0x1001650df in gfc_reduce_init_expr(gfc_expr*) expr.c:3085
    #6 0x1000d59b5 in gfc_match_char_spec(gfc_typespec*) decl.c:3496
    #7 0x1000f171d in gfc_match_decl_type_spec(gfc_typespec*, int) decl.c:4166
    #8 0x1000f59ce in gfc_match_prefix(gfc_typespec*) decl.c:6317
    #9 0x100364d2d in match_deferred_characteristics(gfc_typespec*)
parse.c:3666
    #10 0x10036ba1e in parse_spec(gfc_statement) parse.c:3936
    #11 0x100371f06 in parse_progunit(gfc_statement) parse.c:5852
    #12 0x100372910 in parse_contained(int) parse.c:5753
    #13 0x1003724c5 in parse_progunit(gfc_statement) parse.c:5924
    #14 0x10037465f in gfc_parse_file() parse.c:6393
    #15 0x10055a224 in gfc_be_parse_file() f95-lang.c:212
    #16 0x106b46254 in compile_file() toplev.c:458
    #17 0x106b552e3 in do_compile() toplev.c:2307
    #18 0x10a42f19e in toplev::main(int, char**) toplev.c:2446
    #19 0x10a933d44 in main main.c:39
    #20 0x7fff6bb23cc8 in start+0x0 (libdyld.dylib:x86_64+0x1acc8)


For GCC8 to GCC10 I get a

(null):0: confused by earlier errors, bailing out

(release builds)/

[Bug fortran/96025] [9/10/11 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #3 from kargl at gcc dot gnu.org ---
This fixes the ICE.  Patch is against svn revision 280156.

e-ts.u.cl is a garbage pointer.

Index: gcc/fortran/expr.c
===================================================================
--- gcc/fortran/expr.c  (revision 280157)
+++ gcc/fortran/expr.c  (working copy)
@@ -3447,6 +3447,7 @@ gfc_specification_expr (gfc_expr *e)
     {
       gfc_error ("Expression at %L must be of INTEGER type, found %s",
                 &e->where, gfc_basic_typename (e->ts.type));
+      gfc_clear_ts (&e->ts);
       return false;
     }

[Bug fortran/96025] [9/10/11 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug fortran/96025] [9/10/11 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |9.4

[Bug fortran/96025] [9/10/11 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> This fixes the ICE.

Confirmed, with the patch I get

Error: Expression at (1) must be of INTEGER type, found CHARACTER

[Bug fortran/96025] [9/10/11/12 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug fortran/96025] [10/11/12/13 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug fortran/96025] [10/11/12/13 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug fortran/96025] [10/11/12/13 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #8 from anlauf at gcc dot gnu.org ---
Created attachment 54488
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54488&action=edit
Tentative patch

The attached patch adds some hopefully more reasonable error recovery.
Regtests cleanly on x86_64-pc-linux-gnu and is valgrind clean.

[Bug fortran/96025] [10/11/12/13 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #9 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2023-February/058942.html

[Bug fortran/96025] [10/11/12/13 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:6c1b825b3d6499dfeacf7c79dcf4b56a393ac204

commit r13-6265-g6c1b825b3d6499dfeacf7c79dcf4b56a393ac204
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Feb 20 21:28:09 2023 +0100

    Fortran: improve checking of character length specification [PR96025]

    gcc/fortran/ChangeLog:

            PR fortran/96025
            * parse.cc (check_function_result_typed): Improve type check of
            specification expression for character length and return status.
            (parse_spec): Use status from above.
            * resolve.cc (resolve_fntype): Prevent use of invalid specification
            expression for character length.

    gcc/testsuite/ChangeLog:

            PR fortran/96025
            * gfortran.dg/pr96025.f90: New test.

[Bug fortran/96025] [10/11/12/13 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:abd1571d2340b5c86ba4d51ef9affc743e764ba8

commit r12-9220-gabd1571d2340b5c86ba4d51ef9affc743e764ba8
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Feb 20 21:28:09 2023 +0100

    Fortran: improve checking of character length specification [PR96025]

    gcc/fortran/ChangeLog:

            PR fortran/96025
            * parse.cc (check_function_result_typed): Improve type check of
            specification expression for character length and return status.
            (parse_spec): Use status from above.
            * resolve.cc (resolve_fntype): Prevent use of invalid specification
            expression for character length.

    gcc/testsuite/ChangeLog:

            PR fortran/96025
            * gfortran.dg/pr96025.f90: New test.

    (cherry picked from commit 6c1b825b3d6499dfeacf7c79dcf4b56a393ac204)

[Bug fortran/96025] [10/11/12/13 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:8412f78621f6dcb7cee23dda49afb28299d8083b

commit r11-10558-g8412f78621f6dcb7cee23dda49afb28299d8083b
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Feb 20 21:28:09 2023 +0100

    Fortran: improve checking of character length specification [PR96025]

    gcc/fortran/ChangeLog:

            PR fortran/96025
            * parse.c (check_function_result_typed): Improve type check of
            specification expression for character length and return status.
            (parse_spec): Use status from above.
            * resolve.c (resolve_fntype): Prevent use of invalid specification
            expression for character length.

    gcc/testsuite/ChangeLog:

            PR fortran/96025
            * gfortran.dg/pr96025.f90: New test.

    (cherry picked from commit 6c1b825b3d6499dfeacf7c79dcf4b56a393ac204)

[Bug fortran/96025] [10/11/12/13 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:9db1287c8ced5425f6ef9d26b05a3eb9cbcc4b8d

commit r10-11239-g9db1287c8ced5425f6ef9d26b05a3eb9cbcc4b8d
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Feb 20 21:28:09 2023 +0100

    Fortran: improve checking of character length specification [PR96025]

    gcc/fortran/ChangeLog:

            PR fortran/96025
            * parse.c (check_function_result_typed): Improve type check of
            specification expression for character length and return status.
            (parse_spec): Use status from above.
            * resolve.c (resolve_fntype): Prevent use of invalid specification
            expression for character length.

    gcc/testsuite/ChangeLog:

            PR fortran/96025
            * gfortran.dg/pr96025.f90: New test.

    (cherry picked from commit 6c1b825b3d6499dfeacf7c79dcf4b56a393ac204)

[Bug fortran/96025] [10/11/12/13 Regression] ICE in expr_check_typed_help, at fortran/expr.c:5437

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96025

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from anlauf at gcc dot gnu.org ---
Fixed on all open branches.  Closing.

Thanks for the report!