[Bug driver/96248] New: Closing quote in wrong position in config/rs6000/linux64.h

[Bug driver/96248] New: Closing quote in wrong position in config/rs6000/linux64.h

[goeran at uddeborg dot se]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96248

            Bug ID: 96248
           Summary: Closing quote in wrong position in
                    config/rs6000/linux64.h
           Product: gcc
           Version: 10.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: driver
          Assignee: unassigned at gcc dot gnu.org
          Reporter: goeran at uddeborg dot se
  Target Milestone: ---

The closing quote in the message

    error ("%<-mcmodel incompatible with other toc options%>"); 

in config/rs6000/linux64.h has obviously gone astray.  It should have been
directly after "mcmodel", I presume.

This was mentioned in a comment of bug 90148, but since that report was
originally about a different issue, I thought I'd better make a separate report
so it won't get lost.  In my experience, one problem per report is a good
strategy.

[Bug target/96248] Closing quote in wrong position in config/rs6000/rs6000.c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96248

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-08-31
     Ever confirmed|0                           |1
            Summary|Closing quote in wrong      |Closing quote in wrong
                   |position in                 |position in
                   |config/rs6000/linux64.h     |config/rs6000/rs6000.c

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
It was moved to rs6000.c by r11-3604:
rs6000.c:           error ("%<-mcmodel incompatible with other toc options%>");

But otherwise confirmed.
looks like the one that was in freebsd64.h was actually correct but when merged
with the one in linux64.h to rs6000.c, the bad one was selected.

[Bug target/96248] Closing quote in wrong position in config/rs6000/rs6000.c

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96248

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=90148
           Severity|normal                      |trivial
         Depends on|40883                       |
             Blocks|                            |40883
                 CC|                            |egallager at gcc dot gnu.org
           Keywords|                            |easyhack

--- Comment #2 from Eric Gallager <egallager at gcc dot gnu.org> ---
I think the "depends on" field was supposed to be in the "blocks" field;
swapping them


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=40883
[Bug 40883] [meta-bug] Translation breakage with trivial fixes

[Bug target/96248] Closing quote in wrong position in config/rs6000/rs6000.c

[goeran at uddeborg dot se]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96248

Göran Uddeborg <goeran at uddeborg dot se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Göran Uddeborg <goeran at uddeborg dot se> ---
This has been fixed in 12.1-b20220403.