public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/96342] [SVE] Add support for "omp declare simd" Date: Mon, 26 Oct 2020 16:20:32 +0000 [thread overview] Message-ID: <bug-96342-4-LGOtkV5v8j@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-96342-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96342 --- Comment #6 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> --- Comment on attachment 49413 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49413 part1-patch Thanks for the summary and patches, and sorry for the delayed reply. Taking part1-patch first: this generally looks good to me. Some minor things: - It isn't necessary to use poly_int stuff in i386.c, since the new poly_uint64 will naturally decay to a uint64_t in i386 target files. It might still be necessary to update some of the printf formats though. - It's more correct to use "unsigned HOST_WIDE_INT" instead of "long unsigned int" and %wd instead of %ld. One reason is that we support cross builds from 32-bit hosts, where long is 32 bits. Long is also 32 bits for ILP32. - Some of the multiple_p calls can instead use exact_div, which is the preferred way of performing a division that is known to have no remainder. I think it's clear that we need to make this change, and since it's a natural "poly_intification", I don't think it needs to wait for other SVE work to be completed. So would you be able to submit the patch to the list independently of the other work? Stage 1 closes in three weeks' time so it would be good to get this in before then. Thanks again for doing this.
next prev parent reply other threads:[~2020-10-26 16:20 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-27 16:51 [Bug target/96342] New: " rsandifo at gcc dot gnu.org 2020-08-05 2:46 ` [Bug target/96342] " yangyang305 at huawei dot com 2020-08-05 8:53 ` rsandifo at gcc dot gnu.org 2020-10-21 8:38 ` yangyang305 at huawei dot com 2020-10-21 8:39 ` yangyang305 at huawei dot com 2020-10-21 8:39 ` yangyang305 at huawei dot com 2020-10-26 16:20 ` rsandifo at gcc dot gnu.org [this message] 2020-10-26 16:27 ` rsandifo at gcc dot gnu.org 2020-10-26 16:53 ` rsandifo at gcc dot gnu.org 2020-11-03 16:14 ` cvs-commit at gcc dot gnu.org 2023-02-08 11:48 ` avieira at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-96342-4-LGOtkV5v8j@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).