public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/96357] New: [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE
@ 2020-07-28 14:59 ktkachov at gcc dot gnu.org
2020-07-28 15:00 ` [Bug target/96357] " ktkachov at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: ktkachov at gcc dot gnu.org @ 2020-07-28 14:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96357
Bug ID: 96357
Summary: [10/11 Regression] could not split insn
UNSPEC_COND_FSUB with AArch64 SVE
Product: gcc
Version: unknown
Status: UNCONFIRMED
Keywords: ice-on-valid-code
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: ktkachov at gcc dot gnu.org
Target Milestone: ---
The reduced testcase:
typedef int a;
int d;
void e(char f, char *g, char *h, char *l, char * n) {
double i = d, j = 1.0 - f, k = j ? d : j;
if (k == 1.0)
i = 0.0;
*g = *h = i * 0.5;
*l = *n = 0;
}
void o() {
int a, m, c = o;
for (; c; c--) {
char b = a++;
e(b, m, m + 1, m + 2, m + 3);
m += 4;
}
}
ICEs with -w -O3 -march=arvm8.2-a+sve
reduced.c: In function ‘o’:
reduced.c:18:1: error: could not split insn
18 | }
| ^
(insn 145 401 149 (set (reg:VNx2DF 39 v7 [orig:145 _127 ] [145])
(unspec:VNx2DF [
(reg:VNx2BI 69 p1 [318])
(unspec:VNx2DF [
(reg:VNx2BI 78 p10 [318])
(const_int 1 [0x1])
(const_vector:VNx2DF [
(const_double:DF 1.0e+0 [0x0.8p+1])
])
(reg:VNx2DF 37 v5 [orig:152 vect__27.15 ] [152])
] UNSPEC_COND_FSUB)
(reg:VNx2DF 48 v16 [orig:140 vect_i_26.13 ] [140])
] UNSPEC_SEL)) 5775 {*cond_subvnx2df_any_const}
(expr_list:REG_DEAD (reg:VNx2BI 78 p10 [318])
(expr_list:REG_DEAD (reg:VNx2BI 69 p1 [318])
(expr_list:REG_DEAD (reg:VNx2DF 37 v5 [orig:152 vect__27.15 ]
[152])
(nil)))))
during RTL pass: final
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/96357] [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE
2020-07-28 14:59 [Bug target/96357] New: [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE ktkachov at gcc dot gnu.org
@ 2020-07-28 15:00 ` ktkachov at gcc dot gnu.org
2020-08-04 11:17 ` przemyslaw.wirkus at arm dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ktkachov at gcc dot gnu.org @ 2020-07-28 15:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96357
ktkachov at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to fail| |10.2.1, 11.0
Target| |aarch64
Target Milestone|--- |10.3
Known to work| |9.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/96357] [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE
2020-07-28 14:59 [Bug target/96357] New: [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE ktkachov at gcc dot gnu.org
2020-07-28 15:00 ` [Bug target/96357] " ktkachov at gcc dot gnu.org
@ 2020-08-04 11:17 ` przemyslaw.wirkus at arm dot com
2020-08-28 10:34 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: przemyslaw.wirkus at arm dot com @ 2020-08-04 11:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96357
Przemyslaw Wirkus <przemyslaw.wirkus at arm dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |przemyslaw.wirkus at arm dot com
--- Comment #1 from Przemyslaw Wirkus <przemyslaw.wirkus at arm dot com> ---
I'm looking into it. Cheers!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/96357] [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE
2020-07-28 14:59 [Bug target/96357] New: [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE ktkachov at gcc dot gnu.org
2020-07-28 15:00 ` [Bug target/96357] " ktkachov at gcc dot gnu.org
2020-08-04 11:17 ` przemyslaw.wirkus at arm dot com
@ 2020-08-28 10:34 ` cvs-commit at gcc dot gnu.org
2020-09-09 8:40 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-08-28 10:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96357
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Przemyslaw Wirkus <wirkus@gcc.gnu.org>:
https://gcc.gnu.org/g:b648814c02eb418aaf27897c480452172ee96303
commit r11-2922-gb648814c02eb418aaf27897c480452172ee96303
Author: Przemyslaw Wirkus <przemyslaw.wirkus@arm.com>
Date: Fri Aug 28 11:31:04 2020 +0100
[PATCH PR96357][GCC][AArch64]: could not split insn UNSPEC_COND_FSUB with
AArch64 SVE
Problem is related to that operand 4 (In original pattern
cond_sub<mode>_any_const) is no longer the same as operand 1, and so
the pattern doesn't match the split condition.
Pattern cond_sub<mode>_any_const is being split by this patch into two
separate patterns:
* Pattern cond_sub<mode>_relaxed_const now matches const_int
SVE_RELAXED_GP operand.
* Pattern cond_sub<mode>_strict_const now matches const_int
SVE_STRICT_GP operand.
* Remove aarch64_sve_pred_dominates_p condition from both patterns.
gcc/ChangeLog:
PR target/96357
* config/aarch64/aarch64-sve.md
(cond_sub<mode>_relaxed_const): Updated and renamed from
cond_sub<mode>_any_const pattern.
(cond_sub<mode>_strict_const): New pattern.
gcc/testsuite/ChangeLog:
PR target/96357
* gcc.target/aarch64/sve/pr96357.c: New test.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/96357] [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE
2020-07-28 14:59 [Bug target/96357] New: [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE ktkachov at gcc dot gnu.org
` (2 preceding siblings ...)
2020-08-28 10:34 ` cvs-commit at gcc dot gnu.org
@ 2020-09-09 8:40 ` cvs-commit at gcc dot gnu.org
2020-09-09 10:02 ` ktkachov at gcc dot gnu.org
2021-03-01 11:10 ` ktkachov at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-09 8:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96357
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Przemyslaw Wirkus
<wirkus@gcc.gnu.org>:
https://gcc.gnu.org/g:41d22ec51c4190133a082197e7ff67b4741fc09b
commit r10-8720-g41d22ec51c4190133a082197e7ff67b4741fc09b
Author: Przemyslaw Wirkus <przemyslaw.wirkus@arm.com>
Date: Fri Aug 28 11:31:04 2020 +0100
[PATCH PR96357][GCC][AArch64]: could not split insn UNSPEC_COND_FSUB with
AArch64 SVE
Problem is related to that operand 4 (In original pattern
cond_sub<mode>_any_const) is no longer the same as operand 1, and so
the pattern doesn't match the split condition.
Pattern cond_sub<mode>_any_const is being split by this patch into two
separate patterns:
* Pattern cond_sub<mode>_relaxed_const now matches const_int
SVE_RELAXED_GP operand.
* Pattern cond_sub<mode>_strict_const now matches const_int
SVE_STRICT_GP operand.
* Remove aarch64_sve_pred_dominates_p condition from both patterns.
gcc/ChangeLog:
PR target/96357
* config/aarch64/aarch64-sve.md
(cond_sub<mode>_relaxed_const): Updated and renamed from
cond_sub<mode>_any_const pattern.
(cond_sub<mode>_strict_const): New pattern.
gcc/testsuite/ChangeLog:
PR target/96357
* gcc.target/aarch64/sve/pr96357.c: New test.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/96357] [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE
2020-07-28 14:59 [Bug target/96357] New: [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE ktkachov at gcc dot gnu.org
` (3 preceding siblings ...)
2020-09-09 8:40 ` cvs-commit at gcc dot gnu.org
@ 2020-09-09 10:02 ` ktkachov at gcc dot gnu.org
2021-03-01 11:10 ` ktkachov at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: ktkachov at gcc dot gnu.org @ 2020-09-09 10:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96357
ktkachov at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #4 from ktkachov at gcc dot gnu.org ---
Fixed everywhere then, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/96357] [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE
2020-07-28 14:59 [Bug target/96357] New: [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE ktkachov at gcc dot gnu.org
` (4 preceding siblings ...)
2020-09-09 10:02 ` ktkachov at gcc dot gnu.org
@ 2021-03-01 11:10 ` ktkachov at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: ktkachov at gcc dot gnu.org @ 2021-03-01 11:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96357
ktkachov at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrew.goodbody at linaro dot org
--- Comment #5 from ktkachov at gcc dot gnu.org ---
*** Bug 99316 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-01 11:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 14:59 [Bug target/96357] New: [10/11 Regression] could not split insn UNSPEC_COND_FSUB with AArch64 SVE ktkachov at gcc dot gnu.org
2020-07-28 15:00 ` [Bug target/96357] " ktkachov at gcc dot gnu.org
2020-08-04 11:17 ` przemyslaw.wirkus at arm dot com
2020-08-28 10:34 ` cvs-commit at gcc dot gnu.org
2020-09-09 8:40 ` cvs-commit at gcc dot gnu.org
2020-09-09 10:02 ` ktkachov at gcc dot gnu.org
2021-03-01 11:10 ` ktkachov at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).