public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/96449] New: libstdc++-v3/src/c++17/floating_from_chars.cc:326:Found duplicate branches for 'if' and 'else'
@ 2020-08-04  7:56 dcb314 at hotmail dot com
  2020-08-04  9:51 ` [Bug libstdc++/96449] " redi at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: dcb314 at hotmail dot com @ 2020-08-04  7:56 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96449

            Bug ID: 96449
           Summary: libstdc++-v3/src/c++17/floating_from_chars.cc:326:Foun
                    d duplicate branches for 'if' and 'else'
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Source code is

            if (isinf(tmpval)) // overflow
              ec = errc::result_out_of_range;
            else // underflow (LWG 3081 wants to set value = tmpval here)
              ec = errc::result_out_of_range;

Maybe the if statement is not required or the branches should be different ?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libstdc++/96449] libstdc++-v3/src/c++17/floating_from_chars.cc:326:Found duplicate branches for 'if' and 'else'
  2020-08-04  7:56 [Bug libstdc++/96449] New: libstdc++-v3/src/c++17/floating_from_chars.cc:326:Found duplicate branches for 'if' and 'else' dcb314 at hotmail dot com
@ 2020-08-04  9:51 ` redi at gcc dot gnu.org
  2020-08-04  9:52 ` redi at gcc dot gnu.org
  2020-08-05  6:56 ` dcb314 at hotmail dot com
  2 siblings, 0 replies; 4+ messages in thread
From: redi at gcc dot gnu.org @ 2020-08-04  9:51 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96449

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
This is intentional. As the comment says, the branches might be different in
future, so I'm leaving them like that.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libstdc++/96449] libstdc++-v3/src/c++17/floating_from_chars.cc:326:Found duplicate branches for 'if' and 'else'
  2020-08-04  7:56 [Bug libstdc++/96449] New: libstdc++-v3/src/c++17/floating_from_chars.cc:326:Found duplicate branches for 'if' and 'else' dcb314 at hotmail dot com
  2020-08-04  9:51 ` [Bug libstdc++/96449] " redi at gcc dot gnu.org
@ 2020-08-04  9:52 ` redi at gcc dot gnu.org
  2020-08-05  6:56 ` dcb314 at hotmail dot com
  2 siblings, 0 replies; 4+ messages in thread
From: redi at gcc dot gnu.org @ 2020-08-04  9:52 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96449

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |WONTFIX

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Actually I guess WONTFIX is more accurate, since the report is right.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug libstdc++/96449] libstdc++-v3/src/c++17/floating_from_chars.cc:326:Found duplicate branches for 'if' and 'else'
  2020-08-04  7:56 [Bug libstdc++/96449] New: libstdc++-v3/src/c++17/floating_from_chars.cc:326:Found duplicate branches for 'if' and 'else' dcb314 at hotmail dot com
  2020-08-04  9:51 ` [Bug libstdc++/96449] " redi at gcc dot gnu.org
  2020-08-04  9:52 ` redi at gcc dot gnu.org
@ 2020-08-05  6:56 ` dcb314 at hotmail dot com
  2 siblings, 0 replies; 4+ messages in thread
From: dcb314 at hotmail dot com @ 2020-08-05  6:56 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96449

--- Comment #3 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Jonathan Wakely from comment #1)
> As the comment says, the branches might be different in future

It is not clear to me that the comment says that.

Suggest new comment text:

// Intentional duplicate branches. They may change in the future.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-05  6:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04  7:56 [Bug libstdc++/96449] New: libstdc++-v3/src/c++17/floating_from_chars.cc:326:Found duplicate branches for 'if' and 'else' dcb314 at hotmail dot com
2020-08-04  9:51 ` [Bug libstdc++/96449] " redi at gcc dot gnu.org
2020-08-04  9:52 ` redi at gcc dot gnu.org
2020-08-05  6:56 ` dcb314 at hotmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).