[Bug testsuite/96470] New: [10 regression] gnat.dg/opt39.adb fails since r10-917

[Bug testsuite/96470] New: [10 regression] gnat.dg/opt39.adb fails since r10-917

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

            Bug ID: 96470
           Summary: [10 regression] gnat.dg/opt39.adb fails since r10-917
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:3b47da42de621c6c3bf7d2f9245df989aa7eb5a1, r10-917

This still is failing in gcc 11.

Executing on host: /home/seurer/gcc/git/build/gcc-ada/gcc/gnatmake
--GCC=/home/seurer/gcc/git/build/gcc-ada/gcc/xgcc
--GNATBIND=/home/seurer/gcc/git/build/gcc-ada/gcc/gnatbind
--GNATLINK=/home/seurer/gcc/git/build/gcc-ada/gcc/gnatlink -cargs
-B/home/seurer/gcc/git/build/gcc-ada/gcc -largs
--GCC=/home/seurer/gcc/git/build/gcc-ada/gcc/xgcc\
-B/home/seurer/gcc/git/build/gcc-ada/gcc\  -margs
--RTS=/home/seurer/gcc/git/build/gcc-ada/powerpc64le-unknown-linux-gnu/./libada
-q -f /home/seurer/gcc/git/gcc-ada/gcc/testsuite/gnat.dg/opt39.adb  
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never  -O2 -fno-inline -fdump-tree-optimized -c -u -S -o
opt39.s    (timeout = 300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-ada/gcc/gnatmake
--GCC=/home/seurer/gcc/git/build/gcc-ada/gcc/xgcc
--GNATBIND=/home/seurer/gcc/git/build/gcc-ada/gcc/gnatbind
--GNATLINK=/home/seurer/gcc/git/build/gcc-ada/gcc/gnatlink -cargs
-B/home/seurer/gcc/git/build/gcc-ada/gcc -largs
--GCC=/home/seurer/gcc/git/build/gcc-ada/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-ada/gcc  -margs
--RTS=/home/seurer/gcc/git/build/gcc-ada/powerpc64le-unknown-linux-gnu/./libada
-q -f /home/seurer/gcc/git/gcc-ada/gcc/testsuite/gnat.dg/opt39.adb
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never -O2 -fno-inline -fdump-tree-optimized -c -u -S -o
opt39.s
Executing on host: /home/seurer/gcc/git/build/gcc-ada/gcc/gnatclean -c -q -n
opt39   (timeout = 300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-ada/gcc/gnatclean -c -q -n
opt39
./opt39.ali
./opt39.s
PASS: gnat.dg/opt39.adb (test for excess errors)
PASS: gnat.dg/opt39.adb scan-tree-dump-not optimized "MEM"
FAIL: gnat.dg/opt39.adb scan-tree-dump-not optimized "tmp"
testcase /home/seurer/gcc/git/gcc-ada/gcc/testsuite/gnat.dg/dg.exp completed in
0 seconds

                === gnat Summary ===

# of expected passes            2
# of unexpected failures        1



commit 3b47da42de621c6c3bf7d2f9245df989aa7eb5a1 (HEAD)
Author: Martin Jambor <mjambor@suse.cz>
Date:   Thu Jun 6 18:31:20 2019 +0200

    Make SRA re-construct orginal memory accesses when easy

    2019-06-06  Martin Jambor  <mjambor@suse.cz>

            * tree-sra.c (struct access): New field grp_same_access_path.
            (dump_access): Dump it.
            (build_reconstructed_reference): New function.
            (build_ref_for_model): Use it if possible.
            (path_comparable_for_same_access): New function.
            (same_access_path_p): Likewise.
            (sort_and_splice_var_accesses): Set the new flag.
            (analyze_access_subtree): Likewise.
            (propagate_subaccesses_across_link): Propagate zero value of the
new
            flag down the access tree.

            testsuite/
            * gcc.dg/tree-ssa/alias-access-path-1.c: Remove -fno-tree-sra
option.
            * gcc.dg/tree-ssa/ssa-dse-26.c: Disable FRE.
            * testsuite/gnat.dg/opt39.adb: Adjust scan dump.

    From-SVN: r272012

[Bug testsuite/96470] [10 regression] gnat.dg/opt39.adb fails since r10-917

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.3

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
possibly a missed optimization caused by that rev.

[Bug target/96470] [10/11 regression] gnat.dg/opt39.adb is not scalarized

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu.org
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-09-28
          Component|testsuite                   |target
             Status|UNCONFIRMED                 |NEW
            Summary|[10 regression]             |[10/11 regression]
                   |gnat.dg/opt39.adb fails     |gnat.dg/opt39.adb is not
                   |since r10-917               |scalarized

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
The difference is:

Rejected (3173): not aggregate: a
Rejected (3174): not aggregate: i
Rejected (3175): not aggregate: aL
Candidate (3180): tmp
Too big to totally scalarize: tmp (UID: 3180)

because max_scalarization_size == 128 on PowerPC64 (it's 1088 on x86-64) in the
analyze_all_variable_accesses function.  So I can force the test to pass on
PowerPC64 by means of --param=sra-max-scalarization-size-Ospeed=32 but the
default max_scalarization_size seems to be unduly low on PowerPC64 (just 2
words).

[Bug target/96470] [10/11 regression] gnat.dg/opt39.adb is not scalarized

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Via

  /* If the user didn't set PARAM_SRA_MAX_SCALARIZATION_SIZE_<...>,
     fall back to a target default.  */
  unsigned HOST_WIDE_INT max_scalarization_size
    = get_move_ratio (optimize_speed_p) * UNITS_PER_WORD;

and rs6000 not altering MOVE_RATIO from its default

/* If a memory-to-memory move would take MOVE_RATIO or more simple
   move-instruction sequences, we will do a cpymem or libcall instead.  */

#ifndef MOVE_RATIO
#if defined (HAVE_cpymemqi) || defined (HAVE_cpymemhi) || defined
(HAVE_cpymemsi) || defined (HAVE_cpymemdi) || defined (HAVE_cpymemti)
#define MOVE_RATIO(speed) 2
#else
/* If we are optimizing for space (-Os), cut down the default move ratio.  */
#define MOVE_RATIO(speed) ((speed) ? 15 : 3)
#endif
#endif

and rs6000 having cpymem.

[Bug target/96470] [10/11 regression] gnat.dg/opt39.adb is not scalarized

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Eric Botcazou <ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:c1370f8c0d0760714fe77d55c1fa16045ffa69f2

commit r11-5837-gc1370f8c0d0760714fe77d55c1fa16045ffa69f2
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Tue Dec 8 09:19:36 2020 +0100

    Fix PR target/96470

    This forces the scalarization of the testcase on PowerPC.

    gcc/testsuite/ChangeLog:
            PR target/96470
            * gnat.dg/opt39.adb: Add dg-additional-options for PowerPC.

[Bug target/96470] [10/11 regression] gnat.dg/opt39.adb is not scalarized

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Eric Botcazou
<ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:61382972d005a76bc9e5d1dd66c6b515f62499d7

commit r10-9130-g61382972d005a76bc9e5d1dd66c6b515f62499d7
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Tue Dec 8 09:19:36 2020 +0100

    Fix PR target/96470

    This forces the scalarization of the testcase on PowerPC.

    gcc/testsuite/ChangeLog:
            PR target/96470
            * gnat.dg/opt39.adb: Add dg-additional-options for PowerPC.

[Bug target/96470] [10/11 regression] gnat.dg/opt39.adb is not scalarized

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Fixed everywhere.