public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "stefansf at linux dot ibm.com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/96564] New: New maybe use of uninitialized variable warning since GCC >10
Date: Tue, 11 Aug 2020 07:30:04 +0000	[thread overview]
Message-ID: <bug-96564-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96564

            Bug ID: 96564
           Summary: New maybe use of uninitialized variable warning since
                    GCC >10
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: stefansf at linux dot ibm.com
  Target Milestone: ---

Consider the following MWE:

extern void* malloc (long unsigned int);
void fun (unsigned *x) {
  unsigned *a = malloc (*x);
  if (a == 0)
    return;
  if (a != x)            // (A)
    *a = *x;
  *x = *a;
}

If compiled with GCC 10, then no warning is emitted.

If compiled with GCC HEAD (currently 84005b8abf9), then the following warning
is emitted:

gcc -W -c -O2 mwe.c
mwe.c: In function 'fun':
mwe.c:8:8: warning: '*(a)' may be used uninitialized [-Wmaybe-uninitialized]
    8 |   *x = *a;
      |        ^~

Rational why this example is strictly speaking fine:

1) Assume x is a valid pointer.  Then malloc will either return a nullpointer
and we return, or a pointer to a fresh object which address is different from
any other existing object.  Thus (A) always evaluates to true which means *a is
initialized.

2) Assume x is an invalid pointer.  Then dereferencing x prior to the call to
malloc already results in UB.

Thus the only case in which condition (A) may evaluate to false is when x is an
invalid pointer (e.g. previously malloc'd and then free'd such that a further
call to malloc returns the very same address rendering (A) false) results in
UB.

Since this is a maybe warning I'm wondering whether this is considered a bug or
is acceptable.  Any thoughts?

             reply	other threads:[~2020-08-11  7:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11  7:30 stefansf at linux dot ibm.com [this message]
2020-08-11  9:27 ` [Bug middle-end/96564] " glisse at gcc dot gnu.org
2020-08-11  9:47 ` [Bug middle-end/96564] [11 Regression] New maybe use of uninitialized variable warning since r11-959 jakub at gcc dot gnu.org
2020-08-11 17:10 ` msebor at gcc dot gnu.org
2020-08-11 17:24 ` msebor at gcc dot gnu.org
2020-08-25  8:20 ` rguenth at gcc dot gnu.org
2021-01-14  9:19 ` rguenth at gcc dot gnu.org
2021-02-11 10:48 ` jakub at gcc dot gnu.org
2021-04-27 11:39 ` [Bug middle-end/96564] [11/12 " jakub at gcc dot gnu.org
2021-07-28  7:05 ` rguenth at gcc dot gnu.org
2022-04-21  7:48 ` rguenth at gcc dot gnu.org
2023-03-14  5:00 ` [Bug middle-end/96564] [11/12/13 " pinskia at gcc dot gnu.org
2023-05-29 10:03 ` [Bug middle-end/96564] [11/12/13/14 " jakub at gcc dot gnu.org
2024-03-10 22:49 ` law at gcc dot gnu.org
2024-03-11 10:23 ` rguenth at gcc dot gnu.org
2024-03-11 13:26 ` rguenth at gcc dot gnu.org
2024-03-11 15:20 ` amacleod at redhat dot com
2024-03-12  7:37 ` rguenth at gcc dot gnu.org
2024-05-16 11:23 ` [Bug middle-end/96564] [11/12/13/14/15 " rguenth at gcc dot gnu.org
2024-05-16 12:44 ` cvs-commit at gcc dot gnu.org
2024-05-16 14:27 ` aldyh at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96564-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).