[Bug ipa/96806] New: ICE: in good_cloning_opportunity_p, at ipa-cp.c:3235 with -O -fipa-cp -fipa-cp-clone --param=ipa-cp-max-recursive-depth=94 --param=logical-op-non-short-circuit=0

[Bug ipa/96806] New: ICE: in good_cloning_opportunity_p, at ipa-cp.c:3235 with -O -fipa-cp -fipa-cp-clone --param=ipa-cp-max-recursive-depth=94 --param=logical-op-non-short-circuit=0

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96806

            Bug ID: 96806
           Summary: ICE: in good_cloning_opportunity_p, at ipa-cp.c:3235
                    with -O -fipa-cp -fipa-cp-clone
                    --param=ipa-cp-max-recursive-depth=94
                    --param=logical-op-non-short-circuit=0
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
                CC: marxin at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu

Created attachment 49136
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49136&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -O -fipa-cp -fipa-cp-clone
--param=ipa-cp-max-recursive-depth=94 --param=logical-op-non-short-circuit=0
testcase.C 
testcase.C: In function 'int w(const p*, const p*, const m*, int)':
testcase.C:45:1: warning: control reaches end of non-void function
[-Wreturn-type]
   45 | }
      | ^
during IPA pass: cp
testcase.C: At global scope:
testcase.C:49:1: internal compiler error: in good_cloning_opportunity_p, at
ipa-cp.c:3235
   49 | }
      | ^
0xa68e97 good_cloning_opportunity_p
        /repo/gcc-trunk/gcc/ipa-cp.c:3235
0x1ce1a8c decide_about_value<tree_node*>
        /repo/gcc-trunk/gcc/ipa-cp.c:5482
0x1ce3024 decide_whether_version_node
        /repo/gcc-trunk/gcc/ipa-cp.c:5549
0x1ce3024 ipcp_decision_stage
        /repo/gcc-trunk/gcc/ipa-cp.c:5731
0x1ce3024 ipcp_driver
        /repo/gcc-trunk/gcc/ipa-cp.c:5918
0x1ce3024 execute
        /repo/gcc-trunk/gcc/ipa-cp.c:6009
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r11-2874-20200826111256-ge3684bcbf88-checking-yes-rtl-df-extra-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/11.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu
--with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r11-2874-20200826111256-ge3684bcbf88-checking-yes-rtl-df-extra-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.0.0 20200826 (experimental) (GCC)

[Bug ipa/96806] ICE: in good_cloning_opportunity_p, at ipa-cp.c:3235 with -O -fipa-cp -fipa-cp-clone --param=ipa-cp-max-recursive-depth=94 --param=logical-op-non-short-circuit=0

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96806

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |fxue at gcc dot gnu.org,
                   |                            |jamborm at gcc dot gnu.org
   Last reconfirmed|                            |2020-08-26

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Likely started when the params were added?
r10-5098-g9b14fc3326e08797

[Bug ipa/96806] ICE: in good_cloning_opportunity_p, at ipa-cp.c:3235 with -O -fipa-cp -fipa-cp-clone --param=ipa-cp-max-recursive-depth=94 --param=logical-op-non-short-circuit=0

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96806

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Feng Xue <fxue@gcc.gnu.org>:

https://gcc.gnu.org/g:e11c4b7f837bc6b4c22b1f5bf41a9d0608d256be

commit r11-2945-ge11c4b7f837bc6b4c22b1f5bf41a9d0608d256be
Author: Feng Xue <fxue@os.amperecomputing.com>
Date:   Mon Aug 31 15:00:52 2020 +0800

    ipa/96806 - Fix ICE in ipa-cp due to integer addition overflow

    2020-08-31  Feng Xue  <fxue@os.amperecomputing.com>

    gcc/
            PR tree-optimization/96806
            * ipa-cp.c (decide_about_value): Use safe_add to avoid cost
addition
            overflow.

    gcc/testsuite/
            PR tree-optimization/96806
            * g++.dg/ipa/pr96806.C: New test.

[Bug ipa/96806] ICE: in good_cloning_opportunity_p, at ipa-cp.c:3235 with -O -fipa-cp -fipa-cp-clone --param=ipa-cp-max-recursive-depth=94 --param=logical-op-non-short-circuit=0

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96806

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |11.0
             Status|NEW                         |RESOLVED

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.