public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/96914] New: missing MVE intrinsics
@ 2020-09-03  9:10 clyon at gcc dot gnu.org
  2020-09-03  9:10 ` [Bug target/96914] " clyon at gcc dot gnu.org
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: clyon at gcc dot gnu.org @ 2020-09-03  9:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

            Bug ID: 96914
           Summary: missing MVE intrinsics
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: clyon at gcc dot gnu.org
  Target Milestone: ---

Applying the same process as in PR71233, I have noticed a few MVE intrinsics
are not implemented:
__arm_vcvtnq_u32_f32
__arm_vqdmlashq_m_n_s16
__arm_vqdmlashq_m_n_s32
__arm_vqdmlashq_m_n_s8
__arm_vqdmlashq_n_s16
__arm_vqdmlashq_n_s32
__arm_vqdmlashq_n_s8


FTR, I downloaded the full list from
https://developer.arm.com/architectures/instruction-sets/simd-isas/helium/helium-intrinsics
I parsed it with the same script provided in PR71233, I preprocessed a sample
hello-mve.c containing only:
#include <arm_mve.h>
with -mcpu=cortex-m55 -mfloat-abi=hard
and checked if any of the intrinsics defined in the doc was missing from the
preprocessed hello-mve.i, after removing the brackets from intrinsic names such
as [__arm_]vidupq_x[_n]_u16

This results in the short list above.

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
@ 2020-09-03  9:10 ` clyon at gcc dot gnu.org
  2020-10-05 12:19 ` clyon at gcc dot gnu.org
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: clyon at gcc dot gnu.org @ 2020-09-03  9:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

Christophe Lyon <clyon at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-09-03
             Status|UNCONFIRMED                 |ASSIGNED

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
  2020-09-03  9:10 ` [Bug target/96914] " clyon at gcc dot gnu.org
@ 2020-10-05 12:19 ` clyon at gcc dot gnu.org
  2020-10-05 12:33 ` clyon at gcc dot gnu.org
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: clyon at gcc dot gnu.org @ 2020-10-05 12:19 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #1 from Christophe Lyon <clyon at gcc dot gnu.org> ---
The following intrinsics are implemented, but not documented:
__arm_vqrdmlashq_n_u8
__arm_vqrdmlahq_n_u8
__arm_vqdmlahq_n_u8
__arm_vqrdmlashq_n_u16
__arm_vqrdmlahq_n_u16
__arm_vqdmlahq_n_u16
__arm_vqrdmlashq_n_u32
__arm_vqrdmlahq_n_u32
__arm_vqdmlahq_n_u32
__arm_vmlaldavaxq_p_u32
__arm_vmlaldavaxq_p_u16

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
  2020-09-03  9:10 ` [Bug target/96914] " clyon at gcc dot gnu.org
  2020-10-05 12:19 ` clyon at gcc dot gnu.org
@ 2020-10-05 12:33 ` clyon at gcc dot gnu.org
  2020-10-05 13:25 ` clyon at gcc dot gnu.org
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: clyon at gcc dot gnu.org @ 2020-10-05 12:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #2 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Patch for __arm_vcvtnq_u32_f32 sent:
https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555485.html

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2020-10-05 12:33 ` clyon at gcc dot gnu.org
@ 2020-10-05 13:25 ` clyon at gcc dot gnu.org
  2020-10-05 14:10 ` clyon at gcc dot gnu.org
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: clyon at gcc dot gnu.org @ 2020-10-05 13:25 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #3 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Patch for vqdmlash* sent:
https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555497.html

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2020-10-05 13:25 ` clyon at gcc dot gnu.org
@ 2020-10-05 14:10 ` clyon at gcc dot gnu.org
  2020-10-05 15:24 ` avieira at gcc dot gnu.org
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: clyon at gcc dot gnu.org @ 2020-10-05 14:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #4 from Christophe Lyon <clyon at gcc dot gnu.org> ---
(In reply to Christophe Lyon from comment #1)
> The following intrinsics are implemented, but not documented:
> __arm_vqrdmlashq_n_u8
> __arm_vqrdmlahq_n_u8
> __arm_vqdmlahq_n_u8
> __arm_vqrdmlashq_n_u16
> __arm_vqrdmlahq_n_u16
> __arm_vqdmlahq_n_u16
> __arm_vqrdmlashq_n_u32
> __arm_vqrdmlahq_n_u32
> __arm_vqdmlahq_n_u32
> __arm_vmlaldavaxq_p_u32
> __arm_vmlaldavaxq_p_u16

So, is the doc wrong (and my patch at comment #3 missing the unsigned
versions), or should I prepare a patch to remove these?

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2020-10-05 14:10 ` clyon at gcc dot gnu.org
@ 2020-10-05 15:24 ` avieira at gcc dot gnu.org
  2020-10-06  8:27 ` clyon at gcc dot gnu.org
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: avieira at gcc dot gnu.org @ 2020-10-05 15:24 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

avieira at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |avieira at gcc dot gnu.org

--- Comment #5 from avieira at gcc dot gnu.org ---
Hi Christophe,

The docs are right and so are you, those instructions should only have a signed
variant as the hardware instructions also only supports .S suffixes or in the
case of vmlaldavax do not support the cross 'X' variant with unsigned
datatypes.

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2020-10-05 15:24 ` avieira at gcc dot gnu.org
@ 2020-10-06  8:27 ` clyon at gcc dot gnu.org
  2020-10-08 11:12 ` cvs-commit at gcc dot gnu.org
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: clyon at gcc dot gnu.org @ 2020-10-06  8:27 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #6 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Thanks for the confirmation, I've just sent a patch to remove them:
https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555571.html

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (6 preceding siblings ...)
  2020-10-06  8:27 ` clyon at gcc dot gnu.org
@ 2020-10-08 11:12 ` cvs-commit at gcc dot gnu.org
  2020-10-08 11:13 ` cvs-commit at gcc dot gnu.org
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-10-08 11:12 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Christophe Lyon <clyon@gcc.gnu.org>:

https://gcc.gnu.org/g:afb198ee3729c29c8e681aedc656f55f4afe4053

commit r11-3721-gafb198ee3729c29c8e681aedc656f55f4afe4053
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date:   Mon Oct 5 13:11:07 2020 +0000

    arm: [MVE[ Add vqdmlashq intrinsics (PR target/96914)

    This patch adds:
    vqdmlashq_m_n_s16
    vqdmlashq_m_n_s32
    vqdmlashq_m_n_s8
    vqdmlashq_n_s16
    vqdmlashq_n_s32
    vqdmlashq_n_s8

    2020-10-08  Christophe Lyon  <christophe.lyon@linaro.org>

            gcc/
            PR target/96914
            * config/arm/arm_mve.h (vqdmlashq, vqdmlashq_m): Define.
            * config/arm/arm_mve_builtins.def (vqdmlashq_n_s)
            (vqdmlashq_m_n_s,): New.
            * config/arm/unspecs.md (VQDMLASHQ_N_S, VQDMLASHQ_M_N_S): New
            unspecs.
            * config/arm/iterators.md (VQDMLASHQ_N_S, VQDMLASHQ_M_N_S): New
            attributes.
            (VQDMLASHQ_N): New iterator.
            * config/arm/mve.md (mve_vqdmlashq_n_, mve_vqdmlashq_m_n_s): New
            patterns.

            gcc/testsuite/
            PR target/96914
            * gcc.target/arm/mve/intrinsics/vqdmlashq_m_n_s16.c: New test.
            * gcc.target/arm/mve/intrinsics/vqdmlashq_m_n_s32.c: New test.
            * gcc.target/arm/mve/intrinsics/vqdmlashq_m_n_s8.c: New test.
            * gcc.target/arm/mve/intrinsics/vqdmlashq_n_s16.c: New test.
            * gcc.target/arm/mve/intrinsics/vqdmlashq_n_s32.c: New test.
            * gcc.target/arm/mve/intrinsics/vqdmlashq_n_s8.c: New test.

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (7 preceding siblings ...)
  2020-10-08 11:12 ` cvs-commit at gcc dot gnu.org
@ 2020-10-08 11:13 ` cvs-commit at gcc dot gnu.org
  2020-10-08 14:19 ` cvs-commit at gcc dot gnu.org
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-10-08 11:13 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Christophe Lyon <clyon@gcc.gnu.org>:

https://gcc.gnu.org/g:237f12da4124b91503646b099a8282aa6b251ef9

commit r11-3722-g237f12da4124b91503646b099a8282aa6b251ef9
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date:   Tue Oct 6 07:36:31 2020 +0000

    arm: [MVE] Remove illegal intrinsics (PR target/96914)

    A few MVE intrinsics had an unsigned variant implement while they are
    supported by the hardware.  This patch removes them:
    __arm_vqrdmlashq_n_u8
    __arm_vqrdmlahq_n_u8
    __arm_vqdmlahq_n_u8
    __arm_vqrdmlashq_n_u16
    __arm_vqrdmlahq_n_u16
    __arm_vqdmlahq_n_u16
    __arm_vqrdmlashq_n_u32
    __arm_vqrdmlahq_n_u32
    __arm_vqdmlahq_n_u32
    __arm_vmlaldavaxq_p_u32
    __arm_vmlaldavaxq_p_u16

    2020-10-08  Christophe Lyon  <christophe.lyon@linaro.org>

            gcc/
            PR target/96914
            * config/arm/arm_mve.h (vqrdmlashq_n_u8, vqrdmlashq_n_u16)
            (vqrdmlashq_n_u32, vqrdmlahq_n_u8, vqrdmlahq_n_u16)
            (vqrdmlahq_n_u32, vqdmlahq_n_u8, vqdmlahq_n_u16, vqdmlahq_n_u32)
            (vmlaldavaxq_p_u16, vmlaldavaxq_p_u32): Remove.
            * config/arm/arm_mve_builtins.def (vqrdmlashq_n_u, vqrdmlahq_n_u)
            (vqdmlahq_n_u, vmlaldavaxq_p_u): Remove.
            * config/arm/unspecs.md (VQDMLAHQ_N_U, VQRDMLAHQ_N_U)
            (VQRDMLASHQ_N_U)
            (VMLALDAVAXQ_P_U): Remove unspecs.
            * config/arm/iterators.md (VQDMLAHQ_N_U, VQRDMLAHQ_N_U)
            (VQRDMLASHQ_N_U, VMLALDAVAXQ_P_U): Remove attributes.
            (VQDMLAHQ_N, VQRDMLAHQ_N, VQRDMLASHQ_N, VMLALDAVAXQ_P): Remove
            unsigned variants from iterators.
            * config/arm/mve.md (mve_vqdmlahq_n_<supf><mode>)
            (mve_vqrdmlahq_n_<supf><mode>)
            (mve_vqrdmlashq_n_<supf><mode>, mve_vmlaldavaxq_p_<supf><mode>):
            Update comment.

            gcc/testsuite/
            PR target/96914
            * gcc.target/arm/mve/intrinsics/vmlaldavaxq_p_u16.c: Remove.
            * gcc.target/arm/mve/intrinsics/vmlaldavaxq_p_u32.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqdmlahq_n_u16.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqdmlahq_n_u32.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqdmlahq_n_u8.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlahq_n_u16.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlahq_n_u32.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlahq_n_u8.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlashq_n_u16.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlashq_n_u32.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlashq_n_u8.c: Remove.

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (8 preceding siblings ...)
  2020-10-08 11:13 ` cvs-commit at gcc dot gnu.org
@ 2020-10-08 14:19 ` cvs-commit at gcc dot gnu.org
  2020-10-08 14:20 ` clyon at gcc dot gnu.org
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-10-08 14:19 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Christophe Lyon <clyon@gcc.gnu.org>:

https://gcc.gnu.org/g:5a448362da6133c3b16ffdb0c795b657af7fa5a4

commit r11-3730-g5a448362da6133c3b16ffdb0c795b657af7fa5a4
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date:   Mon Oct 5 09:52:59 2020 +0000

    arm: [MVE] Add missing __arm_vcvtnq_u32_f32 intrinsic (PR 96914)

    __arm_vcvtnq_u32_f32 was missing from arm_mve.h, although the s32_f32 and
    [su]16_f16 versions were present.

    This patch adds the missing version and testcase, which are
    cut-and-paste from the other versions.

    2020-10-08  Christophe Lyon  <christophe.lyon@linaro.org>

            gcc/
            PR target/96914
            * config/arm/arm_mve.h (__arm_vcvtnq_u32_f32): New.

            gcc/testsuite/
            PR target/96914
            * gcc.target/arm/mve/intrinsics/vcvtnq_u32_f32.c: New test.

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (9 preceding siblings ...)
  2020-10-08 14:19 ` cvs-commit at gcc dot gnu.org
@ 2020-10-08 14:20 ` clyon at gcc dot gnu.org
  2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: clyon at gcc dot gnu.org @ 2020-10-08 14:20 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

Christophe Lyon <clyon at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Fixed on trunk

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (10 preceding siblings ...)
  2020-10-08 14:20 ` clyon at gcc dot gnu.org
@ 2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
  2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
  2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
  13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-10-16 12:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by SRINATH PARVATHANENI
<sripar01@gcc.gnu.org>:

https://gcc.gnu.org/g:f5d0b57da1a0529a44da772f4f0b227cd5c50fd5

commit r10-8905-gf5d0b57da1a0529a44da772f4f0b227cd5c50fd5
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date:   Mon Oct 5 13:11:07 2020 +0000

    arm: [MVE[ Add vqdmlashq intrinsics (PR target/96914)

    This patch adds:
    vqdmlashq_m_n_s16
    vqdmlashq_m_n_s32
    vqdmlashq_m_n_s8
    vqdmlashq_n_s16
    vqdmlashq_n_s32
    vqdmlashq_n_s8

    2020-10-08  Christophe Lyon  <christophe.lyon@linaro.org>

            gcc/
            PR target/96914
            * config/arm/arm_mve.h (vqdmlashq, vqdmlashq_m): Define.
            * config/arm/arm_mve_builtins.def (vqdmlashq_n_s)
            (vqdmlashq_m_n_s,): New.
            * config/arm/unspecs.md (VQDMLASHQ_N_S, VQDMLASHQ_M_N_S): New
            unspecs.
            * config/arm/iterators.md (VQDMLASHQ_N_S, VQDMLASHQ_M_N_S): New
            attributes.
            (VQDMLASHQ_N): New iterator.
            * config/arm/mve.md (mve_vqdmlashq_n_, mve_vqdmlashq_m_n_s): New
            patterns.

            gcc/testsuite/
            PR target/96914
            * gcc.target/arm/mve/intrinsics/vqdmlashq_m_n_s16.c: New test.
            * gcc.target/arm/mve/intrinsics/vqdmlashq_m_n_s32.c: New test.
            * gcc.target/arm/mve/intrinsics/vqdmlashq_m_n_s8.c: New test.
            * gcc.target/arm/mve/intrinsics/vqdmlashq_n_s16.c: New test.
            * gcc.target/arm/mve/intrinsics/vqdmlashq_n_s32.c: New test.
            * gcc.target/arm/mve/intrinsics/vqdmlashq_n_s8.c: New test.

    (cherry picked from commit afb198ee3729c29c8e681aedc656f55f4afe4053)

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (11 preceding siblings ...)
  2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
@ 2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
  2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
  13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-10-16 12:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by SRINATH PARVATHANENI
<sripar01@gcc.gnu.org>:

https://gcc.gnu.org/g:c4fb78e5d79b02ae720b2db42fa00e2c8d2d7ed5

commit r10-8906-gc4fb78e5d79b02ae720b2db42fa00e2c8d2d7ed5
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date:   Tue Oct 6 07:36:31 2020 +0000

    arm: [MVE] Remove illegal intrinsics (PR target/96914)

    A few MVE intrinsics had an unsigned variant implement while they are
    supported by the hardware.  This patch removes them:
    __arm_vqrdmlashq_n_u8
    __arm_vqrdmlahq_n_u8
    __arm_vqdmlahq_n_u8
    __arm_vqrdmlashq_n_u16
    __arm_vqrdmlahq_n_u16
    __arm_vqdmlahq_n_u16
    __arm_vqrdmlashq_n_u32
    __arm_vqrdmlahq_n_u32
    __arm_vqdmlahq_n_u32
    __arm_vmlaldavaxq_p_u32
    __arm_vmlaldavaxq_p_u16

    2020-10-08  Christophe Lyon  <christophe.lyon@linaro.org>

            gcc/
            PR target/96914
            * config/arm/arm_mve.h (vqrdmlashq_n_u8, vqrdmlashq_n_u16)
            (vqrdmlashq_n_u32, vqrdmlahq_n_u8, vqrdmlahq_n_u16)
            (vqrdmlahq_n_u32, vqdmlahq_n_u8, vqdmlahq_n_u16, vqdmlahq_n_u32)
            (vmlaldavaxq_p_u16, vmlaldavaxq_p_u32): Remove.
            * config/arm/arm_mve_builtins.def (vqrdmlashq_n_u, vqrdmlahq_n_u)
            (vqdmlahq_n_u, vmlaldavaxq_p_u): Remove.
            * config/arm/unspecs.md (VQDMLAHQ_N_U, VQRDMLAHQ_N_U)
            (VQRDMLASHQ_N_U)
            (VMLALDAVAXQ_P_U): Remove unspecs.
            * config/arm/iterators.md (VQDMLAHQ_N_U, VQRDMLAHQ_N_U)
            (VQRDMLASHQ_N_U, VMLALDAVAXQ_P_U): Remove attributes.
            (VQDMLAHQ_N, VQRDMLAHQ_N, VQRDMLASHQ_N, VMLALDAVAXQ_P): Remove
            unsigned variants from iterators.
            * config/arm/mve.md (mve_vqdmlahq_n_<supf><mode>)
            (mve_vqrdmlahq_n_<supf><mode>)
            (mve_vqrdmlashq_n_<supf><mode>, mve_vmlaldavaxq_p_<supf><mode>):
            Update comment.

            gcc/testsuite/
            PR target/96914
            * gcc.target/arm/mve/intrinsics/vmlaldavaxq_p_u16.c: Remove.
            * gcc.target/arm/mve/intrinsics/vmlaldavaxq_p_u32.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqdmlahq_n_u16.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqdmlahq_n_u32.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqdmlahq_n_u8.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlahq_n_u16.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlahq_n_u32.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlahq_n_u8.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlashq_n_u16.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlashq_n_u32.c: Remove.
            * gcc.target/arm/mve/intrinsics/vqrdmlashq_n_u8.c: Remove.

    (cherry picked from commit 237f12da4124b91503646b099a8282aa6b251ef9)

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/96914] missing MVE intrinsics
  2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
                   ` (12 preceding siblings ...)
  2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
@ 2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
  13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-10-16 12:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96914

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by SRINATH PARVATHANENI
<sripar01@gcc.gnu.org>:

https://gcc.gnu.org/g:7591fc054f40c96fabe05d74d61d1c144798354b

commit r10-8907-g7591fc054f40c96fabe05d74d61d1c144798354b
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date:   Mon Oct 5 09:52:59 2020 +0000

    arm: [MVE] Add missing __arm_vcvtnq_u32_f32 intrinsic (PR 96914)

    __arm_vcvtnq_u32_f32 was missing from arm_mve.h, although the s32_f32 and
    [su]16_f16 versions were present.

    This patch adds the missing version and testcase, which are
    cut-and-paste from the other versions.

    2020-10-08  Christophe Lyon  <christophe.lyon@linaro.org>

            gcc/
            PR target/96914
            * config/arm/arm_mve.h (__arm_vcvtnq_u32_f32): New.

            gcc/testsuite/
            PR target/96914
            * gcc.target/arm/mve/intrinsics/vcvtnq_u32_f32.c: New test.

    (cherry picked from commit 5a448362da6133c3b16ffdb0c795b657af7fa5a4)

^ permalink raw reply	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-10-16 12:35 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03  9:10 [Bug target/96914] New: missing MVE intrinsics clyon at gcc dot gnu.org
2020-09-03  9:10 ` [Bug target/96914] " clyon at gcc dot gnu.org
2020-10-05 12:19 ` clyon at gcc dot gnu.org
2020-10-05 12:33 ` clyon at gcc dot gnu.org
2020-10-05 13:25 ` clyon at gcc dot gnu.org
2020-10-05 14:10 ` clyon at gcc dot gnu.org
2020-10-05 15:24 ` avieira at gcc dot gnu.org
2020-10-06  8:27 ` clyon at gcc dot gnu.org
2020-10-08 11:12 ` cvs-commit at gcc dot gnu.org
2020-10-08 11:13 ` cvs-commit at gcc dot gnu.org
2020-10-08 14:19 ` cvs-commit at gcc dot gnu.org
2020-10-08 14:20 ` clyon at gcc dot gnu.org
2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org
2020-10-16 12:35 ` cvs-commit at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).