[Bug fortran/97061] New: [OpenMP] ICE in in omp_add_variable, at gimplify.c:6955

[Bug fortran/97061] New: [OpenMP] ICE in in omp_add_variable, at gimplify.c:6955

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97061

            Bug ID: 97061
           Summary: [OpenMP] ICE in in omp_add_variable, at
                    gimplify.c:6955
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: openmp
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
  Target Milestone: ---

Found when looking at PR95654 - reduced + modified version of
libgomp.fortran/pr66199-5.f90.

The following ICEs with "gfortran -fopenmp test.f90":

    6 |       u(d1) = 5
      | 
internal compiler error: in omp_add_variable, at gimplify.c:6955
0x671359 omp_add_variable
        ../../repos/gcc/gcc/gimplify.c:6955


integer function f3 (a1, b1)
  integer :: a1, b1, d1
  integer u(0:1023)
  !$omp teams distribute parallel do simd default(none) firstprivate (a1, b1)
shared(u) lastprivate(d1) 
  do d1 = a1, b1-1
      u(d1) = 5
  end do
end

That's the assert:
      /* The only combination of data sharing classes we should see is
         FIRSTPRIVATE and LASTPRIVATE.  However, OpenACC permits
         reduction variables to be used in data sharing clauses.  */
      gcc_assert ((ctx->region_type & ORT_ACC) != 0
                  || ((nflags & GOVD_DATA_SHARE_CLASS)
                      == (GOVD_FIRSTPRIVATE | GOVD_LASTPRIVATE))
                  || (flags & GOVD_DATA_SHARE_CLASS) == 0);

Original dump:
  #pragma omp teams firstprivate(a1) firstprivate(b1) shared(u) default(none)
          #pragma omp distribute lastprivate(d1)
                #pragma omp parallel firstprivate(a1) firstprivate(b1)
lastprivate(d1) shared(u) default(none)
                      #pragma omp for nowait
                            #pragma omp simd linear(d1:1) lastprivate(d1)

[Bug fortran/97061] [OpenMP] ICE in in omp_add_variable, at gimplify.c:6955

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97061

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
If it is the FE that adds the linear clause, then it shouldn't when there is
explicit lastprivate clause.  This is a new thing in OpenMP 5.0, in 4.5 it was
invalid to make the iterate anything but linear in this case, now it can be
made private or lastprivate.

[Bug fortran/97061] [OpenMP] ICE in in omp_add_variable, at gimplify.c:6955

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97061

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
I think I also got this ICE with an additional 'collapse(2)', which might
indicate that a(nother) check is missing.

[Bug fortran/97061] [OpenMP] ICE in in omp_add_variable, at gimplify.c:6955

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97061

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:91347c3bbf788ede4af89f46206991c47fa8aceb

commit r11-3232-g91347c3bbf788ede4af89f46206991c47fa8aceb
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Wed Sep 16 16:23:13 2020 +0200

    Fortran: OpenMP - fix simd with (last)private (PR97061)

    gcc/fortran/ChangeLog:

            PR fortran/97061
            * trans-openmp.c (gfc_trans_omp_do): Handle simd with
(last)private.

    gcc/testsuite/ChangeLog:

            PR fortran/97061
            * gfortran.dg/gomp/openmp-simd-6.f90: New test.

[Bug fortran/97061] [OpenMP] ICE in in omp_add_variable, at gimplify.c:6955

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97061

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
FIXED.