[Bug target/97367] New: powerpc64 g5 and cell optimizations result in .machine power7

[Bug target/97367] New: powerpc64 g5 and cell optimizations result in .machine power7

[rene at exactcode dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

            Bug ID: 97367
           Summary: powerpc64 g5 and cell optimizations result in .machine
                    power7
           Product: gcc
           Version: 10.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rene at exactcode dot de
  Target Milestone: ---

Created attachment 49341
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49341&action=edit
Patch

Since reworking the rs6000 .machine output selection in commit
e154242724b084380e3221df7c08fcdbd8460674 22 May 2019, compiling glibc with
either G5 or cell results in power7 assembly optimizations to be chosen, which
obviously crash with illegal instructions. This is because gcc's .machine
output was accidentally changed due to OPTION_MASK_ALTIVEC only otherwise
present in IBM CPUs since power7.

powerpc64-t2-linux-gnu-gcc  test.c -S -o - -mcpu=G5
        .file   "test.c"
        .machine power7
        .abiversion 2
        .section        ".text"
        .ident  "GCC: (GNU) 10.2.0"
        .section        .note.GNU-stack,"",@progbits

Attached patch fixes this to filter out ALTIVEC just like GFXOPT and GPOPT.

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[mikpelinux at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Mikael Pettersson <mikpelinux at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikpelinux at gmail dot com

--- Comment #1 from Mikael Pettersson <mikpelinux at gmail dot com> ---
Care to submit this to gcc-patches?

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Mikael Pettersson from comment #1)
> Care to submit this to gcc-patches?

Please send it to the mailing list. Patches don't go in bugzilla, thanks.

https://gcc.gnu.org/contribute.html#patches

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2020-Decembe
                   |                            |r/560994.html
             Target|powerpc                     |powerpc*-*-*

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Ah yes, it was sent to the ML:
https://gcc.gnu.org/pipermail/gcc-patches/2020-December/560994.html

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Rebased patch:
https://svn.exactcode.de/t2/trunk/package/develop/gcc/g5-cell-not-power7.patch

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[rene at exactcode dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #5 from René Rebe <rene at exactcode dot de> ---
latest version:
https://svn.exactcode.de/t2/trunk/package/develop/gcc/hotfix-g5-power4.patch

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sjames at gcc dot gnu.org

--- Comment #6 from Sam James <sjames at gcc dot gnu.org> ---
Please send it to the ML with git-send-email.

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |linkw at gcc dot gnu.org

--- Comment #7 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Sam James from comment #6)
> Please send it to the ML with git-send-email.

...and CC our port maintainers, Segher, Ke Wen and David who are all on CC
here.