[Bug libstdc++/97570] New: avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[Bug libstdc++/97570] New: avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[matwey.kornilov at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

            Bug ID: 97570
           Summary: avr-gcc: error: 'void* memalign' redeclared as
                    different kind of entity
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: matwey.kornilov at gmail dot com
  Target Milestone: ---

Hi,

While I am trying to build avr-gcc from master with Freestanding C++ standard
library on x86_64 host system, I see the following compile error:


../../../../libstdc++-v3/libsupc++/new_opa.cc:56:18: error: 'void* memalign'
redeclared as different kind of entity
   56 |   void *memalign(size_t alignment, size_t size);
      |                  ^~~~~~
../../../../libstdc++-v3/libsupc++/new_opa.cc:39:18: note: previous declaration
'void* memalign(std::size_t, std::size_t)'
   39 | extern "C" void *memalign(std::size_t boundary, std::size_t size);
      |                  ^~~~~~~~
../../../../libstdc++-v3/libsupc++/new_opa.cc:56:18: error: 'size_t' was not
declared in this scope; did you mean 'std::size_t'?
   56 |   void *memalign(size_t alignment, size_t size);
      |                  ^~~~~~
      |                  std::size_t
In file included from ../../../../libstdc++-v3/libsupc++/new_opa.cc:26:
/usr/src/gcc/avr-obj/avr/libstdc++-v3/include/avr/bits/c++config.h:280:33:
note: 'std::size_t' declared here
  280 |   typedef __SIZE_TYPE__         size_t;
      |                                 ^~~~~~
../../../../libstdc++-v3/libsupc++/new_opa.cc:56:36: error: 'size_t' was not
declared in this scope; did you mean 'std::size_t'?
   56 |   void *memalign(size_t alignment, size_t size);
      |                                    ^~~~~~
      |                                    std::size_t
In file included from ../../../../libstdc++-v3/libsupc++/new_opa.cc:26:
/usr/src/gcc/avr-obj/avr/libstdc++-v3/include/avr/bits/c++config.h:280:33:
note: 'std::size_t' declared here
  280 |   typedef __SIZE_TYPE__         size_t;
      |                                 ^~~~~~


I use binutils 2.35 and gcc 47d13acbda9a5d8eb57ff169ba74857cd54108e4


Steps to reproduce:

1. Build and install gcc without libstdc++:

# ../configure --prefix=/usr --target=avr --enable-languages=c,c++
--disable-nls --disable-libssp --with-dwarf2
# make
# make install

2. Build and install avr-libc 2.0

# ../configure --prefix=/usr --build=`../config.guess` --host=avr
# make
# make install

3. Rebuild gcc with Freestanding libstdc++

# ../configure --prefix=/usr --target=avr --enable-languages=c,c++
--disable-nls --disable-libssp --with-dwarf2 --with-newlib
--disable-__cxa_atexit --disable-threads --disable-shared --enable-static
--disable-sjlj-exceptions --enable-libstdcxx --enable-lto
--disable-hosted-libstdcxx
# make

See the error.


The following simple patch fixes the issue:

--- a/libstdc++-v3/libsupc++/new_opa.cc
+++ b/libstdc++-v3/libsupc++/new_opa.cc
@@ -53,7 +53,7 @@ extern "C"
 # elif _GLIBCXX_HAVE_POSIX_MEMALIGN
   void *posix_memalign(void **, size_t alignment, size_t size);
 # elif _GLIBCXX_HAVE_MEMALIGN
-  void *memalign(size_t alignment, size_t size);
+  void *memalign(std::size_t alignment, std::size_t size);
 # endif
 }
 #endif

Then gcc and libstdc++ are compiled and installed successfully without any
further errors. But I doubt that this is correct way to handle this issue.

[Bug libstdc++/97570] avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2020-10-26

[Bug libstdc++/97570] avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:93e9a7bcd5434a24c945de33cd7fa01a25f68418

commit r11-4383-g93e9a7bcd5434a24c945de33cd7fa01a25f68418
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Oct 26 12:02:50 2020 +0000

    libstdc++: Fix declarations of memalign etc. for freestanding [PR 97570]

    libstdc++-v3/ChangeLog:

            PR libstdc++/97570
            * libsupc++/new_opa.cc: Declare size_t in global namespace.
            Remove unused header.

[Bug libstdc++/97570] avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Thanks for the report. It's fixed on the development trunk now, but I will also
backport it to the release branches.

[Bug libstdc++/97570] avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Matwey V. Kornilov from comment #0)
> Then gcc and libstdc++ are compiled and installed successfully without any
> further errors.

P.S. this is great news. I've been meaning to check this myself for some time,
as I'd like libstdc++ to be usable (where appropriate) for Arduino projects.

[Bug libstdc++/97570] avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:67e95b6908b842e437089e867e5eed6dbbe264f2

commit r10-9715-g67e95b6908b842e437089e867e5eed6dbbe264f2
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Oct 26 12:02:50 2020 +0000

    libstdc++: Fix declarations of memalign etc. for freestanding [PR 97570]

    libstdc++-v3/ChangeLog:

            PR libstdc++/97570
            * libsupc++/new_opa.cc: Declare size_t in global namespace.
            Remove unused header.

    (cherry picked from commit 93e9a7bcd5434a24c945de33cd7fa01a25f68418)

[Bug libstdc++/97570] avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:9a7ad8ff80dd5bb3ab178588f0ec92aea5251121

commit r9-9360-g9a7ad8ff80dd5bb3ab178588f0ec92aea5251121
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Oct 26 12:02:50 2020 +0000

    libstdc++: Fix declarations of memalign etc. for freestanding [PR 97570]

    libstdc++-v3/ChangeLog:

            PR libstdc++/97570
            * libsupc++/new_opa.cc: Declare size_t in global namespace.
            Remove unused header.

    (cherry picked from commit 93e9a7bcd5434a24c945de33cd7fa01a25f68418)

[Bug libstdc++/97570] avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:9f6c858f76983cbc76d447a06ebce43d98a1fcd2

commit r8-10850-g9f6c858f76983cbc76d447a06ebce43d98a1fcd2
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Oct 26 12:02:50 2020 +0000

    libstdc++: Fix declarations of memalign etc. for freestanding [PR 97570]

    libstdc++-v3/ChangeLog:

            PR libstdc++/97570
            * libsupc++/new_opa.cc: Declare size_t in global namespace.
            Remove unused header.

    (cherry picked from commit 93e9a7bcd5434a24c945de33cd7fa01a25f68418)

[Bug libstdc++/97570] avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 8.5, 9.4 and 10.4

[Bug libstdc++/97570] avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|redi at gcc dot gnu.org            |unassigned at gcc dot gnu.org
             Status|ASSIGNED                    |NEW

[Bug libstdc++/97570] avr-gcc: error: 'void* memalign' redeclared as different kind of entity

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97570

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |8.5
         Resolution|---                         |FIXED

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
.