public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/97587] [coroutines] promise_type constructor is called with original parameters, not parameter copies
Date: Thu, 25 Feb 2021 19:34:34 +0000	[thread overview]
Message-ID: <bug-97587-4-6Com0CrnkU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97587-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97587

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:b8ff3f8efeda02a6bedebfaf20b93645ae3bb5b8

commit r11-7403-gb8ff3f8efeda02a6bedebfaf20b93645ae3bb5b8
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Mon Feb 15 16:13:36 2021 +0000

    coroutines : Call promise CTOR with parm copies [PR97587].

    As the PR notes, we were calling the promise CTOR with the original
    function parameters, not the copy (as pointed, a previous wording of
    the section was unambiguous).  Fixed thus.

    gcc/cp/ChangeLog:

            PR c++/97587
            * coroutines.cc (struct param_info): Track rvalue refs.
            (morph_fn_to_coro): Track rvalue refs, and call the promise
            CTOR with the frame copy of passed parms.

    gcc/testsuite/ChangeLog:

            PR c++/97587
            * g++.dg/coroutines/coro1-refs-and-ctors.h: Add a CTOR with two
            reference parms, to distinguish the rvalue ref. variant.
            * g++.dg/coroutines/pr97587.C: New test.

  parent reply	other threads:[~2021-02-25 19:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27  5:35 [Bug c++/97587] New: " jehelset at gmail dot com
2021-02-16  8:47 ` [Bug c++/97587] " iains at gcc dot gnu.org
2021-02-25 19:34 ` cvs-commit at gcc dot gnu.org [this message]
2021-03-22 22:03 ` cvs-commit at gcc dot gnu.org
2021-03-24 12:45 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97587-4-6Com0CrnkU@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).