[Bug ada/97805] New: adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[Bug ada/97805] New: adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

            Bug ID: 97805
           Summary: adaint.c:1488:12: note: 'LLONG_MIN' is defined in
                    header '<cli mits>'; did you forget to '#include
                    <climits>'?
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: danglin at gcc dot gnu.org
  Target Milestone: ---
              Host: hppa2.0w-hp-hpux11.11
            Target: hppa2.0w-hp-hpux11.11
             Build: hppa2.0w-hp-hpux11.11

g++ -std=c++11  -fno-PIE -c  -DIN_GCC_FRONTEND -g -DIN_GCC     -fno-exceptions
-
fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-W
cast-qual -Wno-format -mdisable-indexing -Wmissing-format-attribute
-Woverloaded
-virtual -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings
-fno-common
  -DHAVE_CONFIG_H -I. -Iada -I../../gcc/gcc -I../../gcc/gcc/ada
-I../../gcc/gcc/
../include -I../../gcc/gcc/../libcpp/include -I/opt/gnu/gcc/gmp/include 
-I../..
/gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber
-
I../../gcc/gcc/../libbacktrace   -o ada/argv.o -MT ada/argv.o -MMD -MP -MF
ada/.
deps/argv.TPo ../../gcc/gcc/ada/argv.c
../../gcc/gcc/ada/adaint.c: In function 'long long int
__gnat_file_time(char*)':
../../gcc/gcc/ada/adaint.c:1488:12: error: 'LLONG_MIN' was not declared in this
scope
     return LLONG_MIN;
            ^~~~~~~~~
../../gcc/gcc/ada/adaint.c:1488:12: note: 'LLONG_MIN' is defined in header
'<cli
mits>'; did you forget to '#include <climits>'?
../../gcc/gcc/ada/adaint.c:239:1:
+#include <climits>

[Bug ada/97805] [11 Regression] adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2020-11-13
                 CC|                            |ebotcazou at gcc dot gnu.org
     Ever confirmed|0                           |1
   Target Milestone|---                         |11.0

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Obviously.

[Bug ada/97805] [11 Regression] adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Created attachment 49555
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49555&action=edit
Tentative fix

Please give it a try when you get a chance.

[Bug ada/97805] [11 Regression] adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

--- Comment #3 from dave.anglin at bell dot net ---
On 2020-11-13 7:39 a.m., ebotcazou at gcc dot gnu.org wrote:
> Please give it a try when you get a chance.
Will do.

Thanks,
Dave

[Bug ada/97805] [11 Regression] adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

--- Comment #4 from John David Anglin <danglin at gcc dot gnu.org> ---
We need:

#include <climits>

The define for LLONG_MIN is guarded by __STDC_VERSION__ in glimits.h:

#if defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
/* Minimum and maximum values a `signed long long int' can hold.  */
# undef LLONG_MIN
# define LLONG_MIN (-LLONG_MAX - 1LL)
# undef LLONG_MAX
# define LLONG_MAX __LONG_LONG_MAX__

/* Maximum value an `unsigned long long int' can hold.  (Minimum is 0).  */
# undef ULLONG_MAX
# define ULLONG_MAX (LLONG_MAX * 2ULL + 1ULL)
#endif

-std=c++11 doesn't appear to define __STDC_VERSION__.

[Bug ada/97805] [11 Regression] adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

--- Comment #5 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> We need:
> 
> #include <climits>

We cannot do that unconditionally because it's also compiled as a C file.

[Bug ada/97805] [11 Regression] adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49555|0                           |1
        is obsolete|                            |

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Created attachment 49574
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49574&action=edit
Tentative fix #2

Second try.

[Bug ada/97805] [11 Regression] adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

--- Comment #7 from John David Anglin <danglin at gcc dot gnu.org> ---
Fix #2 works for me.

But then we hit:

/test/gnu/gcc/objdir/./gcc/xgcc -B/test/gnu/gcc/objdir/./gcc/
-B/opt/gnu/gcc/gcc
-11/hppa2.0w-hp-hpux11.11/bin/ -B/opt/gnu/gcc/gcc-11/hppa2.0w-hp-hpux11.11/lib/
-isystem /opt/gnu/gcc/gcc-11/hppa2.0w-hp-hpux11.11/include -isystem
/opt/gnu/gcc
/gcc-11/hppa2.0w-hp-hpux11.11/sys-include   -fchecking=1 -c -g -O2  -fPIC  -W
-W
all -gnatpg -nostdinc   a-nallfl.ads -o a-nallfl.o
a-nallfl.ads:48:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:48:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:48:13: warning: profile of "Sin" doesn't match the builtin it
binds
a-nallfl.ads:51:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:51:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:51:13: warning: profile of "Cos" doesn't match the builtin it
binds
a-nallfl.ads:54:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:54:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:54:13: warning: profile of "Tan" doesn't match the builtin it
binds
a-nallfl.ads:57:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:57:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:57:13: warning: profile of "Exp" doesn't match the builtin it
binds
a-nallfl.ads:60:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:60:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:60:13: warning: profile of "Sqrt" doesn't match the builtin it
binds
a-nallfl.ads:63:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:63:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:63:13: warning: profile of "Log" doesn't match the builtin it
binds
a-nallfl.ads:66:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:66:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:66:13: warning: profile of "Acos" doesn't match the builtin it
binds
a-nallfl.ads:69:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:69:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:69:13: warning: profile of "Asin" doesn't match the builtin it
binds
a-nallfl.ads:72:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:72:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:72:13: warning: profile of "Atan" doesn't match the builtin it
binds
a-nallfl.ads:75:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:75:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:75:13: warning: profile of "Sinh" doesn't match the builtin it
binds
a-nallfl.ads:78:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:78:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:78:13: warning: profile of "Cosh" doesn't match the builtin it
binds
a-nallfl.ads:81:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:81:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:81:13: warning: profile of "Tanh" doesn't match the builtin it
binds
a-nallfl.ads:84:13: warning: intrinsic binding type mismatch on return value
a-nallfl.ads:84:13: warning: intrinsic binding type mismatch on argument 1
a-nallfl.ads:84:13: warning: profile of "Pow" doesn't match the builtin it
binds
make[7]: *** [../gcc-interface/Makefile:302: a-nallfl.o] Error 1
make[7]: Leaving directory '/test/gnu/gcc/objdir/gcc/ada/rts'
make[6]: *** [gcc-interface/Makefile:620: gnatlib] Error 2

Probably, should be new PR.

[Bug ada/97805] [11 Regression] adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

--- Comment #8 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> Fix #2 works for me.

OK, thanks.

> Probably, should be new PR.

Nope, it's PR ada/97504, please follow up there.

[Bug ada/97805] [11 Regression] adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Eric Botcazou <ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:2729378d0905a04e476a8bdcaaf0288f417810ec

commit r11-5170-g2729378d0905a04e476a8bdcaaf0288f417810ec
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Thu Nov 19 16:39:34 2020 +0100

    Fix PR ada/97805

    We need to include limits.h (or <climits>) in adaint.c because of
LLONG_MIN.

    gcc/ada/ChangeLog:
            PR ada/97805
            * adaint.c: Include climits in C++ and limits.h otherwise.

[Bug ada/97805] [11 Regression] adaint.c:1488:12: note: 'LLONG_MIN' is defined in header '<cli mits>'; did you forget to '#include <climits>'?

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97805

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #10 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Thanks for reporting the problem.