public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/97832] AoSoA complex caxpy-like loops: AVX2+FMA -Ofast 7 times slower than -O3 Date: Tue, 17 Nov 2020 10:18:09 +0000 [thread overview] Message-ID: <bug-97832-4-d5v4q986yG@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-97832-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97832 --- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> --- OK, so I have a patch to keep the association linear which IMHO is good. It fixes the smaller and my testcase but not the original one which now is linear but still not homogenous. The store groups are as follows *_115 = (((((*_115) - (f00_re_68 * x0_re_108)) - (f10_re_70 * x1_re_140)) - (f00_im_73 * x0_im_114)) - (f10_im_74 * x1_im_142)); *_117 = (((((*_117) + (f00_im_73 * x0_re_108)) + (f10_im_74 * x1_re_140)) - (f00_re_68 * x0_im_114)) - (f10_re_70 * x1_im_142)); *_119 = (((((*_119) - (f01_re_71 * x0_re_108)) - (f11_re_72 * x1_re_140)) - (f01_im_75 * x0_im_114)) - (f11_im_76 * x1_im_142)); *_121 = (((((*_121) + (f01_im_75 * x0_re_108)) + (f11_im_76 * x1_re_140)) - (f01_re_71 * x0_im_114)) - (f11_re_72 * x1_im_142)); (good) *_177 = (((((*_177) - (f00_re_68 * x0_re_170)) - (f00_im_73 * x0_im_176)) - (f10_re_70 * x1_re_202)) - (f10_im_74 * x1_im_204)); *_179 = (((((f00_im_73 * x0_re_170) + (f10_im_74 * x1_re_202)) + (*_179)) - (f00_re_68 * x0_im_176)) - (f10_re_70 * x1_im_204)); *_181 = (((((*_181) - (f01_re_71 * x0_re_170)) - (f01_im_75 * x0_im_176)) - (f11_re_72 * x1_re_202)) - (f11_im_76 * x1_im_204)); *_183 = (((((f01_im_75 * x0_re_170) + (f11_im_76 * x1_re_202)) + (*_183)) - (f01_re_71 * x0_im_176)) - (f11_re_72 * x1_im_204)); already bad. Now, this is sth to tackle in the vectorizer which ideally should not try to match up individual adds during SLP discoverly but instead (if association is allowed) the whole addition chain, commutating within the whole change rather than just swapping individual add operands. I still think the reassoc change I came up with is good since it avoids the need to linearlize in the vectorizer. So testing that now.
next prev parent reply other threads:[~2020-11-17 10:18 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-14 20:44 [Bug target/97832] New: " already5chosen at yahoo dot com 2020-11-16 7:21 ` [Bug target/97832] " rguenth at gcc dot gnu.org 2020-11-16 11:11 ` rguenth at gcc dot gnu.org 2020-11-16 20:11 ` already5chosen at yahoo dot com 2020-11-17 9:21 ` [Bug tree-optimization/97832] " rguenth at gcc dot gnu.org 2020-11-17 10:18 ` rguenth at gcc dot gnu.org [this message] 2020-11-18 8:53 ` rguenth at gcc dot gnu.org 2020-11-18 9:15 ` rguenth at gcc dot gnu.org 2020-11-18 13:23 ` rguenth at gcc dot gnu.org 2020-11-18 13:39 ` rguenth at gcc dot gnu.org 2020-11-19 19:55 ` already5chosen at yahoo dot com 2020-11-20 7:10 ` rguenth at gcc dot gnu.org 2021-06-09 12:41 ` cvs-commit at gcc dot gnu.org 2021-06-09 12:54 ` rguenth at gcc dot gnu.org 2022-01-21 0:16 ` pinskia at gcc dot gnu.org 2022-11-24 23:22 ` already5chosen at yahoo dot com 2022-11-25 8:16 ` rguenth at gcc dot gnu.org 2022-11-25 13:19 ` already5chosen at yahoo dot com 2022-11-25 20:46 ` rguenth at gcc dot gnu.org 2022-11-25 21:27 ` amonakov at gcc dot gnu.org 2022-11-26 18:27 ` already5chosen at yahoo dot com 2022-11-26 18:36 ` already5chosen at yahoo dot com 2022-11-26 19:36 ` amonakov at gcc dot gnu.org 2022-11-26 22:00 ` already5chosen at yahoo dot com 2022-11-28 6:29 ` crazylht at gmail dot com 2022-11-28 6:42 ` crazylht at gmail dot com 2022-11-28 7:21 ` rguenther at suse dot de 2022-11-28 7:24 ` crazylht at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-97832-4-d5v4q986yG@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).