* [Bug target/97926] ICE in patch_jump_insn, at cfgrtl.c:1298
2020-11-20 7:23 [Bug target/97926] New: ICE in patch_jump_insn, at cfgrtl.c:1298 marxin at gcc dot gnu.org
@ 2020-11-20 7:23 ` marxin at gcc dot gnu.org
2020-11-20 21:07 ` segher at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-11-20 7:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97926
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Target Milestone|--- |11.0
Status|UNCONFIRMED |NEW
Last reconfirmed| |2020-11-20
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/97926] ICE in patch_jump_insn, at cfgrtl.c:1298
2020-11-20 7:23 [Bug target/97926] New: ICE in patch_jump_insn, at cfgrtl.c:1298 marxin at gcc dot gnu.org
2020-11-20 7:23 ` [Bug target/97926] " marxin at gcc dot gnu.org
@ 2020-11-20 21:07 ` segher at gcc dot gnu.org
2021-03-17 1:36 ` acsawdey at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2020-11-20 21:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97926
--- Comment #1 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Confirmed (needs -O0).
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/97926] ICE in patch_jump_insn, at cfgrtl.c:1298
2020-11-20 7:23 [Bug target/97926] New: ICE in patch_jump_insn, at cfgrtl.c:1298 marxin at gcc dot gnu.org
2020-11-20 7:23 ` [Bug target/97926] " marxin at gcc dot gnu.org
2020-11-20 21:07 ` segher at gcc dot gnu.org
@ 2021-03-17 1:36 ` acsawdey at gcc dot gnu.org
2021-03-18 18:11 ` acsawdey at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: acsawdey at gcc dot gnu.org @ 2021-03-17 1:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97926
--- Comment #2 from acsawdey at gcc dot gnu.org ---
patch_jump_insn() is running into a land mine -- the insn before modification
is invalid:
(gdb) p insn_invalid_p(insn, true)
$4 = 1
(gdb) pr insn
(jump_insn 18 17 114 6 (set (pc)
(if_then_else (unle (reg:CCFP 131)
(const_int 0 [0]))
(label_ref 21)
(pc)))
"../../gcc/gcc/testsuite/c-c++-common/ubsan/float-cast-overflow-11.c":9:10 -1
(nil)
-> 21)
So verify_changes() fails because the same insn with a different label_ref
inserted is also invalid.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/97926] ICE in patch_jump_insn, at cfgrtl.c:1298
2020-11-20 7:23 [Bug target/97926] New: ICE in patch_jump_insn, at cfgrtl.c:1298 marxin at gcc dot gnu.org
` (2 preceding siblings ...)
2021-03-17 1:36 ` acsawdey at gcc dot gnu.org
@ 2021-03-18 18:11 ` acsawdey at gcc dot gnu.org
2021-03-19 12:06 ` segher at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: acsawdey at gcc dot gnu.org @ 2021-03-18 18:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97926
--- Comment #3 from acsawdey at gcc dot gnu.org ---
So the underlying problem here is that the unordered comparisons are not
allowed with -ffinite-math-only due to this predicate:
;; Return 1 if OP is a comparison operation that is valid for a branch
;; instruction. We check the opcode against the mode of the CC value.
;; validate_condition_mode is an assertion.
(define_predicate "branch_comparison_operator"
(and (match_operand 0 "comparison_operator")
(match_test "GET_MODE_CLASS (GET_MODE (XEXP (op, 0))) == MODE_CC")
(if_then_else (match_test "GET_MODE (XEXP (op, 0)) == CCFPmode")
(if_then_else (match_test "flag_finite_math_only")
(match_code "lt,le,gt,ge,eq,ne,unordered,ordered")
(match_code "lt,gt,eq,unordered,unge,unle,ne,ordered"))
(match_code "lt,ltu,le,leu,gt,gtu,ge,geu,eq,ne"))
(match_test "validate_condition_mode (GET_CODE (op),
GET_MODE (XEXP (op, 0))),
1")))
But ubsan_instrument_float_cast() generates this:
t = fold_build2 (UNLE_EXPR, boolean_type_node, expr, min);
tt = fold_build2 (UNGE_EXPR, boolean_type_node, expr, max);
which eventually leads to the ICE. Even if this branch wasn't rewritten by
patch_dump_insn() it would not be recognized and would eventually ICE.
Segher is working on a change to that predicate for PR98092 though which may be
a workaround fix for this.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/97926] ICE in patch_jump_insn, at cfgrtl.c:1298
2020-11-20 7:23 [Bug target/97926] New: ICE in patch_jump_insn, at cfgrtl.c:1298 marxin at gcc dot gnu.org
` (3 preceding siblings ...)
2021-03-18 18:11 ` acsawdey at gcc dot gnu.org
@ 2021-03-19 12:06 ` segher at gcc dot gnu.org
2021-03-19 12:14 ` segher at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2021-03-19 12:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97926
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|acsawdey at gcc dot gnu.org |segher at gcc dot gnu.org
--- Comment #4 from Segher Boessenkool <segher at gcc dot gnu.org> ---
That is not where the UNGE and UNLE come from. I have no idea where they
*do* come from though :-/
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/97926] ICE in patch_jump_insn, at cfgrtl.c:1298
2020-11-20 7:23 [Bug target/97926] New: ICE in patch_jump_insn, at cfgrtl.c:1298 marxin at gcc dot gnu.org
` (4 preceding siblings ...)
2021-03-19 12:06 ` segher at gcc dot gnu.org
@ 2021-03-19 12:14 ` segher at gcc dot gnu.org
2021-03-22 16:34 ` cvs-commit at gcc dot gnu.org
2021-03-22 16:36 ` [Bug testsuite/97926] " segher at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2021-03-19 12:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97926
--- Comment #5 from Segher Boessenkool <segher at gcc dot gnu.org> ---
It helps if you test the compiler you just built, not something old. Sigh.
Patch is testing.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/97926] ICE in patch_jump_insn, at cfgrtl.c:1298
2020-11-20 7:23 [Bug target/97926] New: ICE in patch_jump_insn, at cfgrtl.c:1298 marxin at gcc dot gnu.org
` (5 preceding siblings ...)
2021-03-19 12:14 ` segher at gcc dot gnu.org
@ 2021-03-22 16:34 ` cvs-commit at gcc dot gnu.org
2021-03-22 16:36 ` [Bug testsuite/97926] " segher at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-03-22 16:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97926
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Segher Boessenkool <segher@gcc.gnu.org>:
https://gcc.gnu.org/g:ba16797fe69a0fae47355aa2c102ffac1c48c3bd
commit r11-7767-gba16797fe69a0fae47355aa2c102ffac1c48c3bd
Author: Segher Boessenkool <segher@kernel.crashing.org>
Date: Fri Mar 19 15:02:00 2021 +0000
ubsan: Don't test for NaNs if those do not exist (PR97926)
2021-03-22 Segher Boessenkool <segher@kernel.crashing.org>
PR target/97926
* ubsan.c (ubsan_instrument_float_cast): Don't test for unordered
if
there are no NaNs.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug testsuite/97926] ICE in patch_jump_insn, at cfgrtl.c:1298
2020-11-20 7:23 [Bug target/97926] New: ICE in patch_jump_insn, at cfgrtl.c:1298 marxin at gcc dot gnu.org
` (6 preceding siblings ...)
2021-03-22 16:34 ` cvs-commit at gcc dot gnu.org
@ 2021-03-22 16:36 ` segher at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: segher at gcc dot gnu.org @ 2021-03-22 16:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97926
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|target |testsuite
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 9+ messages in thread