[Bug c/98209] New: printf failed with O1 or above

[Bug c/98209] New: printf failed with O1 or above

[jamesgua at ca dot ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

            Bug ID: 98209
           Summary: printf failed with O1 or above
           Product: gcc
           Version: 9.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jamesgua at ca dot ibm.com
  Target Milestone: ---

Testing file:

#include <stdio.h>

int main(int argc, char** argv) __attribute__ ((__target__ ("no-sse,no-mmx"))); 
int main(int argc, char** argv)
{
        printf("hello!\n");
        return 0;
} 

cmd to compile: gcc -O3 -c test.c
On Ubuntu 20.04 (gcc version 9.3.0 (Ubuntu 9.3.0-17ubuntu1~20.04)) it failed
with "inlining failed in call to always_inline printf’: target specific option
mismatch" but it works on Ubuntu 16.04 (gcc version 5.4.0 20160609 (Ubuntu
5.4.0-6ubuntu1~16.04.12))

If not supported pls let me know.

[Bug c/98209] printf failed with O1 or above

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Can you provide the preprocessed source?

[Bug c/98209] printf failed with O1 or above

[jamesgua at ca dot ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

--- Comment #2 from jamesgua at ca dot ibm.com ---
Created attachment 49709
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49709&action=edit
preprocessed src file gcc -E

[Bug c/98209] printf failed with O1 or above

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |WAITING
                 CC|                            |marxin at gcc dot gnu.org
   Last reconfirmed|                            |2020-12-09

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
I can't reproduce that. Can you please paste full command line and the error
message?

[Bug c/98209] printf failed with O1 or above

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
      Known to fail|                            |10.2.0, 9.3.0

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

> /space/rguenther/install/gcc-9.3/bin/gcc t.c -D_FORTIFY_SOURCE=2 -O
In file included from /usr/include/stdio.h:862,
                 from t.c:1:
t.c: In function ?main?:
/usr/include/bits/stdio2.h:102:1: error: inlining failed in call to
always_inline ?printf?: target specific option mismatch
  102 | printf (const char *__restrict __fmt, ...)
      | ^~~~~~
t.c:6:4: note: called from here
    6 |    printf("hello!\n");
      |    ^~~~~~~~~~~~~~~~~~

fortify wrappers are always-inline and inherit default target opts.

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |8.5
          Component|c                           |middle-end
      Known to fail|                            |8.1.0, 8.4.0
            Summary|printf failed with O1 or    |[8/9/10/11 Regression]
                   |above                       |printf failed with O1 or
                   |                            |above
      Known to work|                            |7.5.0

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
IIRC we excempted always-inline from all the option related restrictions, did
we
[intend to]?

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r8-2658-g9b25e12d2d940a61.

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

--- Comment #7 from rguenther at suse dot de <rguenther at suse dot de> ---
On Wed, 9 Dec 2020, marxin at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209
> 
> --- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
> Started with r8-2658-g9b25e12d2d940a61.

Yeah, but the point is the middle-end shouldn't even ask the target
for always_inlines?  I don't see how we can easily do better than
that from a QOI perspective.

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[jamesgua at ca dot ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

--- Comment #8 from jamesgua at ca dot ibm.com ---
one more function found the same issue:
memcpy
I guess more functions in libc might have same issue.

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
             Target|                            |x86_64-*-* i?86-*-*

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
But e.g. for the *intrin.h intrinsics, ignoring the ISA requirements that it
got from the target pragmas is highly undesirable, we do need the diagnostics
and refuse to inline them, otherwise they will ICE all over.
And it is unclear how to differentiate between ISA requirements that were added
because of the command line option flags vs. ISA requirements that got added
through target pragmas or target attributes.

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

--- Comment #10 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 28 Jan 2021, jakub at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209
> 
> Jakub Jelinek <jakub at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |jakub at gcc dot gnu.org
> 
> --- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
> But e.g. for the *intrin.h intrinsics, ignoring the ISA requirements that it
> got from the target pragmas is highly undesirable, we do need the diagnostics
> and refuse to inline them, otherwise they will ICE all over.
> And it is unclear how to differentiate between ISA requirements that were added
> because of the command line option flags vs. ISA requirements that got added
> through target pragmas or target attributes.

For select cases we have sth like cfun->uses_math and chose to ignore
some (target specific) settings based on things we use in the IL.  We
could go much further here (but of course _not_ scan the IL in the
respective function - we'd have to pre-compute things somehow, like
adding target specific fields in the inline summary / merging and
when computing that, allow the target to amend).

I think the *intrin.h example is not really relevant as their direct
caller is very unlikely to differ in setting.

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to rguenther@suse.de from comment #10)
> I think the *intrin.h example is not really relevant as their direct
> caller is very unlikely to differ in setting.

In bugfree code sure.
When writing code, because there are so many ISA extensions it is often the
case one attempts to use an intrinsic that requires other ISA flags, and rely
on the compiler to diagnose that.
So, if we e.g. wanted to redeclare always_inline as being inlinable to anything
regardless of target and optimize flags, we'd need to add another attribute and
stick it on all the intrinsic that would say but for these require it.
But, even for the _FORTIFY_SOURCE inlines, I'm not really sure we e.g. want to
inline them into -O0 functions, because fortification relies on -O1+.

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:72982851d70dfbc547d83ed2bb45356b9ebe3ff0

commit r11-7825-g72982851d70dfbc547d83ed2bb45356b9ebe3ff0
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Mar 23 20:04:58 2021 -0700

    x86: Skip ISA check for always_inline in system headers

    For always_inline in system headers, we don't know if caller's ISAs are
    compatible with callee's ISAs until much later.  Skip ISA check for
    always_inline in system headers if caller has target attribute.

    gcc/

            PR target/98209
            PR target/99744
            * config/i386/i386.c (ix86_can_inline_p): Don't check ISA for
            always_inline in system headers.

    gcc/testsuite/

            PR target/98209
            PR target/99744
            * gcc.target/i386/pr98209.c: New test.
            * gcc.target/i386/pr99744-1.c: Likewise.
            * gcc.target/i386/pr99744-2.c: Likewise.

[Bug middle-end/98209] [8/9/10/11 Regression] printf failed with O1 or above

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.5                         |11.0

--- Comment #13 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for GCC 11 so far.

[Bug middle-end/98209] [8/9/10 Regression] printf failed with O1 or above

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[8/9/10/11 Regression]      |[8/9/10 Regression] printf
                   |printf failed with O1 or    |failed with O1 or above
                   |above                       |
   Target Milestone|11.0                        |8.5
      Known to work|                            |11.0

[Bug middle-end/98209] [8/9/10 Regression] printf failed with O1 or above

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

--- Comment #14 from H.J. Lu <hjl.tools at gmail dot com> ---
The fix was reverted by

commit de00a7bda94910835012bc7150be53b460a5c8b6
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Mar 25 06:57:37 2021 -0700

    Revert "x86: Skip ISA check for always_inline in system headers"

    This reverts commit 72982851d70dfbc547d83ed2bb45356b9ebe3ff0.

[Bug middle-end/98209] [9/10 Regression] printf failed with O1 or above

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.5                         |9.4

--- Comment #15 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 branch is being closed.

[Bug middle-end/98209] [9/10 Regression] printf failed with O1 or above

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #16 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug middle-end/98209] [10 Regression] printf failed with O1 or above

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #17 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug middle-end/98209] [10 Regression] printf failed with O1 or above

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #18 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug middle-end/98209] [11/12/13/14 Regression] printf failed with O1 or above

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98209

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[10 Regression] printf      |[11/12/13/14 Regression]
                   |failed with O1 or above     |printf failed with O1 or
                   |                            |above
   Last reconfirmed|2020-12-09 00:00:00         |2023-7-7
   Target Milestone|10.5                        |11.5
      Known to fail|                            |14.0
      Known to work|11.0                        |
           Keywords|                            |rejects-valid

--- Comment #19 from Richard Biener <rguenth at gcc dot gnu.org> ---
Re-confirmed as failing everywhere.