* [Bug libfortran/98301] random_init() may be non-conforming
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
@ 2020-12-15 20:17 ` kargl at gcc dot gnu.org
2020-12-15 20:17 ` kargl at gcc dot gnu.org
` (14 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: kargl at gcc dot gnu.org @ 2020-12-15 20:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
--- Comment #1 from kargl at gcc dot gnu.org ---
Created attachment 49770
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49770&action=edit
random_init() patch
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() may be non-conforming
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
2020-12-15 20:17 ` [Bug libfortran/98301] " kargl at gcc dot gnu.org
@ 2020-12-15 20:17 ` kargl at gcc dot gnu.org
2020-12-15 20:18 ` kargl at gcc dot gnu.org
` (13 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: kargl at gcc dot gnu.org @ 2020-12-15 20:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
kargl at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
Last reconfirmed| |2020-12-15
--- Comment #2 from kargl at gcc dot gnu.org ---
See https://gcc.gnu.org/pipermail/fortran/2020-December/055425.html
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() may be non-conforming
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
2020-12-15 20:17 ` [Bug libfortran/98301] " kargl at gcc dot gnu.org
2020-12-15 20:17 ` kargl at gcc dot gnu.org
@ 2020-12-15 20:18 ` kargl at gcc dot gnu.org
2020-12-18 4:01 ` [Bug libfortran/98301] random_init() is broken kargl at gcc dot gnu.org
` (12 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: kargl at gcc dot gnu.org @ 2020-12-15 20:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
kargl at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P4
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (2 preceding siblings ...)
2020-12-15 20:18 ` kargl at gcc dot gnu.org
@ 2020-12-18 4:01 ` kargl at gcc dot gnu.org
2020-12-21 0:53 ` kargl at gcc dot gnu.org
` (11 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: kargl at gcc dot gnu.org @ 2020-12-18 4:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
--- Comment #3 from kargl at gcc dot gnu.org ---
Created attachment 49791
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49791&action=edit
new diff with improvements
New diff with a better implementation.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (3 preceding siblings ...)
2020-12-18 4:01 ` [Bug libfortran/98301] random_init() is broken kargl at gcc dot gnu.org
@ 2020-12-21 0:53 ` kargl at gcc dot gnu.org
2021-02-22 4:36 ` jvdelisle at gcc dot gnu.org
` (10 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: kargl at gcc dot gnu.org @ 2020-12-21 0:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
--- Comment #4 from kargl at gcc dot gnu.org ---
Created attachment 49816
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49816&action=edit
Newest patch.
This new patch implements Thomas idea of generating appropriate library calls
for the different ways that gfortran handles coarrays.
* gcc/fortran/trans-decl.c:
. Add definitions for gfor_fndecl_caf_random_init and
gfor_fndecl_cas_random_init.
* gcc/fortran/trans-intrinsic.c:
. For -fcoarray=lib, generate a call to _gfortran_caf_random_init().
. For -fcoarray=shared, generate a call to _gfortran_cas_random_init().
. For -fcoarray=single or without the -fcoarray option, generate a call
to _gfortran_random_init().
* gcc/fortran/trans.h:
. Add declares for gfor_fndecl_caf_random_init and
gfor_fndecl_cas_random_init
* libgfortran/intrinsics/random_init.f90:
. Rework _gfortran_random_init(), but preserve the ABI.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (4 preceding siblings ...)
2020-12-21 0:53 ` kargl at gcc dot gnu.org
@ 2021-02-22 4:36 ` jvdelisle at gcc dot gnu.org
2021-02-22 18:57 ` sgk at troutmask dot apl.washington.edu
` (9 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2021-02-22 4:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jvdelisle at gcc dot gnu.org
--- Comment #5 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Steve, if you think this does it. I will get it ready to commit for you. Does
it also need to be back ported?
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (5 preceding siblings ...)
2021-02-22 4:36 ` jvdelisle at gcc dot gnu.org
@ 2021-02-22 18:57 ` sgk at troutmask dot apl.washington.edu
2021-02-22 19:11 ` sgk at troutmask dot apl.washington.edu
` (8 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: sgk at troutmask dot apl.washington.edu @ 2021-02-22 18:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
--- Comment #6 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Mon, Feb 22, 2021 at 04:36:50AM +0000, jvdelisle at gcc dot gnu.org wrote:
>
> --- Comment #5 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
> Steve, if you think this does it. I will get it ready to commit for you. Does
> it also need to be back ported?
>
Well, I think it is correct for at least what I've been
able to test! I don't use co-arrays, so do not have
OpenCoarray or the shared-memory WIP installed. For,
-fcoarray=lib or -fcoarray=shared, function calls are
generated. These are currently unimplimented and need
to be implemented in such a manner as the function calls
are aware of the underlying coarray implemention. I
don't remember the details, but I recall that the images
need to communicate about the seeds.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (6 preceding siblings ...)
2021-02-22 18:57 ` sgk at troutmask dot apl.washington.edu
@ 2021-02-22 19:11 ` sgk at troutmask dot apl.washington.edu
2021-04-03 17:00 ` kargl at gcc dot gnu.org
` (7 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: sgk at troutmask dot apl.washington.edu @ 2021-02-22 19:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
--- Comment #7 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Mon, Feb 22, 2021 at 06:57:03PM +0000, sgk at troutmask dot
apl.washington.edu wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
>
> --- Comment #6 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
> On Mon, Feb 22, 2021 at 04:36:50AM +0000, jvdelisle at gcc dot gnu.org wrote:
> >
> > --- Comment #5 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
> > Steve, if you think this does it. I will get it ready to commit for you. Does
> > it also need to be back ported?
> >
>
> Well, I think it is correct for at least what I've been
> able to test! I don't use co-arrays, so do not have
> OpenCoarray or the shared-memory WIP installed. For,
> -fcoarray=lib or -fcoarray=shared, function calls are
> generated. These are currently unimplimented and need
> to be implemented in such a manner as the function calls
> are aware of the underlying coarray implemention. I
> don't remember the details, but I recall that the images
> need to communicate about the seeds.
>
Oh, one last item. This patch will likely break gfortran+opencoarray
because _gfortran_caf_random_init is missing, and therefore will
prevent linking of the program.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (7 preceding siblings ...)
2021-02-22 19:11 ` sgk at troutmask dot apl.washington.edu
@ 2021-04-03 17:00 ` kargl at gcc dot gnu.org
2021-04-23 7:15 ` vehre at gcc dot gnu.org
` (6 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: kargl at gcc dot gnu.org @ 2021-04-03 17:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
kargl at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49770|0 |1
is obsolete| |
Attachment #49791|0 |1
is obsolete| |
Attachment #49816|0 |1
is obsolete| |
--- Comment #8 from kargl at gcc dot gnu.org ---
Created attachment 50502
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50502&action=edit
Patch to supersedes all previous patches.
This patch supersedes all previous patches. It now contains a sham
implementation for -fcoarray=lib and -fcoarray=shared.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (8 preceding siblings ...)
2021-04-03 17:00 ` kargl at gcc dot gnu.org
@ 2021-04-23 7:15 ` vehre at gcc dot gnu.org
2021-04-26 10:37 ` vehre at gcc dot gnu.org
` (5 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: vehre at gcc dot gnu.org @ 2021-04-23 7:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
Andre Vehreschild <vehre at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |vehre at gcc dot gnu.org
Assignee|unassigned at gcc dot gnu.org |vehre at gcc dot gnu.org
--- Comment #9 from Andre Vehreschild <vehre at gcc dot gnu.org> ---
Going to implement the coarray part.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (9 preceding siblings ...)
2021-04-23 7:15 ` vehre at gcc dot gnu.org
@ 2021-04-26 10:37 ` vehre at gcc dot gnu.org
2021-04-26 10:38 ` vehre at gcc dot gnu.org
` (4 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: vehre at gcc dot gnu.org @ 2021-04-26 10:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
--- Comment #10 from Andre Vehreschild <vehre at gcc dot gnu.org> ---
Created attachment 50674
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50674&action=edit
Delta from Steve's patch to one submitted for acceptance to implement
random_init for coarray=shared.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (10 preceding siblings ...)
2021-04-26 10:37 ` vehre at gcc dot gnu.org
@ 2021-04-26 10:38 ` vehre at gcc dot gnu.org
2021-05-22 11:30 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: vehre at gcc dot gnu.org @ 2021-04-26 10:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
Andre Vehreschild <vehre at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |WAITING
--- Comment #11 from Andre Vehreschild <vehre at gcc dot gnu.org> ---
Waiting for review/acceptance.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (11 preceding siblings ...)
2021-04-26 10:38 ` vehre at gcc dot gnu.org
@ 2021-05-22 11:30 ` cvs-commit at gcc dot gnu.org
2021-05-22 11:45 ` vehre at gcc dot gnu.org
` (2 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-05-22 11:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andre Vehreschild <vehre@gcc.gnu.org>:
https://gcc.gnu.org/g:26ca6dbda23bc6dfab96ce07afa70ebacedfaf9c
commit r12-997-g26ca6dbda23bc6dfab96ce07afa70ebacedfaf9c
Author: Andre Vehreschild <vehre@gcc.gnu.org>
Date: Sat May 22 13:27:42 2021 +0200
Steve Kargl <kargl@gcc.gnu.org>
PR fortran/98301 - random_init() is broken
Correct implementation of random_init() when -fcoarray=lib is given.
gcc/fortran/ChangeLog:
PR fortran/98301
* trans-decl.c (gfc_build_builtin_function_decls): Move decl.
* trans-intrinsic.c (conv_intrinsic_random_init): Use bool for
lib-call of caf_random_init instead of logical (4-byte).
* trans.h: Add tree var for random_init.
libgfortran/ChangeLog:
PR fortran/98301
* caf/libcaf.h (_gfortran_caf_random_init): New function.
* caf/single.c (_gfortran_caf_random_init): New function.
* gfortran.map: Added fndecl.
* intrinsics/random_init.f90: Implement random_init.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (12 preceding siblings ...)
2021-05-22 11:30 ` cvs-commit at gcc dot gnu.org
@ 2021-05-22 11:45 ` vehre at gcc dot gnu.org
2021-06-06 10:13 ` cvs-commit at gcc dot gnu.org
2021-09-17 6:47 ` pinskia at gcc dot gnu.org
15 siblings, 0 replies; 17+ messages in thread
From: vehre at gcc dot gnu.org @ 2021-05-22 11:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
Andre Vehreschild <vehre at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |RESOLVED
Resolution|--- |FIXED
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (13 preceding siblings ...)
2021-05-22 11:45 ` vehre at gcc dot gnu.org
@ 2021-06-06 10:13 ` cvs-commit at gcc dot gnu.org
2021-09-17 6:47 ` pinskia at gcc dot gnu.org
15 siblings, 0 replies; 17+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-06-06 10:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Andre Vehreschild
<vehre@gcc.gnu.org>:
https://gcc.gnu.org/g:002745ca3668fc5e87c22acc81caaeaaadf9c47a
commit r11-8515-g002745ca3668fc5e87c22acc81caaeaaadf9c47a
Author: Andre Vehreschild <vehre@gcc.gnu.org>
Date: Sun Jun 6 12:06:31 2021 +0200
PR fortran/98301 - random_init() is broken
Correct implementation of random_init() when -fcoarray=lib is given.
Backport from mainline.
2021-06-06 Andre Vehreschild <vehre@gcc.gnu.org>
Steve Kargl <kargl@gcc.gnu.org>
gcc/fortran/ChangeLog:
PR fortran/98301
* trans-decl.c (gfc_build_builtin_function_decls): Move decl.
* trans-intrinsic.c (conv_intrinsic_random_init): Use bool for
lib-call of caf_random_init instead of logical (4-byte).
* trans.h: Add tree var for random_init.
libgfortran/ChangeLog:
PR fortran/98301
* caf/libcaf.h (_gfortran_caf_random_init): New function.
* caf/single.c (_gfortran_caf_random_init): New function.
* gfortran.map: Added fndecl.
* intrinsics/random_init.f90: Implement random_init.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug libfortran/98301] random_init() is broken
2020-12-15 20:15 [Bug libfortran/98301] New: random_init() may be non-conforming kargl at gcc dot gnu.org
` (14 preceding siblings ...)
2021-06-06 10:13 ` cvs-commit at gcc dot gnu.org
@ 2021-09-17 6:47 ` pinskia at gcc dot gnu.org
15 siblings, 0 replies; 17+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-17 6:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98301
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |11.3
^ permalink raw reply [flat|nested] 17+ messages in thread