public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "slyfox at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/98499] [11 Regression] Possibly bad std::string initialization in constructors
Date: Sat, 02 Jan 2021 22:22:09 +0000	[thread overview]
Message-ID: <bug-98499-4-SJTXdowkmO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98499-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98499

--- Comment #1 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Managed to get rid of external <string> dependency:

```
struct string {
  char * _M_buf;
  // local store
  char _M_local_buf[16];

  string(const string &__str) : _M_buf(_M_local_buf) {}

  string(const char *__s) : _M_buf(_M_local_buf) {}

  ~string() {
    if (_M_buf != _M_local_buf)
      __builtin_trap();
  }

  // not defined
  string();
};

// main.cc

__attribute__((noinline)) static string dir_name() { return "c"; }
__attribute__((noinline)) static string make_canonical_path(string path) {
  return path;
}
class Importer {
public:
  string imp_path;
  string ctx_path;
  string base_path;

public:
  __attribute__((noinline)) Importer(string imp_path, string ctx_path)
      : imp_path(make_canonical_path(imp_path)),
        ctx_path(make_canonical_path(ctx_path)), base_path(dir_name()) {}
};
struct Include {
  Include(const Importer &imp) {}
};
int main() { const Include &inc = {{"a", "b"}}; }
```

Note: all our string() constructors shoudl have `_M_buf == _M_local_buf`
invariant. But gcc-11 generates always-crashing program:

```
; g++-11.0.0 -O2 -std=c++11 -S main.cc
main:
        .cfi_startproc
        subq    $152, %rsp
        .cfi_def_cfa_offset 160
        movq    %fs:40, %rax
        movq    %rax, 136(%rsp)
        xorl    %eax, %eax
        leaq    8(%rsp), %rax
        movq    %rsp, %rsi
        leaq    32(%rsp), %rdx
        movq    %rax, (%rsp)
        leaq    64(%rsp), %rdi
        leaq    40(%rsp), %rax
        movq    %rax, 32(%rsp)
        call    _ZN8ImporterC1E6stringS0_
        ud2
```

  reply	other threads:[~2021-01-02 22:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-02 11:11 [Bug c++/98499] New: " slyfox at gcc dot gnu.org
2021-01-02 22:22 ` slyfox at gcc dot gnu.org [this message]
2021-01-03 11:44 ` [Bug c++/98499] " slyfox at gcc dot gnu.org
2021-01-03 20:56 ` slyfox at gcc dot gnu.org
2021-01-03 21:50 ` slyfox at gcc dot gnu.org
2021-01-04 12:28 ` marxin at gcc dot gnu.org
2021-01-05 11:09 ` rguenth at gcc dot gnu.org
2021-01-06 23:11 ` [Bug tree-optimization/98499] " slyfox at gcc dot gnu.org
2021-01-07  8:12 ` rguenth at gcc dot gnu.org
2021-01-10 18:39 ` slyfox at gcc dot gnu.org
2021-01-28 10:55 ` hubicka at gcc dot gnu.org
2021-01-30 18:02 ` slyfox at gcc dot gnu.org
2021-02-01 18:14 ` cvs-commit at gcc dot gnu.org
2021-02-01 18:39 ` slyfox at gcc dot gnu.org
2021-02-01 18:40 ` slyfox at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98499-4-SJTXdowkmO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).