public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "segher at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/98519] rs6000: @pcrel unsupported on this instruction error in pveclib
Date: Mon, 03 Oct 2022 21:07:55 +0000 [thread overview]
Message-ID: <bug-98519-4-U9VOqAW14b@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98519-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98519
--- Comment #28 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #27)
> (In reply to Michael Meissner from comment #23)
> > If we change rs6000_legitimate_address_p to return false if we have a
> > prefixed address and we are in asm, we get an insn not found error:
> >
> > --- /home/meissner/tmp/gcc-tmp/TskwFJ_rs6000.c 2021-02-16
> > 11:44:05.520201674 -0500
> > +++ gcc/config/rs6000/rs6000.c 2021-02-16 11:41:41.444740394 -0500
> > @@ -9532,7 +9532,7 @@ rs6000_legitimate_address_p (machine_mod
> >
> > /* Handle prefixed addresses (PC-relative or 34-bit offset). */
> > if (address_is_prefixed (x, mode, NON_PREFIXED_DEFAULT))
> > - return 1;
> > + return !recog_data.is_asm;
> >
> > /* Handle restricted vector d-form offsets in ISA 3.0. */
> > if (quad_offset_p)
>
> I don't think this change is correct as is, since pcrel addresses could be
> legitimate in asm
All prefixed addresses, pcrel or R=0, are valid always. The original code
is correct.
But lxsd cannot use "m" as constraint anyway. It needs "wY", and that will
work fine here?
next prev parent reply other threads:[~2022-10-03 21:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 22:12 [Bug target/98519] New: " bergner at gcc dot gnu.org
2021-01-04 22:19 ` [Bug target/98519] " bergner at gcc dot gnu.org
2021-01-04 23:08 ` meissner at gcc dot gnu.org
2021-01-04 23:23 ` bergner at gcc dot gnu.org
2021-01-04 23:49 ` segher at gcc dot gnu.org
2021-01-05 1:18 ` munroesj at gcc dot gnu.org
2021-01-05 1:23 ` segher at gcc dot gnu.org
2021-01-05 1:55 ` munroesj at gcc dot gnu.org
2021-01-05 3:09 ` segher at gcc dot gnu.org
2021-01-05 3:28 ` meissner at gcc dot gnu.org
2021-01-05 14:13 ` wschmidt at gcc dot gnu.org
2021-01-05 15:01 ` segher at gcc dot gnu.org
2021-01-05 16:45 ` wschmidt at gcc dot gnu.org
2021-01-05 17:31 ` bergner at gcc dot gnu.org
2021-01-05 21:08 ` wschmidt at gcc dot gnu.org
2021-01-05 22:07 ` meissner at gcc dot gnu.org
2021-01-13 22:07 ` segher at gcc dot gnu.org
2021-01-13 23:40 ` segher at gcc dot gnu.org
2021-01-22 6:14 ` amodra at gmail dot com
2021-01-22 18:07 ` segher at gcc dot gnu.org
2021-01-23 23:48 ` bergner at gcc dot gnu.org
2021-02-02 4:17 ` meissner at gcc dot gnu.org
2021-02-02 4:34 ` meissner at gcc dot gnu.org
2021-02-02 21:30 ` segher at gcc dot gnu.org
2021-02-02 23:28 ` meissner at gcc dot gnu.org
2021-02-16 16:45 ` meissner at gcc dot gnu.org
2021-02-16 16:48 ` meissner at gcc dot gnu.org
2021-02-16 16:49 ` meissner at gcc dot gnu.org
2021-02-16 23:06 ` segher at gcc dot gnu.org
2022-10-03 19:49 ` bergner at gcc dot gnu.org
2022-10-03 21:07 ` segher at gcc dot gnu.org [this message]
2022-10-03 22:18 ` bergner at gcc dot gnu.org
2022-10-03 22:41 ` segher at gcc dot gnu.org
2022-10-03 23:54 ` bergner at gcc dot gnu.org
2022-10-10 16:00 ` segher at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-98519-4-U9VOqAW14b@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).