[Bug c++/98530] New: g++.dg/modules/string-1_b.C etc. FAIL

[Bug c++/98530] New: g++.dg/modules/string-1_b.C etc. FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98530

            Bug ID: 98530
           Summary: g++.dg/modules/string-1_b.C etc. FAIL
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: nathan at gcc dot gnu.org
  Target Milestone: ---
            Target: i386-pc-solaris2.11

Created attachment 49886
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49886&action=edit
i386-pc-solaris2.11 32-bit string-1_a.H.gcm/string-1_b.ii

Several of the new module tests FAIL on Solaris/x86, e.g.

+FAIL: g++.dg/modules/string-1_b.C -std=c++17 (test for excess errors)
+FAIL: g++.dg/modules/string-1_b.C -std=c++2a (test for excess errors)

Excess errors:
/usr/include/sys/regset.h:359:19: error: conflicting global module declaration
'fpu::<unnamed union>::fpchip_state fpu::<unnamed union>::fpchip_state'
/usr/include/sys/regset.h:363:19: error: conflicting global module declaration
'fpu::<unnamed union>::fp_emul_space fpu::<unnamed union>::fp_emul_space'

/usr/include/sys/regset.h:359:19: error: conflicting global module declaration
'fpu::<unnamed union>::fpchip_state fpu::<unnamed union>::fpchip_state'
/usr/include/sys/regset.h:359:19: note: existing declaration 'fpu::<unnamed
union>::fpchip_state fpu::<unnamed union>::fpchip_state'
/usr/include/sys/regset.h:363:19: error: conflicting global module declaration
'fpu::<unnamed union>::fp_emul_space fpu::<unnamed union>::fp_emul_space'
/usr/include/sys/regset.h:363:19: note: existing declaration 'fpu::<unnamed
union>::fp_emul_space fpu::<unnamed union>::fp_emul_space'

This can be reproduced with

$ cc1plus -fpreprocessed string-1_b.ii -quiet -std=c++17 -fmodules-ts
-fno-module-lazy -o string-1_b.s

and the attached .ii/.gcm files.

[Bug c++/98530] g++.dg/modules/string-1_b.C etc. FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98530

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug c++/98530] g++.dg/modules/string-1_b.C etc. FAIL

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98530

Nathan Sidwell <nathan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-01-05
           Assignee|unassigned at gcc dot gnu.org      |nathan at gcc dot gnu.org

--- Comment #1 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
thanks, this smells like a broken solaris header.  unnamed structs and unions
without typedef-names for linkage purposes are different entities in each
compilation, and thus an ODR land-mine.  with the preprocessed code I can
figure that out.

[Bug c++/98530] g++.dg/modules/string-1_b.C etc. FAIL

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98530

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
> thanks, this smells like a broken solaris header.  unnamed structs and unions
> without typedef-names for linkage purposes are different entities in each
> compilation, and thus an ODR land-mine.  with the preprocessed code I can
> figure that out.

I see.  Depending on what's up, I can see to have this fixed upstream
for the future, and eventually via fixincludes if need be.

[Bug c++/98530] [11 Regression] g++.dg/modules/string-1_b.C etc. FAIL

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98530

--- Comment #3 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
sigh, not a broken header, it is a broken compiler

[Bug c++/98530] [11 Regression] g++.dg/modules/string-1_b.C etc. FAIL

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98530

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathan Sidwell <nathan@gcc.gnu.org>:

https://gcc.gnu.org/g:3c1cf7350bff6ba03faaa61b44d74bf8a06c6543

commit r11-6834-g3c1cf7350bff6ba03faaa61b44d74bf8a06c6543
Author: Nathan Sidwell <nathan@acm.org>
Date:   Thu Jan 21 04:48:39 2021 -0800

    c++: Stat-hack for members [PR 98530]

    This was a header file that deployed the stat-hack inside a class
    (both a member-class and a [non-static data] member had the same
    name).  Due to the way that's represented in name lookup we missed the
    class.  Sadly just changing the representation globally has
    detrimental effects elsewhere, and this is a rare case, so just
    creating a new overload on the fly shouldn't be a problem.

            PR c++/98530
            gcc/cp/
            * name-lookup.c (lookup_class_binding): Rearrange a stat-hack.
            gcc/testsuite/
            * g++.dg/modules/stat-mem-1.h: New.
            * g++.dg/modules/stat-mem-1_a.H: New.
            * g++.dg/modules/stat-mem-1_b.C: New.

[Bug c++/98530] [11 Regression] g++.dg/modules/string-1_b.C etc. FAIL

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98530

Nathan Sidwell <nathan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
3c1cf7350bf 2021-01-21 | c++: Stat-hack for members [PR 98530]