[Bug testsuite/98643] New: [11 regression] r11-6615 causes failure in gcc.target/powerpc/fold-vec-extract- char.p7.c

[Bug testsuite/98643] New: [11 regression] r11-6615 causes failure in gcc.target/powerpc/fold-vec-extract- char.p7.c

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98643

            Bug ID: 98643
           Summary: [11 regression] r11-6615 causes failure in
                    gcc.target/powerpc/fold-vec-extract- char.p7.c
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:cf2ac1c30af0fa783c8d72e527904dda5d8cc330, r11-6615

make  -k check-gcc
RUNTESTFLAGS="powerpc.exp=gcc.target/powerpc/fold-vec-extract-
char.p7.c"
FAIL: gcc.target/powerpc/fold-vec-extract-char.p7.c scan-assembler-times
\\maddi\\M 6
# of expected passes            7
# of unexpected failures        1

Some extra expected assembler output addi instructions.  The difference in the
assembler is this:

12,15d11
<       rldicl 5,5,0,60
<       li 9,32
<       addi 10,5,-48
<       add 5,10,1
16a13
> 	li 9,32
17a15,16
> 	rldicl 5,5,0,60
> 	add 5,10,5
32,35d30
<       rldicl 5,5,0,60
<       li 9,32
<       addi 10,5,-48
<       add 5,10,1
36a32
> 	li 9,32
37a34,35
> 	rldicl 5,5,0,60
> 	add 5,10,5
53,56d50
<       rldicl 5,5,0,60
<       li 9,32
<       addi 10,5,-48
<       add 5,10,1
57a52
> 	li 9,32
58a54,55
> 	rldicl 5,5,0,60
> 	add 5,10,5

So it looks like 3 extra addi's are generated.

[Bug testsuite/98643] [11 regression] r11-6615 causes failure in gcc.target/powerpc/fold-vec-extract- char.p7.c

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98643

--- Comment #1 from seurer at gcc dot gnu.org ---
Here's a context diff


seurer@genoa:~/gcc/git/build/gcc-test$ diff -c
fold-vec-extract-char.p7.s.r11-6614 fold-vec-extract-char.p7.s.r11-6615
*** fold-vec-extract-char.p7.s.r11-6614 Tue Jan 12 14:12:26 2021
--- fold-vec-extract-char.p7.s.r11-6615 Tue Jan 12 14:00:56 2021
***************
*** 9,19 ****
  testbc_var:
  .LFB0:
        .cfi_startproc
!       addi 10,1,-48
        li 9,32
        stvx 2,10,9
-       rldicl 5,5,0,60
-       add 5,10,5
        lbz 3,32(5)
        blr
        .long 0
--- 9,20 ----
  testbc_var:
  .LFB0:
        .cfi_startproc
!       rldicl 5,5,0,60
        li 9,32
+       addi 10,5,-48
+       add 5,10,1
+       addi 10,1,-48
        stvx 2,10,9
        lbz 3,32(5)
        blr
        .long 0
***************
*** 28,38 ****
  testsc_var:
  .LFB1:
        .cfi_startproc
!       addi 10,1,-48
        li 9,32
        stvx 2,10,9
-       rldicl 5,5,0,60
-       add 5,10,5
        lbz 3,32(5)
        extsb 3,3
        blr
--- 29,40 ----
  testsc_var:
  .LFB1:
        .cfi_startproc
!       rldicl 5,5,0,60
        li 9,32
+       addi 10,5,-48
+       add 5,10,1
+       addi 10,1,-48
        stvx 2,10,9
        lbz 3,32(5)
        extsb 3,3
        blr
***************
*** 48,58 ****
  testuc_var:
  .LFB2:
        .cfi_startproc
!       addi 10,1,-48
        li 9,32
        stvx 2,10,9
-       rldicl 5,5,0,60
-       add 5,10,5
        lbz 3,32(5)
        blr
        .long 0
--- 50,61 ----
  testuc_var:
  .LFB2:
        .cfi_startproc
!       rldicl 5,5,0,60
        li 9,32
+       addi 10,5,-48
+       add 5,10,1
+       addi 10,1,-48
        stvx 2,10,9
        lbz 3,32(5)
        blr
        .long 0

[Bug testsuite/98643] [11 regression] r11-6615 causes failure in gcc.target/powerpc/fold-vec-extract- char.p7.c

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98643

Segher Boessenkool <segher at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-01-13
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #2 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Yeah, the last addi in the new addi/add/addi sequences is superfluous.

Confirmed.

[Bug testsuite/98643] [11 regression] r11-6615 causes failure in gcc.target/powerpc/fold-vec-extract- char.p7.c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98643

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug testsuite/98643] [11 regression] r11-6615 causes failure in gcc.target/powerpc/fold-vec-extract- char.p7.c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98643

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |missed-optimization, ra
           Priority|P3                          |P1

[Bug testsuite/98643] [11 regression] r11-6615 causes failure in gcc.target/powerpc/fold-vec-extract- char.p7.c

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98643

--- Comment #3 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
I believe a patch for PR98722 fixes this PR too.

4334b524274203125193a08a8485250c41c2daa9

[Bug testsuite/98643] [11 regression] r11-6615 causes failure in gcc.target/powerpc/fold-vec-extract- char.p7.c

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98643

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from seurer at gcc dot gnu.org ---
Works now, thanks for the fix!