[Bug rtl-optimization/98722] New: [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[Bug rtl-optimization/98722] New: [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

            Bug ID: 98722
           Summary: [11 Regression] ICE in lra_set_insn_recog_data, at
                    lra.c:1004 since
                    r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: vmakarov at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-linux
            Target: s390x-linux-gnu

Since the revision I see the following ICE:

$ cat reint.cpp
struct B {
  virtual void Method();
};
typedef void (B::*fn_type_a)();

int main() {
  fn_type_a f(&B::Method);
  B b;
  (b.*f)();
}

$ ./xgcc -B. -Og -fno-tree-fre -fno-split-wide-types -c reint.cpp
during RTL pass: reload
reint.cpp: In function ‘int main()’:
reint.cpp:10:1: internal compiler error: in lra_set_insn_recog_data, at
lra.c:1004
   10 | }
      | ^
0x138dc84 lra_set_insn_recog_data(rtx_insn*)
        /home/marxin/Programming/gcc2/gcc/lra.c:1004
0x138b9e1 lra_get_insn_recog_data
        /home/marxin/Programming/gcc2/gcc/lra-int.h:486
0x138f87d lra_update_insn_regno_info(rtx_insn*)
        /home/marxin/Programming/gcc2/gcc/lra.c:1625
0x138fd86 lra_push_insn_1
        /home/marxin/Programming/gcc2/gcc/lra.c:1780
0x138fdb9 lra_push_insn(rtx_insn*)
        /home/marxin/Programming/gcc2/gcc/lra.c:1788
0x138fec1 push_insns
        /home/marxin/Programming/gcc2/gcc/lra.c:1831
0x13900ae lra_process_new_insns(rtx_insn*, rtx_insn*, rtx_insn*, char const*)
        /home/marxin/Programming/gcc2/gcc/lra.c:1871
0x13a73ac curr_insn_transform
        /home/marxin/Programming/gcc2/gcc/lra-constraints.c:4644
0x13a8a02 lra_constraints(bool)
        /home/marxin/Programming/gcc2/gcc/lra-constraints.c:5138
0x139119c lra(_IO_FILE*)
        /home/marxin/Programming/gcc2/gcc/lra.c:2332
0x1339df4 do_reload
        /home/marxin/Programming/gcc2/gcc/ira.c:5811
0x133a2d6 execute
        /home/marxin/Programming/gcc2/gcc/ira.c:5997
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug rtl-optimization/98722] [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-01-18
      Known to fail|                            |11.0
      Known to work|                            |10.2.0
   Target Milestone|---                         |11.0
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

[Bug rtl-optimization/98722] [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
           Keywords|                            |ra

[Bug rtl-optimization/98722] [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

--- Comment #1 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
Sorry, I can not reproduce this on today trunk using reint.cpp test.  I guess
it is x86-64.  I am using the following configuration (meaning with enabled
checking)

/home/cygnus/vmakarov/build1/gcc-git/gcc/configure
--srcdir=/home/cygnus/vmakarov/build1/gcc-git/gcc
--prefix=/home/cygnus/vmakarov/build1/gcc-git/64 --disable-bootstrap
--enable-languages=c,c++,fortran

Could you check it again or provide more info how to reproduce it.

[Bug rtl-optimization/98722] [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
It happens for s390x target, so you will need to build a cross compiler with:
--target=s390x-linux-gnu.

[Bug rtl-optimization/98722] [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

--- Comment #3 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #2)
> It happens for s390x target, so you will need to build a cross compiler with:
> --target=s390x-linux-gnu.

Thank you, Martin.  I've reproduced it on s390x.

[Bug rtl-optimization/98722] [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Vladimir Makarov <vmakarov@gcc.gnu.org>:

https://gcc.gnu.org/g:4334b524274203125193a08a8485250c41c2daa9

commit r11-6819-g4334b524274203125193a08a8485250c41c2daa9
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date:   Wed Jan 20 11:40:14 2021 -0500

    [PR98722] LRA: Check that target has no 3-op add insn to transform 2 plus
expression.

    Patch cf2ac1c30af0fa783c8d72e527904dda5d8cc330 for solving PR97969 was
    assumed for targets with absent 3-op add insn.  But the original patch did
    not check this.  This patch adds the check.

    gcc/ChangeLog:

            PR rtl-optimization/98722
            * lra-eliminations.c (eliminate_regs_in_insn): Check that target
            has no 3-op add insn to transform insns containing two pluses.

    gcc/testsuite/ChangeLog:

            PR rtl-optimization/98722
            * g++.target/s390/pr98722.C: New.

[Bug rtl-optimization/98722] [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bergner at gcc dot gnu.org

--- Comment #5 from Peter Bergner <bergner at gcc dot gnu.org> ---
Another P1 that looks like it might be fixed.  Vlad, can we marked this as
fixed?

[Bug rtl-optimization/98722] [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

--- Comment #6 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #5)
> Another P1 that looks like it might be fixed.  Vlad, can we marked this as
> fixed?

I believe it is fixed and we could close the PR.

[Bug rtl-optimization/98722] [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
.

[Bug rtl-optimization/98722] [11 Regression] ICE in lra_set_insn_recog_data, at lra.c:1004 since r11-6615-gcf2ac1c30af0fa783c8d72e527904dda5d8cc330

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98722

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Przemyslaw Wirkus
<wirkus@gcc.gnu.org>:

https://gcc.gnu.org/g:1791b11d9cae388ae18a768eeb96c998439c986a

commit r10-9881-g1791b11d9cae388ae18a768eeb96c998439c986a
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date:   Wed Jan 20 11:40:14 2021 -0500

    [PR98722] LRA: Check that target has no 3-op add insn to transform 2 plus
expression.

    Patch cf2ac1c30af0fa783c8d72e527904dda5d8cc330 for solving PR97969 was
    assumed for targets with absent 3-op add insn.  But the original patch did
    not check this.  This patch adds the check.

    gcc/ChangeLog:

            PR rtl-optimization/98722
            * lra-eliminations.c (eliminate_regs_in_insn): Check that target
            has no 3-op add insn to transform insns containing two pluses.

    gcc/testsuite/ChangeLog:

            PR rtl-optimization/98722
            * g++.target/s390/pr98722.C: New.

    (cherry picked from commit 4334b524274203125193a08a8485250c41c2daa9)