[Bug target/98827] New: [11 regression] gcc.target/powerpc/vsx-builtin-7.c assembler counts off after r11-6857

[Bug target/98827] New: [11 regression] gcc.target/powerpc/vsx-builtin-7.c assembler counts off after r11-6857

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98827

            Bug ID: 98827
           Summary: [11 regression] gcc.target/powerpc/vsx-builtin-7.c
                    assembler counts off after r11-6857
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:b29225597584b697762585e0b707b7cb4b427650, r11-6857
make  -k check-gcc
RUNTESTFLAGS="powerpc.exp=gcc.target/powerpc/vsx-builtin-7.c"
FAIL: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times \\mrldic\\M 64
FAIL: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times xxpermdi 4
# of expected passes            4
# of unexpected failures        2

Note that this fails only on big endian.

[Bug target/98827] [11 regression] gcc.target/powerpc/vsx-builtin-7.c assembler counts off after r11-6857

[luoxhu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98827

--- Comment #1 from luoxhu at gcc dot gnu.org ---
Strange that I see only xxpermdi fail, should be 4 instead of 12. rldic passes
for m64, what's your configuration please?



                === gcc tests ===

Schedule of variations:
    unix/-m32
    unix/-m64

Running target unix/-m32
Running /home/luoxhu/workspace/gcc/gcc/testsuite/gcc.target/powerpc/powerpc.exp
...
PASS: gcc.target/powerpc/vsx-builtin-7.c (test for excess errors)
PASS: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times \\mrldic\\M 0
PASS: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times vspltisb 2
PASS: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times vspltish 2
PASS: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times vspltisw 2
PASS: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times xxpermdi 4
                === gcc Summary for unix/-m32 ===

# of expected passes            6
Running target unix/-m64
Running /home/luoxhu/workspace/gcc/gcc/testsuite/gcc.target/powerpc/powerpc.exp
...
PASS: gcc.target/powerpc/vsx-builtin-7.c (test for excess errors)
PASS: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times \\mrldic\\M 64
PASS: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times vspltisb 2
PASS: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times vspltish 2
PASS: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times vspltisw 2
PASS: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times xxpermdi 4
                === gcc Summary for unix/-m64 ===

# of expected passes            6

                === gcc Summary ===

# of expected passes            12
/home/luoxhu/workspace/build/gcc/xgcc  version 11.0.0 20210125 (experimental)
(GCC)

luoxhu@bns:~/workspace/build$ gcc/xgcc -v
Using built-in specs.
COLLECT_GCC=gcc/xgcc
Target: powerpc64-unknown-linux-gnu
Configured with: ../gcc/configure --enable-languages=c,c++,fortran
--prefix=/home/luoxhu/local/gcc/ --disable-bootstrap --with-cpu=power7
--disable-libsanitizer : (reconfigured) ../gcc/configure
--prefix=/home/luoxhu/local/gcc/ --disable-bootstrap --with-cpu=power7
--disable-libsanitizer CC=/opt/gcc81/bin/gcc CXX=/opt/gcc81/bin/g++
--enable-languages=c,c++,fortran,lto --no-create --no-recursion
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 11.0.0 20210125 (experimental) (GCC)

[Bug target/98827] [11 regression] gcc.target/powerpc/vsx-builtin-7.c assembler counts off after r11-6857

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98827

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug target/98827] [11 regression] gcc.target/powerpc/vsx-builtin-7.c assembler counts off after r11-6857

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98827

--- Comment #2 from seurer at gcc dot gnu.org ---
On power 8 I used:

configure --enable-languages=c,fortran,c++ --with-cpu=power8
--disable-bootstrap --disable-multilib

On power 7 it was the same but --with-cpu=power7

[Bug target/98827] [11 regression] gcc.target/powerpc/vsx-builtin-7.c assembler counts off after r11-6857

[luoxhu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98827

--- Comment #3 from luoxhu at gcc dot gnu.org ---
I know it now, the r11-6858 did some changes the P8 code generation, so the
latest failure also changes.

https://gcc.gnu.org/pipermail/gcc-testresults/2021-January/651154.html

current failures are:

FAIL: gcc.dg/vect/vect-outer-call-1.c scan-tree-dump vect "OUTER LOOP
VECTORIZED"
FAIL: gcc.dg/vect/vect-strided-a-u8-i2-gap.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vectorized 1 loops" 1
FAIL: gcc.dg/vect/vect-strided-a-u8-i2-gap.c scan-tree-dump-times vect
"vectorized 1 loops" 1
FAIL: gcc.target/powerpc/20050603-3.c scan-assembler-not \\\\mrldic
FAIL: gcc.target/powerpc/rlwimi-2.c scan-assembler-times (?n)^\\\\s+[a-z] 20217
FAIL: gcc.target/powerpc/vsx-builtin-7.c scan-assembler-times xxpermdi 11
XPASS: gcc.target/powerpc/ppc-fortran/ieee128-math.f90   -O  (test for excess
errors)

only xxpermdi need be updated to 4.

[Bug target/98827] [11 regression] gcc.target/powerpc/vsx-builtin-7.c assembler counts off after r11-6857

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98827

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Xiong Hu Luo <luoxhu@gcc.gnu.org>:

https://gcc.gnu.org/g:fbe37371cf372b84d5b7f1a6f5f0971a513dd5fa

commit r11-6947-gfbe37371cf372b84d5b7f1a6f5f0971a513dd5fa
Author: Xionghu Luo <luoxhu@linux.ibm.com>
Date:   Wed Jan 27 20:24:03 2021 -0600

    rs6000: Fix vec insert ilp32 ICE and test failures [PR98799]

    UNSPEC_SI_FROM_SF is not supported when TARGET_DIRECT_MOVE_64BIT
    is false for -m32, don't generate VIEW_CONVERT_EXPR(ARRAY_REF) for
    variable vector insert.  Remove rs6000_expand_vector_set_var helper
    function, adjust the p8 and p9 definitions position and make them
    static.

    The previous commit r11-6858 missed check m32, This patch is tested pass
    on P7BE{m32,m64}/P8BE{m32,m64}/P8LE/P9LE with
    RUNTESTFLAGS="--target_board =unix'{-m32,-m64}'" for BE targets.

    gcc/ChangeLog:

    2021-01-27  Xionghu Luo  <luoxhu@linux.ibm.com>
                David Edelsohn  <dje.gcc@gmail.com>

            PR target/98799
            * config/rs6000/rs6000-c.c (altivec_resolve_overloaded_builtin):
            Don't generate VIEW_CONVERT_EXPR for fcode
ALTIVEC_BUILTIN_VEC_INSERT
            when -m32.
            * config/rs6000/rs6000-protos.h (rs6000_expand_vector_set_var):
            Delete.
            * config/rs6000/rs6000.c (rs6000_expand_vector_set): Remove the
            wrapper call rs6000_expand_vector_set_var for cleanup.  Call
            rs6000_expand_vector_set_var_p9 and rs6000_expand_vector_set_var_p8
            directly.
            (rs6000_expand_vector_set_var): Delete.
            (rs6000_expand_vector_set_var_p9): Make static.
            (rs6000_expand_vector_set_var_p8): Make static.

    gcc/testsuite/ChangeLog:

    2021-01-27  Xionghu Luo  <luoxhu@linux.ibm.com>

            PR target/98827
            * gcc.target/powerpc/fold-vec-insert-char-p8.c: Adjust ilp32.
            * gcc.target/powerpc/fold-vec-insert-char-p9.c: Likewise.
            * gcc.target/powerpc/fold-vec-insert-double.c: Likewise.
            * gcc.target/powerpc/fold-vec-insert-float-p8.c: Likewise.
            * gcc.target/powerpc/fold-vec-insert-float-p9.c: Likewise.
            * gcc.target/powerpc/fold-vec-insert-int-p8.c: Likewise.
            * gcc.target/powerpc/fold-vec-insert-int-p9.c: Likewise.
            * gcc.target/powerpc/fold-vec-insert-longlong.c: Likewise.
            * gcc.target/powerpc/fold-vec-insert-short-p8.c: Likewise.
            * gcc.target/powerpc/fold-vec-insert-short-p9.c: Likewise.
            * gcc.target/powerpc/pr79251.p8.c: Likewise.
            * gcc.target/powerpc/pr79251.p9.c: Likewise.
            * gcc.target/powerpc/vsx-builtin-7.c: Likewise.
            * gcc.target/powerpc/pr79251-run.c: Build and run with vsx
            option.

[Bug target/98827] [11 regression] gcc.target/powerpc/vsx-builtin-7.c assembler counts off after r11-6857

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98827

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
I assume fixed.