public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/98856] [11/12 Regression] botan AES-128/XTS is slower by ~17% since r11-6649-g285fa338b06b804e72997c4d876ecf08a9c083af Date: Thu, 13 May 2021 10:17:25 +0000 [thread overview] Message-ID: <bug-98856-4-ms9NDs6QMs@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-98856-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98856 --- Comment #40 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:829c4bea06600ea4201462f91ce6d76ca21fdb35 commit r12-769-g829c4bea06600ea4201462f91ce6d76ca21fdb35 Author: Jakub Jelinek <jakub@redhat.com> Date: Thu May 13 12:14:14 2021 +0200 ix86: Support V{2, 4}DImode arithmetic right shifts for SSE2+ [PR98856] As mentioned in the PR, we don't support arithmetic right V2DImode or V4DImode on x86 without -mavx512vl or -mxop. The ISAs indeed don't have {,v}psraq instructions until AVX512VL, but we actually can emulate it quite easily. One case is arithmetic >> 63, we can just emit {,v}pxor; {,v}pcmpgt for that for SSE4.2+, or for SSE2 psrad $31; pshufd $0xf5. Then arithmetic >> by constant > 32, that can be done with {,v}psrad $31 and {,v}psrad $(cst-32) and two operand permutation, arithmetic >> 32 can be done as {,v}psrad $31 and permutation of that and the original operand. Arithmetic >> by constant < 32 can be done as {,v}psrad $cst and {,v}psrlq $cst and two operand permutation. And arithmetic >> by variable scalar amount can be done as arithmetic >> 63, logical >> by the amount, << by (64 - amount of the >> 63 result; note that the vector << 64 result in 0) and oring together. I had to improve the permutation generation so that it actually handles the needed permutations (or handles them better). 2021-05-13 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/98856 * config/i386/i386.c (ix86_shift_rotate_cost): Add CODE argument. Expect V2DI and V4DI arithmetic right shifts to be emulated. (ix86_rtx_costs, ix86_add_stmt_cost): Adjust ix86_shift_rotate_cost caller. * config/i386/i386-expand.c (expand_vec_perm_2perm_interleave, expand_vec_perm_2perm_pblendv): New functions. (ix86_expand_vec_perm_const_1): Use them. * config/i386/sse.md (ashr<mode>3<mask_name>): Rename to ... (<mask_codefor>ashr<mode>3<mask_name>): ... this. (ashr<mode>3): New define_expand with VI248_AVX512BW iterator. (ashrv4di3): New define_expand. (ashrv2di3): Change condition to TARGET_SSE2, handle !TARGET_XOP and !TARGET_AVX512VL expansion. * gcc.target/i386/sse2-psraq-1.c: New test. * gcc.target/i386/sse4_2-psraq-1.c: New test. * gcc.target/i386/avx-psraq-1.c: New test. * gcc.target/i386/avx2-psraq-1.c: New test. * gcc.target/i386/avx-pr82370.c: Adjust expected number of vpsrad instructions. * gcc.target/i386/avx2-pr82370.c: Likewise. * gcc.target/i386/avx512f-pr82370.c: Likewise. * gcc.target/i386/avx512bw-pr82370.c: Likewise. * gcc.dg/torture/vshuf-4.inc: Add two further permutations. * gcc.dg/torture/vshuf-8.inc: Likewise.
next prev parent reply other threads:[~2021-05-13 10:17 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-27 14:28 [Bug tree-optimization/98856] New: [11 " marxin at gcc dot gnu.org 2021-01-27 14:29 ` [Bug tree-optimization/98856] " marxin at gcc dot gnu.org 2021-01-27 14:44 ` rguenth at gcc dot gnu.org 2021-01-28 7:47 ` rguenth at gcc dot gnu.org 2021-01-28 8:44 ` marxin at gcc dot gnu.org 2021-01-28 9:40 ` rguenth at gcc dot gnu.org 2021-01-28 11:03 ` rguenth at gcc dot gnu.org 2021-01-28 11:19 ` rguenth at gcc dot gnu.org 2021-01-28 11:57 ` rguenth at gcc dot gnu.org 2021-02-05 10:18 ` rguenth at gcc dot gnu.org 2021-02-05 11:52 ` jakub at gcc dot gnu.org 2021-02-05 12:52 ` rguenth at gcc dot gnu.org 2021-02-05 13:43 ` jakub at gcc dot gnu.org 2021-02-05 14:36 ` jakub at gcc dot gnu.org 2021-02-05 16:29 ` jakub at gcc dot gnu.org 2021-02-05 17:55 ` jakub at gcc dot gnu.org 2021-02-05 19:48 ` jakub at gcc dot gnu.org 2021-02-08 15:14 ` jakub at gcc dot gnu.org 2021-03-04 12:14 ` rguenth at gcc dot gnu.org 2021-03-04 15:36 ` rguenth at gcc dot gnu.org 2021-03-04 16:12 ` rguenth at gcc dot gnu.org 2021-03-04 17:56 ` ubizjak at gmail dot com 2021-03-04 18:12 ` ubizjak at gmail dot com 2021-03-05 7:44 ` rguenth at gcc dot gnu.org 2021-03-05 7:46 ` rguenth at gcc dot gnu.org 2021-03-05 8:29 ` ubizjak at gmail dot com 2021-03-05 10:04 ` rguenther at suse dot de 2021-03-05 10:43 ` rguenth at gcc dot gnu.org 2021-03-05 11:56 ` ubizjak at gmail dot com 2021-03-05 12:25 ` ubizjak at gmail dot com 2021-03-05 12:27 ` rguenth at gcc dot gnu.org 2021-03-05 12:49 ` jakub at gcc dot gnu.org 2021-03-05 12:52 ` ubizjak at gmail dot com 2021-03-05 12:55 ` rguenther at suse dot de 2021-03-05 13:06 ` rguenth at gcc dot gnu.org 2021-03-05 13:08 ` ubizjak at gmail dot com 2021-03-05 14:35 ` rguenth at gcc dot gnu.org 2021-03-08 10:41 ` rguenth at gcc dot gnu.org 2021-03-08 13:20 ` rguenth at gcc dot gnu.org 2021-03-08 15:46 ` amonakov at gcc dot gnu.org 2021-04-27 11:40 ` [Bug tree-optimization/98856] [11/12 " jakub at gcc dot gnu.org 2021-05-13 10:17 ` cvs-commit at gcc dot gnu.org [this message] 2021-07-28 7:05 ` rguenth at gcc dot gnu.org 2022-01-21 13:20 ` rguenth at gcc dot gnu.org 2022-04-21 7:48 ` rguenth at gcc dot gnu.org 2023-04-17 21:43 ` [Bug tree-optimization/98856] [11/12/13/14 " lukebenes at hotmail dot com 2023-04-18 9:07 ` rguenth at gcc dot gnu.org 2023-05-29 10:04 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-98856-4-ms9NDs6QMs@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).