[Bug other/98926] New: [11 regression] several ICEs after r11-7011

[Bug other/98926] New: [11 regression] several ICEs after r11-7011

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

            Bug ID: 98926
           Summary: [11 regression] several ICEs after r11-7011
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:6e0a231a4aa2407bb7167daf98a37795a67364d8, r11-7011

There are several test case failures and/or ICEs after this revision:

make  -k check-gcc RUNTESTFLAGS="dg.exp=g++.dg/cpp0x/alias-decl-52.C"
FAIL: g++.dg/cpp0x/alias-decl-52.C  -std=c++17 (test for excess errors)
# of expected passes            2
# of unexpected failures        1
# of unsupported tests          1

make  -k check-gcc RUNTESTFLAGS="dg.exp=g++.dg/cpp0x/alias-decl-dr1558.C"
FAIL: g++.dg/cpp0x/alias-decl-dr1558.C  -std=c++17 (internal compiler error)
FAIL: g++.dg/cpp0x/alias-decl-dr1558.C  -std=c++17  (test for errors, line 7)
FAIL: g++.dg/cpp0x/alias-decl-dr1558.C  -std=c++17  (test for errors, line 13)
FAIL: g++.dg/cpp0x/alias-decl-dr1558.C  -std=c++17 (test for excess errors)
FAIL: g++.dg/cpp0x/alias-decl-dr1558.C  -std=c++2a (internal compiler error)
FAIL: g++.dg/cpp0x/alias-decl-dr1558.C  -std=c++2a  (test for errors, line 7)
FAIL: g++.dg/cpp0x/alias-decl-dr1558.C  -std=c++2a  (test for errors, line 13)
FAIL: g++.dg/cpp0x/alias-decl-dr1558.C  -std=c++2a (test for excess errors)
# of expected passes            3
# of unexpected failures        8
# of unsupported tests          1

There may be some other failures, too.


Previously:

make  -k check-gcc RUNTESTFLAGS="dg.exp=g++.dg/cpp0x/alias-decl-dr1558.C"
# of expected passes            9
# of unsupported tests          1

make  -k check-gcc RUNTESTFLAGS="dg.exp=g++.dg/cpp0x/alias-decl-52.C"
# of expected passes            3
# of unsupported tests          1

[Bug other/98926] [11 regression] several ICEs after r11-7011

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0
                 CC|                            |jakub at gcc dot gnu.org
           Priority|P3                          |P1

[Bug other/98926] [11 regression] several ICEs after r11-7011

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

David Edelsohn <dje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-02-02

--- Comment #1 from David Edelsohn <dje at gcc dot gnu.org> ---
I believe that the patch also introduced g++.dg/torture/pr94582.C testsuite
failure on AIX and powerpc64-linux

[Bug c++/98926] [11 regression] several ICEs after r11-7011

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
On i686-linux I'm seeing:
+FAIL: g++.dg/cpp0x/alias-decl-dr1558.C  -std=c++11 (test for excess errors)
+FAIL: g++.dg/warn/Warray-bounds15.C  -std=gnu++14  (test for warnings, line
38)
+FAIL: g++.dg/warn/Warray-bounds15.C  -std=gnu++14 (internal compiler error)
+FAIL: g++.dg/warn/Warray-bounds15.C  -std=gnu++14 (test for excess errors)
+FAIL: g++.dg/torture/pr94582.C   -O0  (internal compiler error)
+FAIL: g++.dg/torture/pr94582.C   -O0  (test for excess errors)
+FAIL: g++.dg/torture/pr94582.C   -O1  (internal compiler error)
+FAIL: g++.dg/torture/pr94582.C   -O1  (test for excess errors)
+FAIL: g++.dg/torture/pr94582.C   -O2  (internal compiler error)
+FAIL: g++.dg/torture/pr94582.C   -O2  (test for excess errors)
+FAIL: g++.dg/torture/pr94582.C   -O2 -flto  (internal compiler error)
+FAIL: g++.dg/torture/pr94582.C   -O2 -flto  (test for excess errors)
+FAIL: g++.dg/torture/pr94582.C   -O2 -flto -flto-partition=none  (internal
compiler error)
+FAIL: g++.dg/torture/pr94582.C   -O2 -flto -flto-partition=none  (test for
excess errors)
+FAIL: g++.dg/torture/pr94582.C   -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  (internal compiler error)
+FAIL: g++.dg/torture/pr94582.C   -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  (test for excess errors)
+FAIL: g++.dg/torture/pr94582.C   -O3 -g  (internal compiler error)
+FAIL: g++.dg/torture/pr94582.C   -O3 -g  (test for excess errors)
+FAIL: g++.dg/torture/pr94582.C   -Os  (internal compiler error)
+FAIL: g++.dg/torture/pr94582.C   -Os  (test for excess errors)

alias-decl-dr1558.C:11:8: error: invalid use of incomplete type 'struct
A<void_t<typename T::foo> >'
hash table checking failed: equal operator returns true for a pair of values
with a different hash value
/home/jakub/src/gcc/gcc/testsuite/g++.dg/torture/pr94582.C: In substitution of
'template<class _Up> using rebind = typename
__replace_first_arg<min_pointer<int>, _Up>::type [with _Up =
min_pointer<int>]':
/home/jakub/src/gcc/gcc/testsuite/g++.dg/torture/pr94582.C:15:7:   required by
substitution of 'template<class, class _Tp> using __ptr_rebind =
pointer_traits::rebind<_Tp> [with <template-parameter-1-1> = int; _Tp =
min_pointer<int>]'
/home/jakub/src/gcc/gcc/testsuite/g++.dg/torture/pr94582.C:37:55:   required
from 'struct _Deque_iterator<int>'
/home/jakub/src/gcc/gcc/testsuite/g++.dg/torture/pr94582.C:44:43:   required
from 'class _Deque_base<min_allocator<int> >'
/home/jakub/src/gcc/gcc/testsuite/g++.dg/torture/pr94582.C:47:34:   required
from 'class deque<min_allocator<int> >'
/home/jakub/src/gcc/gcc/testsuite/g++.dg/torture/pr94582.C:84:37:   required
from here
/home/jakub/src/gcc/gcc/testsuite/g++.dg/torture/pr94582.C:15:7: internal
compiler error: in hashtab_chk_error, at hash-table.c:137
(Warray-bounds15.C is the same thing as pr94582.C).

[Bug c++/98926] [11 regression] several ICEs after r11-7011

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

--- Comment #3 from seurer at gcc dot gnu.org ---
This appears to be happening on powerpc64 BE.

More ICEs and a traceback:

g:6e0a231a4aa2407bb7167daf98a37795a67364d8, r11-7011

make  -k check-gcc RUNTESTFLAGS="dg-torture.exp=g++.dg/torture/pr94582.C"
FAIL: g++.dg/torture/pr94582.C   -O0  (internal compiler error)
FAIL: g++.dg/torture/pr94582.C   -O0  (test for excess errors)
FAIL: g++.dg/torture/pr94582.C   -O1  (internal compiler error)
FAIL: g++.dg/torture/pr94582.C   -O1  (test for excess errors)
FAIL: g++.dg/torture/pr94582.C   -O2  (internal compiler error)
FAIL: g++.dg/torture/pr94582.C   -O2  (test for excess errors)
FAIL: g++.dg/torture/pr94582.C   -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  (internal compiler error)
FAIL: g++.dg/torture/pr94582.C   -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  (test for excess errors)
FAIL: g++.dg/torture/pr94582.C   -O3 -g  (internal compiler error)
FAIL: g++.dg/torture/pr94582.C   -O3 -g  (test for excess errors)
FAIL: g++.dg/torture/pr94582.C   -Os  (internal compiler error)
FAIL: g++.dg/torture/pr94582.C   -Os  (test for excess errors)
FAIL: g++.dg/torture/pr94582.C   -O2 -flto -fno-use-linker-plugin
-flto-partition=none  (internal compiler error)
FAIL: g++.dg/torture/pr94582.C   -O2 -flto -fno-use-linker-plugin
-flto-partition=none  (test for excess errors)
FAIL: g++.dg/torture/pr94582.C   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects  (internal compiler error)
FAIL: g++.dg/torture/pr94582.C   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects  (test for excess errors)

/home/seurer/gcc/git/gcc-test/gcc/testsuite/g++.dg/torture/pr94582.C:12:9:
internal compiler error: in hashtab_chk_error, at hash-table.c:137
0x102b63b3 hashtab_chk_error()
        /home/seurer/gcc/git/gcc-test/gcc/hash-table.c:137
0x10645307 hash_table<spec_hasher, false, xcallocator>::verify(spec_entry*
const&, unsigned int)
        /home/seurer/gcc/git/gcc-test/gcc/hash-table.h:1033
0x10645503 hash_table<spec_hasher, false,
xcallocator>::find_with_hash(spec_entry* const&, unsigned int)
        /home/seurer/gcc/git/gcc-test/gcc/hash-table.h:918
0x105f9433 lookup_template_class_1
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:9869
0x105f9433 lookup_template_class(tree_node*, tree_node*, tree_node*,
tree_node*, int, int)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:10231
0x105fcdf3 tsubst_aggr_type
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:13548
0x105e0a4b tsubst(tree_node*, tree_node*, int, tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:15988
0x105fee13 tsubst_decl
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:14768
0x105e099b tsubst(tree_node*, tree_node*, int, tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:15368
0x1062a3f7 instantiate_template_1
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:21040
0x1062a3f7 instantiate_template(tree_node*, tree_node*, int)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:21099
0x105e1073 instantiate_alias_template
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:21137
0x105e1073 tsubst(tree_node*, tree_node*, int, tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:15395
0x105fee13 tsubst_decl
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:14768
0x105e099b tsubst(tree_node*, tree_node*, int, tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:15368
0x1062a3f7 instantiate_template_1
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:21040
0x1062a3f7 instantiate_template(tree_node*, tree_node*, int)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:21099
0x105e1073 instantiate_alias_template
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:21137
0x105e1073 tsubst(tree_node*, tree_node*, int, tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:15395
0x105fee13 tsubst_decl
        /home/seurer/gcc/git/gcc-test/gcc/cp/pt.c:14768

[Bug c++/98926] [11 regression] several ICEs after r11-7011

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

--- Comment #4 from seurer at gcc dot gnu.org ---
This one is from powerpc64 LE.  Same traceback I think.

g:6e0a231a4aa2407bb7167daf98a37795a67364d8, r11-7011

make  -k check-gcc RUNTESTFLAGS="lto.exp=g++.dg/lto/pr65549_0.C"
# of unexpected failures        2
# of unresolved testcases       4

spawn -ignore SIGHUP
/home/seurer/gcc/git/build/gcc-test2/gcc/testsuite/g++/../../xg++
-B/home/seurer/gcc/git/build/gcc-test2/gcc/testsuite/g++/../../
-fdiagnostics-plain-output -nostdinc++
-I/home/seurer/gcc/git/build/gcc-test2/powerpc64-unknown-linux-gnu/libstdc++-v3/include/powerpc64-unknown-linux-gnu
-I/home/seurer/gcc/git/build/gcc-test2/powerpc64-unknown-linux-gnu/libstdc++-v3/include
-I/home/seurer/gcc/git/gcc-test2/libstdc++-v3/libsupc++
-I/home/seurer/gcc/git/gcc-test2/libstdc++-v3/include/backward
-I/home/seurer/gcc/git/gcc-test2/libstdc++-v3/testsuite/util -fmessage-length=0
-std=gnu++14 -flto -g -O2 -fno-inline -flto-partition=max -Wno-return-type -c
-o cp_lto_pr65549_0.o
/home/seurer/gcc/git/gcc-test2/gcc/testsuite/g++.dg/lto/pr65549_0.C
hash table checking failed: equal operator returns true for a pair of values
with a different hash value
/home/seurer/gcc/git/gcc-test2/gcc/testsuite/g++.dg/lto/pr65549_0.C: In
substitution of 'template<class _Res, class ... _ArgTypes> template<class,
class> using _Requires = int [with <template-parameter-2-1> = std::__and_<int>;
<template-parameter-2-2> = void; _Res = void; _ArgTypes = {}]':
/home/seurer/gcc/git/gcc-test2/gcc/testsuite/g++.dg/lto/pr65549_0.C:71:32:  
required by substitution of 'template<class _Functor, class>
std::function<void()>::function(_Functor) [with _Functor = main()::<lambda()>;
<template-parameter-1-2> = <missing>]'
/home/seurer/gcc/git/gcc-test2/gcc/testsuite/g++.dg/lto/pr65549_0.C:144:4:  
required from here
/home/seurer/gcc/git/gcc-test2/gcc/testsuite/g++.dg/lto/pr65549_0.C:71:32:
internal compiler error: in hashtab_chk_error, at hash-table.c:137
0x102b63b3 hashtab_chk_error()
        /home/seurer/gcc/git/gcc-test2/gcc/hash-table.c:137
0x10645307 hash_table<spec_hasher, false, xcallocator>::verify(spec_entry*
const&, unsigned int)
        /home/seurer/gcc/git/gcc-test2/gcc/hash-table.h:1033
0x10645503 hash_table<spec_hasher, false,
xcallocator>::find_with_hash(spec_entry* const&, unsigned int)
        /home/seurer/gcc/git/gcc-test2/gcc/hash-table.h:918
0x105c9ba7 retrieve_specialization
        /home/seurer/gcc/git/gcc-test2/gcc/cp/pt.c:1302
0x1062a013 instantiate_template_1
        /home/seurer/gcc/git/gcc-test2/gcc/cp/pt.c:20973
0x1062a013 instantiate_template(tree_node*, tree_node*, int)
        /home/seurer/gcc/git/gcc-test2/gcc/cp/pt.c:21099
0x105e1073 instantiate_alias_template
        /home/seurer/gcc/git/gcc-test2/gcc/cp/pt.c:21137
0x105e1073 tsubst(tree_node*, tree_node*, int, tree_node*)
        /home/seurer/gcc/git/gcc-test2/gcc/cp/pt.c:15395
0x106147ef type_unification_real
        /home/seurer/gcc/git/gcc-test2/gcc/cp/pt.c:22318
0x10634503 fn_type_unification(tree_node*, tree_node*, tree_node*, tree_node*
const*, unsigned int, tree_node*, unification_kind_t, int, conversion**, bool,
bool)
        /home/seurer/gcc/git/gcc-test2/gcc/cp/pt.c:21493
0x102d0ec3 add_template_candidate_real
        /home/seurer/gcc/git/gcc-test2/gcc/cp/call.c:3441
0x102d1e1b add_template_candidate
        /home/seurer/gcc/git/gcc-test2/gcc/cp/call.c:3529
0x102d1e1b add_candidates
        /home/seurer/gcc/git/gcc-test2/gcc/cp/call.c:5955
0x102daa47 add_candidates
        /home/seurer/gcc/git/gcc-test2/gcc/cp/call.c:4087
0x102daa47 build_user_type_conversion_1
        /home/seurer/gcc/git/gcc-test2/gcc/cp/call.c:4087
0x102cd873 implicit_conversion_1
        /home/seurer/gcc/git/gcc-test2/gcc/cp/call.c:2078
0x102cd873 implicit_conversion
        /home/seurer/gcc/git/gcc-test2/gcc/cp/call.c:2118
0x102d01d3 add_function_candidate
        /home/seurer/gcc/git/gcc-test2/gcc/cp/call.c:2428
0x102d1cf3 add_candidates
        /home/seurer/gcc/git/gcc-test2/gcc/cp/call.c:5968
0x102e4eab add_candidates
        /home/seurer/gcc/git/gcc-test2/gcc/cp/call.c:10459

[Bug c++/98926] [11 regression] several ICEs after r11-7011

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

[Bug c++/98926] [11 regression] several ICEs after r11-7011

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

--- Comment #5 from Jason Merrill <jason at gcc dot gnu.org> ---
Hmm, I just did a bootstrap/check on gcc112, and don't get any of the ICEs, but
I do see the alias-decl-52.C failure, so I'll poke more at that.

[Bug c++/98926] [11 regression] several ICEs after r11-7011

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I can reproduce it on x86_64 with extra options:
./cc1plus -quiet -fnon-call-exceptions -fno-inline-functions-called-once
-fno-tree-sra --param early-inlining-insns=1 pr94582.C -fchecking=2
--param=hash-table-verification-limit=1000000

[Bug c++/98926] [11 regression] several ICEs after r11-7011

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

--- Comment #7 from seurer at gcc dot gnu.org ---
gcc112 is an LE machine and the ICEs were mostly on BE.  Try it on gcc110 or
203 which appear to be BE.

Looking through my logs I see I got different errors and ICEs on different LE
machines.  Maybe the hardware level (power 8 vs. 9 for instance) has something
to do with it.

[Bug c++/98926] [11 regression] several ICEs after r11-7011

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

--- Comment #8 from seurer at gcc dot gnu.org ---
Here was what I saw on a power 8 comparing r11-7010 with r11-7011:


previous run: g:bec5dbae5649da4bd7ea2731a8446ac481cb78ab, r11-7010: 50 failures
this run    : g:6e0a231a4aa2407bb7167daf98a37795a67364d8, r11-7011: 61 failures

FAIL: g++.dg/cpp0x/alias-decl-52.C  -std=c++2a (internal compiler error)
FAIL: g++.dg/cpp0x/alias-decl-52.C  -std=c++2a (test for excess errors)
FAIL: g++.dg/lto/pr65549 cp_lto_pr65549_0.o assemble,  -std=gnu++14 -flto -g
-O2 -fno-inline -flto-partition=max -Wno-return-type  (internal compiler error)
FAIL: g++.dg/lto/pr65549 cp_lto_pr65549_0.o assemble,  -std=gnu++14 -flto -g
-Wno-return-type  (internal compiler error)
FAIL: g++.dg/pr77550.C   (test for excess errors)
FAIL: g++.dg/warn/Warray-bounds15.C  -std=gnu++14  (test for warnings, line 38)
FAIL: g++.dg/warn/Warray-bounds15.C  -std=gnu++14 (internal compiler error)
FAIL: g++.dg/warn/Warray-bounds15.C  -std=gnu++14 (test for excess errors)
FAIL: g++.dg/warn/Warray-bounds15.C  -std=gnu++17  (test for warnings, line 38)
FAIL: g++.dg/warn/Warray-bounds15.C  -std=gnu++17 (internal compiler error)
FAIL: g++.dg/warn/Warray-bounds15.C  -std=gnu++17 (test for excess errors)

[Bug c++/98926] [11 regression] several ICEs after r11-7011

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:5c62e4f255bfac65e18213fd93ee1c9908b4a750

commit r11-7089-g5c62e4f255bfac65e18213fd93ee1c9908b4a750
Author: Jason Merrill <jason@redhat.com>
Date:   Wed Feb 3 00:29:00 2021 -0500

    c++: Fix alias comparison [PR98926]

    The comparison of dependent aliases wasn't working here because
    processing_template_decl wasn't set, so dependent_alias_template_spec_p was
    always returning false.

    gcc/cp/ChangeLog:

            PR c++/98926
            PR c++/98570
            * pt.c (spec_hasher::equal): Set processing_template_decl.
            * Make-lang.in (check-g++-strict-gc): Add --param
            hash-table-verification-limit=10000.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/alias-decl-dr1558.C: Pass --param
            hash-table-verification-limit=10000.

[Bug c++/98926] [11 regression] several ICEs after r11-7011

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98926

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #10 from seurer at gcc dot gnu.org ---
I tried the update on all the machines where I had seen failures and everything
works now.

Thanks!