[Bug fortran/98979] New: [11 regression] ICE in several tests cases after r11-7112

[Bug fortran/98979] New: [11 regression] ICE in several tests cases after r11-7112

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

            Bug ID: 98979
           Summary: [11 regression] ICE in several tests cases after
                    r11-7112
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:9a4d32f85ccebc0ee4b24e6d9d7a4f11c04d7146, r11-7112

previous run: g:f743fe231663e32d52db987650d0ec3381a777af, r11-7111: 75 failures
this run    : g:9a4d32f85ccebc0ee4b24e6d9d7a4f11c04d7146, r11-7112: 89 failures

FAIL: gfortran.dg/goacc/array-with-dt-2.f90   -O  (internal compiler error)
FAIL: gfortran.dg/goacc/array-with-dt-2.f90   -O  (test for excess errors)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O0  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O0  (test for excess errors)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O1  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O1  (test for excess errors)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O2  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O2  (test for excess errors)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  (test for excess errors)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O3 -g  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O3 -g  (test for excess errors)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -Os  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -Os  (test for excess errors)


/home/seurer/gcc/git/gcc-test/gcc/testsuite/gfortran.dg/goacc/array-with-dt-2.f90:8:34:
internal compiler error: Segmentation fault
0x10c21d1b crash_signal
        /home/seurer/gcc/git/gcc-test/gcc/toplev.c:327
0x10404f18 gfc_conv_scalarized_array_ref
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans-array.c:3570
0x10406913 gfc_conv_array_ref(gfc_se*, gfc_array_ref*, gfc_expr*, locus*)
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans-array.c:3721
0x1045ad07 gfc_conv_variable
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans-expr.c:2998
0x10453f6b gfc_conv_expr(gfc_se*, gfc_expr*)
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans-expr.c:8886
0x104614bb gfc_conv_expr_reference(gfc_se*, gfc_expr*, bool)
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans-expr.c:8986
0x104a01d7 gfc_trans_omp_array_section
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans-openmp.c:2157
0x104aaf1f gfc_trans_omp_clauses
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans-openmp.c:3151
0x104bace7 gfc_trans_oacc_executable_directive
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans-openmp.c:3984
0x104bace7 gfc_trans_oacc_directive(gfc_code*)
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans-openmp.c:6124
0x103fab57 trans_code
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans.c:2216
0x1043d48f gfc_generate_function_code(gfc_namespace*)
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans-decl.c:6880
0x103fb56b gfc_generate_code(gfc_namespace*)
        /home/seurer/gcc/git/gcc-test/gcc/fortran/trans.c:2272
0x1037df87 translate_all_program_units
        /home/seurer/gcc/git/gcc-test/gcc/fortran/parse.c:6351
0x1037df87 gfc_parse_file()
        /home/seurer/gcc/git/gcc-test/gcc/fortran/parse.c:6620
0x103efa1f gfc_be_parse_file
        /home/seurer/gcc/git/gcc-test/gcc/fortran/f95-lang.c:212

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Build|powerpc64*-linux-gnu        |powerpc64*-linux-gnu,
                   |                            |x86_64-apple-darwin20.3.0
               Host|powerpc64*-linux-gnu        |powerpc64*-linux-gnu,
                   |                            |x86_64-apple-darwin20.3.0
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |iains at gcc dot gnu.org
             Target|powerpc64*-linux-gnu        |powerpc64*-linux-gnu,
                   |                            |x86_64-apple-darwin20.3.0
   Last reconfirmed|                            |2021-02-06

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Confirmed on x86_64-apple-darwin20.3.0

FAIL: gfortran.dg/goacc/array-with-dt-2.f90   -O  (internal compiler error)
FAIL: gfortran.dg/goacc/array-with-dt-2.f90   -O  (test for excess errors)
FAIL: gfortran.dg/goacc/derived-chartypes-1.f90   -O  (internal compiler error)
FAIL: gfortran.dg/goacc/derived-chartypes-1.f90   -O  (test for excess errors)
FAIL: gfortran.dg/goacc/derived-chartypes-2.f90   -O  (internal compiler error)
FAIL: gfortran.dg/goacc/derived-chartypes-2.f90   -O  (test for excess errors)

and

FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O0  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O0  (test for excess errors)
UNRESOLVED: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O0  compilation failed to produce
executable
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O1  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O1  (test for excess errors)
UNRESOLVED: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O1  compilation failed to produce
executable
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O2  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O2  (test for excess errors)
UNRESOLVED: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O2  compilation failed to produce
executable
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  (test for excess errors)
UNRESOLVED: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  compilation failed to produce
executable
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O3 -g  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O3 -g  (test for excess errors)
UNRESOLVED: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -O3 -g  compilation failed to produce
executable
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -Os  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -Os  (test for excess errors)
UNRESOLVED: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -Os  compilation failed to produce
executable
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -g -flto  (internal compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -g -flto  (test for excess errors)
UNRESOLVED: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -g -flto  compilation failed to produce
executable
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -g -O3 -fwhole-program -flto  (internal
compiler error)
FAIL: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -g -O3 -fwhole-program -flto  (test for
excess errors)
UNRESOLVED: libgomp.oacc-fortran/array-stride-dt-1.f90 -DACC_DEVICE_TYPE_host=1
-DACC_MEM_SHARED=1 -foffload=disable  -g -O3 -fwhole-program -flto  compilation
failed to produce executable

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

David Edelsohn <dje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|powerpc64*-linux-gnu,       |powerpc64*-linux-gnu,
                   |x86_64-apple-darwin20.3.0   |x86_64-apple-darwin20.3.0,
                   |                            |powerpc*-aix
                 CC|                            |dje at gcc dot gnu.org
               Host|powerpc64*-linux-gnu,       |powerpc64*-linux-gnu,
                   |x86_64-apple-darwin20.3.0   |x86_64-apple-darwin20.3.0,
                   |                            |powerpc*-aix
              Build|powerpc64*-linux-gnu,       |powerpc64*-linux-gnu,
                   |x86_64-apple-darwin20.3.0   |x86_64-apple-darwin20.3.0,
                   |                            |powerpc*-aix

--- Comment #2 from David Edelsohn <dje at gcc dot gnu.org> ---
AIX also.

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
everywhere.

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
For crossref, as Julian stated in
https://gcc.gnu.org/pipermail/gcc-patches/2021-February/564920.html :

"Oops -- I tested on a tree with the following patch already applied:
 https://gcc.gnu.org/pipermail/gcc-patches/2021-February/564711.html
 That patch fixes these failures."

(That's part 3/4 of the patch series, which still is pending final approval –
but we are getting there ...)

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

--- Comment #5 from seurer at gcc dot gnu.org ---
For completeness, the new test case added for this in
g:b2d84e9f9cccbe4ee662f7002b83105629d09939, r11-7113 also fails:

make  -k check-gcc
RUNTESTFLAGS="goacc.exp=gfortran.dg/goacc/derived-chartypes-1.f90"
FAIL: gfortran.dg/goacc/derived-chartypes-1.f90   -O  (internal compiler error)
FAIL: gfortran.dg/goacc/derived-chartypes-1.f90   -O  (test for excess errors)
# of unexpected failures        2

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Julian Brown <jules@gcc.gnu.org>:

https://gcc.gnu.org/g:b0fb2720d88d680af18981a2097397196b505a1f

commit r11-7160-gb0fb2720d88d680af18981a2097397196b505a1f
Author: Julian Brown <julian@codesourcery.com>
Date:   Tue Feb 9 14:09:00 2021 -0800

    Revert "openacc: Allow strided arrays in update directives"

    This patch reverts the non-testsuite parts of commit
    9a4d32f85ccebc0ee4b24e6d9d7a4f11c04d7146 which cause ICEs without the
    yet-to-be-approved patch here:

      https://gcc.gnu.org/pipermail/gcc-patches/2021-February/564711.html

    gcc/fortran/

            PR fortran/98979
            * openmp.c (resolve_omp_clauses): Omit OpenACC update in
            contiguity check and stride-specified error.

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Julian Brown <jules@gcc.gnu.org>:

https://gcc.gnu.org/g:f7fb2f662fe12f327ece8b034ab76b36fdca4696

commit r11-7161-gf7fb2f662fe12f327ece8b034ab76b36fdca4696
Author: Julian Brown <julian@codesourcery.com>
Date:   Tue Feb 9 12:00:14 2021 -0800

    openacc: Add XFAILs [PR98979]

    This patch adds some XFAILs for PR98979 until the patch to fix them has
    been approved. See:

      https://gcc.gnu.org/pipermail/gcc-patches/2021-February/564711.html

    gcc/testsuite/
            PR fortran/98979
            * gfortran.dg/goacc/array-with-dt-2.f90: Add expected errors.
            * gfortran.dg/goacc/derived-chartypes-1.f90: Skip ICEing test.
            * gfortran.dg/goacc/derived-chartypes-2.f90: Likewise.

    libgomp/
            PR fortran/98979
            * testsuite/libgomp.oacc-fortran/array-stride-dt-1.f90: Add
expected
            errors.

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Has this been fixed?

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

--- Comment #9 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #8)
> Has this been fixed?

The XFAIL of comment 7 should have fixed the intermittent fails.

 * * *

The proper fix was:
https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565250.html (+ next two
emails)

Committed on Feb 21, 2021:

https://gcc.gnu.org/g:d28f3da11d8c0aed9b746689d723022a9b5ec04c
openacc: Fix lowering for derived-type mappings through array elements

https://gcc.gnu.org/g:366cf1127a547ff77024a551abb01bb1a6e963cd
openacc: Strided array sections and components of derived-type arrays


Can you confirmed that it is now fixed for powerpc64*-linux-gnu,
x86_64-apple-darwin20.3.0, powerpc*-aix ?

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

--- Comment #10 from seurer at gcc dot gnu.org ---
I looked at the most recent powerpc64 runs (all varieties) and it is no longer
failing there.

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

--- Comment #11 from David Edelsohn <dje at gcc dot gnu.org> ---
The failures have been resolved on AIX.

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

--- Comment #12 from Iain Sandoe <iains at gcc dot gnu.org> ---
the failures are resolved on Darwin too.

[Bug fortran/98979] [11 regression] ICE in several tests cases after r11-7112

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98979

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|WAITING                     |RESOLVED

--- Comment #13 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Expected to be fixed by the mentioned patches – confirmed to be fixed – well,
then we can also mark as as FIXED!

Thanks for Julian for the commits – and thanks to all for reporting the bug &
checking that it is indeed fixed :-)