[Bug fortran/99206] New: [11 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:1980

[Bug fortran/99206] New: [11 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:1980

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99206

            Bug ID: 99206
           Summary: [11 Regression] ICE in add_init_expr_to_sym, at
                    fortran/decl.c:1980
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20200823 and 20201004 :
(z1 is invalid, z2 looks valid)


$ cat z1.f90
program p
   character(:), parameter :: a(0) = reshape(['a'], [0])
end


$ cat z2.f90
program p
   character(*), parameter :: a(0) = reshape(['a'], [0])
end


$ gfortran-11-20200823 -c z1.f90
z1.f90:2:34:

    2 |    character(:), parameter :: a(0) = reshape(['a'], [0])
      |                                  1
Error: Entity 'a' at (1) has a deferred type parameter and requires either the
POINTER or ALLOCATABLE attribute


$ gfortran-11-20210221 -c z1.f90
f951: internal compiler error: in add_init_expr_to_sym, at fortran/decl.c:1980
0x66d3e0 add_init_expr_to_sym
        ../../gcc/fortran/decl.c:1980
0x676f8a variable_decl
        ../../gcc/fortran/decl.c:2996
0x676f8a gfc_match_data_decl()
        ../../gcc/fortran/decl.c:6203
0x6db9c3 match_word
        ../../gcc/fortran/parse.c:65
0x6db9c3 decode_statement
        ../../gcc/fortran/parse.c:376
0x6dd40c next_free
        ../../gcc/fortran/parse.c:1316
0x6dd40c next_statement
        ../../gcc/fortran/parse.c:1548
0x6df7d4 parse_spec
        ../../gcc/fortran/parse.c:3783
0x6e184c parse_progunit
        ../../gcc/fortran/parse.c:5896
0x6e2f41 gfc_parse_file()
        ../../gcc/fortran/parse.c:6437
0x72f98f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:212

[Bug fortran/99206] [11 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:1980

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99206

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
             Status|UNCONFIRMED                 |NEW
      Known to work|                            |10.2.1
      Known to fail|                            |11.0
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-02-22
   Target Milestone|---                         |11.0

--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.

gcc-10 emits an appropriate error message for z1 and accepts z2.

[Bug fortran/99206] [11 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:1980

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99206

--- Comment #2 from anlauf at gcc dot gnu.org ---
As a sidenote:

  print *, len (reshape (['a'], [0]))
end

This prints 0 for gcc-11, and the correct value 1 for 10.2.1.
Do we screw up things during simplification?

[Bug fortran/99206] [11 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:1980

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99206

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
Potential fix that sets the string length (not regtested):

diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c
index 35f267db588..388aca7c38c 100644
--- a/gcc/fortran/simplify.c
+++ b/gcc/fortran/simplify.c
@@ -6887,6 +6887,8 @@ gfc_simplify_reshape (gfc_expr *source, gfc_expr
*shape_exp,
                               &source->where);
   if (source->ts.type == BT_DERIVED)
     result->ts.u.derived = source->ts.u.derived;
+  if (source->ts.type == BT_CHARACTER && result->ts.u.cl == NULL)
+    result->ts = source->ts;
   result->rank = rank;
   result->shape = gfc_get_shape (rank);
   for (i = 0; i < rank; i++)

[Bug fortran/99206] [11 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:1980

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99206

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #4 from anlauf at gcc dot gnu.org ---
Patch: https://gcc.gnu.org/pipermail/fortran/2021-February/055745.html

[Bug fortran/99206] [11 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:1980

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99206

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |pault at gcc dot gnu.org

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Just for the record, started with r11-2919-g9d463ce7f983f03f.

[Bug fortran/99206] [11 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:1980

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99206

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:a6c7e0fcffc857e67dffdd7609be663cc3aac7d2

commit r11-7348-ga6c7e0fcffc857e67dffdd7609be663cc3aac7d2
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Feb 23 19:09:14 2021 +0100

    PR fortran/99206 - ICE in add_init_expr_to_sym, at fortran/decl.c:1980

    Make sure that the string length is properly set during simplification
    even when the resulting array is zero-sized.

    gcc/fortran/ChangeLog:

            PR fortran/99206
            * simplify.c (gfc_simplify_reshape): Set string length for
            character arguments.

    gcc/testsuite/ChangeLog:

            PR fortran/99206
            * gfortran.dg/reshape_zerosize_4.f90: New test.

[Bug fortran/99206] [11 Regression] ICE in add_init_expr_to_sym, at fortran/decl.c:1980

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99206

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from anlauf at gcc dot gnu.org ---
Fixed on mainline.

Thanks for the report!