public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug other/99261] New: [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365
@ 2021-02-24 21:38 seurer at gcc dot gnu.org
  2021-02-24 21:44 ` [Bug other/99261] " redi at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: seurer at gcc dot gnu.org @ 2021-02-24 21:38 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99261

            Bug ID: 99261
           Summary: [11 regression] 20_util/to_chars/long_double.cc fails
                    after r11-7365
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

f90027d18a94d02ba8f3b7503c5f0835f432a89e, r11-7365

make  -k check RUNTESTFLAGS="conformance.exp=20_util/to_chars/long_double.cc"
FAIL: 20_util/to_chars/long_double.cc execution test
# of expected passes            1
# of unexpected failures        1


/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/20_util/to_chars/long_double.cc:171:
void test02(): Assertion '!memcmp(printf_buffer, to_chars_buffer,
output_length)' failed.
FAIL: 20_util/to_chars/long_double.cc execution test

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug other/99261] [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365
  2021-02-24 21:38 [Bug other/99261] New: [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365 seurer at gcc dot gnu.org
@ 2021-02-24 21:44 ` redi at gcc dot gnu.org
  2021-02-24 21:49 ` redi at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-02-24 21:44 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99261

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Wasn't it already failing?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug other/99261] [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365
  2021-02-24 21:38 [Bug other/99261] New: [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365 seurer at gcc dot gnu.org
  2021-02-24 21:44 ` [Bug other/99261] " redi at gcc dot gnu.org
@ 2021-02-24 21:49 ` redi at gcc dot gnu.org
  2021-02-24 22:00 ` [Bug libstdc++/99261] " seurer at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-02-24 21:49 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99261

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2021-02-24
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
     Ever confirmed|0                           |1
   Target Milestone|---                         |11.0

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Huh, no, the failure is new for LE.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libstdc++/99261] [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365
  2021-02-24 21:38 [Bug other/99261] New: [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365 seurer at gcc dot gnu.org
  2021-02-24 21:44 ` [Bug other/99261] " redi at gcc dot gnu.org
  2021-02-24 21:49 ` redi at gcc dot gnu.org
@ 2021-02-24 22:00 ` seurer at gcc dot gnu.org
  2021-02-24 22:34 ` cvs-commit at gcc dot gnu.org
  2021-02-24 22:35 ` redi at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: seurer at gcc dot gnu.org @ 2021-02-24 22:00 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99261

--- Comment #3 from seurer at gcc dot gnu.org ---
              char to_chars_buffer[output_length];
              auto result = to_chars(to_chars_buffer,
                                     to_chars_buffer+output_length,
                                     value, fmt, precision);
              VERIFY( result.ec == errc{} );
              VERIFY( !memcmp(printf_buffer, to_chars_buffer, output_length) );



Dumping out the values of things on the VERIFY that fails I see

output_length: 8

printf_buffer:   1.000000
to_chars_buffer: 0???????



There is another PR for the long_double test cases but that is something
different unless this fix triggers the other thing.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libstdc++/99261] [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365
  2021-02-24 21:38 [Bug other/99261] New: [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365 seurer at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2021-02-24 22:00 ` [Bug libstdc++/99261] " seurer at gcc dot gnu.org
@ 2021-02-24 22:34 ` cvs-commit at gcc dot gnu.org
  2021-02-24 22:35 ` redi at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-02-24 22:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99261

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:94bfe81afedb6dbba877ee7c9f047375366f8996

commit r11-7379-g94bfe81afedb6dbba877ee7c9f047375366f8996
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Feb 24 22:25:31 2021 +0000

    libstdc++: Fix order of arguments to sprintf [PR 99261]

    libstdc++-v3/ChangeLog:

            PR libstdc++/99261
            * src/c++17/floating_to_chars.cc (sprintf_ld): Add extra args
            before value to be printed.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libstdc++/99261] [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365
  2021-02-24 21:38 [Bug other/99261] New: [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365 seurer at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2021-02-24 22:34 ` cvs-commit at gcc dot gnu.org
@ 2021-02-24 22:35 ` redi at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-02-24 22:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99261

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I did see the failure, but thought it was due to PR 98384.

Fixed now, and with Patrick's r11-7378 it also passes for -mabi=ieeelongdouble

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-24 22:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-24 21:38 [Bug other/99261] New: [11 regression] 20_util/to_chars/long_double.cc fails after r11-7365 seurer at gcc dot gnu.org
2021-02-24 21:44 ` [Bug other/99261] " redi at gcc dot gnu.org
2021-02-24 21:49 ` redi at gcc dot gnu.org
2021-02-24 22:00 ` [Bug libstdc++/99261] " seurer at gcc dot gnu.org
2021-02-24 22:34 ` cvs-commit at gcc dot gnu.org
2021-02-24 22:35 ` redi at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).