public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "roland.illig at gmx dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/99275] New: missing space in 'argument missing terminating nul'
Date: Thu, 25 Feb 2021 21:46:30 +0000	[thread overview]
Message-ID: <bug-99275-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99275

            Bug ID: 99275
           Summary: missing space in 'argument missing terminating nul'
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: roland.illig at gmx dot de
  Target Milestone: ---

builtins.c says:
> warned = warning_at (loc, OPT_Wstringop_overread,
>                      "%qsargument missing terminating nul",
>                      fname);

This confused me as the German translator.

First, I thought that fname was a filename, which didn't make sense at all. It
took me some minutes to find out that fname was supposed to be the function
name, I would have expected fnname for that.

Then I wondered why there is no space between %qs and 'argument'.

Then I wondered how this missing space could have passed the test suite, as the
test suite does contain several instances of dg-message for this diagnostic.
The tricky point here is that there are two diagnostics that are almost the
same, the other one uses %qD instead of %qs.

A possible explanation for missing the missing space is that to avoid to test
the varying quotes, that part of the diagnostic is generally not tested. But
shouldn't the quotes in LC_ALL=C always be simple ASCII quotes, making this
simple?

While here, there's a typo in a comment in warn_string_no_nul: "the nuber of
messages" should be "the number of messages".

             reply	other threads:[~2021-02-25 21:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 21:46 roland.illig at gmx dot de [this message]
2021-02-26  7:14 ` [Bug c/99275] " rguenth at gcc dot gnu.org
2021-02-26  7:52 ` cvs-commit at gcc dot gnu.org
2021-02-26  7:52 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99275-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).