public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/99291] New: maybe_warn_pass_by_reference uses outdated format string
@ 2021-02-26 16:32 roland.illig at gmx dot de
2021-02-27 1:14 ` [Bug c/99291] " roland.illig at gmx dot de
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: roland.illig at gmx dot de @ 2021-02-26 16:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99291
Bug ID: 99291
Summary: maybe_warn_pass_by_reference uses outdated format
string
Product: gcc
Version: 11.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c
Assignee: unassigned at gcc dot gnu.org
Reporter: roland.illig at gmx dot de
Target Milestone: ---
tree-ssa-uninit.c says:
> inform (loc, "in a call to %qD declared with "
> "attribute %<%s%> here", fndecl, access_str);
This format string uses the sequence %<%s%>, for which there is the shortcut
%qs.
Using the %<%s%> should be detected and prevented by check_plain in c-format.c.
Is that check not active by default?
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/99291] maybe_warn_pass_by_reference uses outdated format string
2021-02-26 16:32 [Bug c/99291] New: maybe_warn_pass_by_reference uses outdated format string roland.illig at gmx dot de
@ 2021-02-27 1:14 ` roland.illig at gmx dot de
2021-02-27 1:15 ` roland.illig at gmx dot de
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: roland.illig at gmx dot de @ 2021-02-27 1:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99291
--- Comment #1 from Roland Illig <roland.illig at gmx dot de> ---
similarly in common/config/riscv/riscv-common.c:
> %<-march=%s%>: Extension `%s' appear more than one time.
The `%s' is obsolete and should be replaced with %qs.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/99291] maybe_warn_pass_by_reference uses outdated format string
2021-02-26 16:32 [Bug c/99291] New: maybe_warn_pass_by_reference uses outdated format string roland.illig at gmx dot de
2021-02-27 1:14 ` [Bug c/99291] " roland.illig at gmx dot de
@ 2021-02-27 1:15 ` roland.illig at gmx dot de
2021-02-27 1:20 ` roland.illig at gmx dot de
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: roland.illig at gmx dot de @ 2021-02-27 1:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99291
--- Comment #2 from Roland Illig <roland.illig at gmx dot de> ---
Plus, there is a typo:
> %<-march=%s%>: Extension `%s' appear more than one time.
Either it must be 'Extensions' or 'appears'.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/99291] maybe_warn_pass_by_reference uses outdated format string
2021-02-26 16:32 [Bug c/99291] New: maybe_warn_pass_by_reference uses outdated format string roland.illig at gmx dot de
2021-02-27 1:14 ` [Bug c/99291] " roland.illig at gmx dot de
2021-02-27 1:15 ` roland.illig at gmx dot de
@ 2021-02-27 1:20 ` roland.illig at gmx dot de
2021-02-27 1:20 ` roland.illig at gmx dot de
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: roland.illig at gmx dot de @ 2021-02-27 1:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99291
--- Comment #3 from Roland Illig <roland.illig at gmx dot de> ---
same file, another one:
> "version of `g` will be omitted, please "
This is far from any coding conventions and should rather be %<g%>.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/99291] maybe_warn_pass_by_reference uses outdated format string
2021-02-26 16:32 [Bug c/99291] New: maybe_warn_pass_by_reference uses outdated format string roland.illig at gmx dot de
` (2 preceding siblings ...)
2021-02-27 1:20 ` roland.illig at gmx dot de
@ 2021-02-27 1:20 ` roland.illig at gmx dot de
2021-02-27 13:05 ` redi at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: roland.illig at gmx dot de @ 2021-02-27 1:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99291
--- Comment #4 from Roland Illig <roland.illig at gmx dot de> ---
and another one, this time in aarch64.c:
> error ("%<%s%> must be by itself for %<-mharden-sls=%>", str);
This should be %qs as well.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/99291] maybe_warn_pass_by_reference uses outdated format string
2021-02-26 16:32 [Bug c/99291] New: maybe_warn_pass_by_reference uses outdated format string roland.illig at gmx dot de
` (3 preceding siblings ...)
2021-02-27 1:20 ` roland.illig at gmx dot de
@ 2021-02-27 13:05 ` redi at gcc dot gnu.org
2021-03-01 12:06 ` marxin at gcc dot gnu.org
2022-03-03 23:19 ` roland.illig at gmx dot de
6 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2021-02-27 13:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99291
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Keywords| |diagnostic
Last reconfirmed| |2021-02-27
Ever confirmed|0 |1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/99291] maybe_warn_pass_by_reference uses outdated format string
2021-02-26 16:32 [Bug c/99291] New: maybe_warn_pass_by_reference uses outdated format string roland.illig at gmx dot de
` (4 preceding siblings ...)
2021-02-27 13:05 ` redi at gcc dot gnu.org
@ 2021-03-01 12:06 ` marxin at gcc dot gnu.org
2022-03-03 23:19 ` roland.illig at gmx dot de
6 siblings, 0 replies; 8+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-03-01 12:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99291
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org,
| |msebor at gcc dot gnu.org
--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
The '%<%s%>' is currently supported, but not triggered for some reason.
Martin?
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c/99291] maybe_warn_pass_by_reference uses outdated format string
2021-02-26 16:32 [Bug c/99291] New: maybe_warn_pass_by_reference uses outdated format string roland.illig at gmx dot de
` (5 preceding siblings ...)
2021-03-01 12:06 ` marxin at gcc dot gnu.org
@ 2022-03-03 23:19 ` roland.illig at gmx dot de
6 siblings, 0 replies; 8+ messages in thread
From: roland.illig at gmx dot de @ 2022-03-03 23:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99291
--- Comment #6 from Roland Illig <roland.illig at gmx dot de> ---
Still reproducible in GCC 12.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-03 23:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-26 16:32 [Bug c/99291] New: maybe_warn_pass_by_reference uses outdated format string roland.illig at gmx dot de
2021-02-27 1:14 ` [Bug c/99291] " roland.illig at gmx dot de
2021-02-27 1:15 ` roland.illig at gmx dot de
2021-02-27 1:20 ` roland.illig at gmx dot de
2021-02-27 1:20 ` roland.illig at gmx dot de
2021-02-27 13:05 ` redi at gcc dot gnu.org
2021-03-01 12:06 ` marxin at gcc dot gnu.org
2022-03-03 23:19 ` roland.illig at gmx dot de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).