public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/99305] [11 Regression] range condition simplification after inlining
Date: Tue, 09 Mar 2021 12:20:34 +0000	[thread overview]
Message-ID: <bug-99305-4-hfoBJiNWQf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99305-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99305

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
--- gcc/tree-ssa-phiopt.c.jj    2021-01-22 11:41:38.078708425 +0100
+++ gcc/tree-ssa-phiopt.c       2021-03-09 13:15:02.649094949 +0100
@@ -808,14 +808,14 @@ conditional_replacement (basic_block con
     nonzero_arg = arg0;
   else
     return false;
-  if (integer_all_onesp (nonzero_arg))
-    neg = true;
-  else if (integer_pow2p (nonzero_arg))
+  if (integer_pow2p (nonzero_arg))
     {
       shift = tree_log2 (nonzero_arg);
       if (shift && POINTER_TYPE_P (TREE_TYPE (nonzero_arg)))
        return false;
     }
+  else if (integer_all_onesp (nonzero_arg))
+    neg = true;
   else
     return false;

should fix this I think.  For bool, integer_all_onesp and integer_onep and
integer_pow2p are all true...
We shouldn't negate in that case.

  parent reply	other threads:[~2021-03-09 12:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-27 14:23 [Bug rtl-optimization/99305] New: " nok.raven at gmail dot com
2021-03-01  9:22 ` [Bug rtl-optimization/99305] " rguenth at gcc dot gnu.org
2021-03-09 12:02 ` [Bug tree-optimization/99305] " jakub at gcc dot gnu.org
2021-03-09 12:20 ` jakub at gcc dot gnu.org [this message]
2021-03-09 12:20 ` jakub at gcc dot gnu.org
2021-03-09 12:41 ` jakub at gcc dot gnu.org
2021-03-09 18:13 ` cvs-commit at gcc dot gnu.org
2021-03-09 18:14 ` jakub at gcc dot gnu.org
2021-03-10 16:41 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99305-4-hfoBJiNWQf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).